Fix regression where AdvancedTag.getAttribute didn't take a second param for default value. This also broke calling '.value' on an AdvancedTag. Fix, with tests.

Author: kata198

AdvancedHTMLParser/Tags.py

@@ -593,12 +593,12 @@ def value(self):
         '''
         return self.getAttribute('value', '')
 
-    def getAttribute(self, attrName):
+    def getAttribute(self, attrName, defaultValue=None):
         '''
             getAttribute - Gets an attribute on this tag. Be wary using this for classname, maybe use addClass/removeClass. Attribute names are all lowercase.
                 @return - The attribute value, or None if none exists.
            '''
-        return self.attributes.get(attrName, None)
+        return self.attributes.get(attrName, defaultValue)
 
     def setAttribute(self, attrName, attrValue):
         '''

ChangeLog

@@ -1,3 +1,10 @@
+* 6.6.4 (unreleased)
+- Fix regression where "AdvancedTag.getAttribute" method would not accept a default
+(second param).
+- Fix calling ".value" on an AdvancedTag to get the "value" attribute (was
+broken by previous regression)
+
+
 * 6.6.3 Oct 03 2016
 - Fix no-value attributes not appearing in html output (like "checked" on an input). Was in attributes, but not in html output.
 

tests/AdvancedHTMLParserTests/test_Attributes.py

@@ -113,6 +113,21 @@ def test_noValueAttributes(self):
         assert 'checked' in tag.attributes
         assert 'checked' in tag.outerHTML
 
+    def test_valueMethod(self):
+        parser = AdvancedHTMLParser()
+        parser.parseStr('<input id="item" type="text" value="hello" />')
+
+        tag = parser.getElementById('item')
+        assert tag.value == 'hello'
+
+    def test_attributeDefault(self):
+        parser = AdvancedHTMLParser()
+        parser.parseStr('<input id="item" type="text" value="hello" />')
+
+        tag = parser.getElementById('item')
+        assert tag.getAttribute('type', 'bloogity') == 'text'
+        assert tag.getAttribute('woogity', 'snoogity') == 'snoogity'
+
 
 if __name__ == '__main__':
     pipe  = subprocess.Popen('GoodTests.py "%s"' %(sys.argv[0],), shell=True).wait()