Skip to content

Commit 6a44987

Browse files
authored
Remove redundant nil check (#2194)
From the Go docs: "If the map is nil, the number of iterations is 0." [1] Therefore, an additional nil check for before the loop is unnecessary. [1]: https://go.dev/ref/spec#For_range Signed-off-by: Eng Zer Jun <[email protected]>
1 parent 9f53d15 commit 6a44987

File tree

3 files changed

+10
-16
lines changed

3 files changed

+10
-16
lines changed

context/response_recorder.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -244,12 +244,10 @@ func (w *ResponseRecorder) CopyTo(res ResponseWriter) {
244244
}
245245

246246
// append the headers
247-
if w.headers != nil {
248-
for k, values := range w.headers {
249-
for _, v := range values {
250-
if to.headers.Get(v) == "" {
251-
to.headers.Add(k, v)
252-
}
247+
for k, values := range w.headers {
248+
for _, v := range values {
249+
if to.headers.Get(v) == "" {
250+
to.headers.Add(k, v)
253251
}
254252
}
255253
}

context/response_writer.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -319,12 +319,10 @@ func (w *responseWriter) CopyTo(to ResponseWriter) {
319319
}
320320

321321
// append the headers
322-
if w.Header() != nil {
323-
for k, values := range w.Header() {
324-
for _, v := range values {
325-
if to.Header().Get(v) == "" {
326-
to.Header().Add(k, v)
327-
}
322+
for k, values := range w.Header() {
323+
for _, v := range values {
324+
if to.Header().Get(v) == "" {
325+
to.Header().Add(k, v)
328326
}
329327
}
330328
}

view/jet.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -282,10 +282,8 @@ func (s *JetEngine) initSet() {
282282
}
283283

284284
s.Set = jet.NewSet(s.loader, opts...)
285-
if s.vars != nil {
286-
for key, value := range s.vars {
287-
s.Set.AddGlobal(key, value)
288-
}
285+
for key, value := range s.vars {
286+
s.Set.AddGlobal(key, value)
289287
}
290288
}
291289
s.mu.Unlock()

0 commit comments

Comments
 (0)