Continue calling onDrag events even after the pointerout event #3476
Closed
brian-byassee
started this conversation in
Ideas
Replies: 2 comments 4 replies
-
Closing as I have found issues with this current update with envelope |
Beta Was this translation helpful? Give feedback.
0 replies
-
That event is assigned to the document object, so unless your waveworm is close to the edge of the page, it's supposed to continue dragging even outside of the waveform. Perhaps the listener isn't added correctly though. We should check that it fires only on the document object and not on a child element. It might need |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I updated the draggable.ts file here to support drag events even after the cursor has left the wave surfer. I think this makes the seekToDrag function more intuitive and inline with what users might expect when seeking through a video or audio file.
The thing is this could be a breaking change for applications that are expecting the pointerout event to fire onPointerUp.
Thoughts on if this changes feels safe enough or if this just isnt the sort of functionality wanted in wavesurfer.js
Here is the PR preview:
https://github.com/katspaugh/wavesurfer.js/compare/main...brian-byassee:wavesurfer.js:waversurfer-draggable-update?expand=1
Beta Was this translation helpful? Give feedback.
All reactions