linux: replace pactl calls with libpulse (#221)

Author: kavishdevar

linux/CMakeLists.txt

@@ -6,6 +6,8 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 find_package(Qt6 6.4 REQUIRED COMPONENTS Quick Widgets Bluetooth DBus)
 find_package(OpenSSL REQUIRED)
+find_package(PkgConfig REQUIRED)
+pkg_check_modules(PULSEAUDIO REQUIRED libpulse)
 
 qt_standard_project_setup(REQUIRES 6.4)
 
@@ -14,6 +16,8 @@ qt_add_executable(librepods
     logger.h
     media/mediacontroller.cpp
     media/mediacontroller.h
+    media/pulseaudiocontroller.cpp
+    media/pulseaudiocontroller.h
     airpods_packets.h
     trayiconmanager.cpp
     trayiconmanager.h
@@ -66,9 +70,11 @@ qt_add_resources(librepods "resources"
 )
 
 target_link_libraries(librepods
-    PRIVATE Qt6::Quick Qt6::Widgets Qt6::Bluetooth Qt6::DBus OpenSSL::SSL OpenSSL::Crypto
+    PRIVATE Qt6::Quick Qt6::Widgets Qt6::Bluetooth Qt6::DBus OpenSSL::SSL OpenSSL::Crypto ${PULSEAUDIO_LIBRARIES}
 )
 
+target_include_directories(librepods PRIVATE ${PULSEAUDIO_INCLUDE_DIRS})
+
 include(GNUInstallDirs)
 install(TARGETS librepods
     BUNDLE DESTINATION .

linux/main.cpp

@@ -967,7 +967,7 @@ int main(int argc, char *argv[]) {
     QApplication app(argc, argv);
 
     QSharedMemory sharedMemory;
-    sharedMemory.setKey("TcpServer-Key");
+    sharedMemory.setKey("TcpServer-Key2");
 
     // Check if app is already open
     if(sharedMemory.create(1) == false) 

linux/media/mediacontroller.cpp

@@ -2,14 +2,21 @@
 #include "logger.h"
 #include "eardetection.hpp"
 #include "playerstatuswatcher.h"
+#include "pulseaudiocontroller.h"
 
 #include <QDebug>
 #include <QProcess>
+#include <QThread>
 #include <QRegularExpression>
 #include <QDBusConnection>
 #include <QDBusConnectionInterface>
 
 MediaController::MediaController(QObject *parent) : QObject(parent) {
+  m_pulseAudio = new PulseAudioController(this);
+  if (!m_pulseAudio->initialize())
+  {
+    LOG_ERROR("Failed to initialize PulseAudio controller");
+  }
 }
 
 void MediaController::handleEarDetection(EarDetection *earDetection)
@@ -87,12 +94,9 @@ void MediaController::followMediaChanges() {
 }
 
 bool MediaController::isActiveOutputDeviceAirPods() {
-  QProcess process;
-  process.start("pactl", QStringList() << "get-default-sink");
-  process.waitForFinished();
-  QString output = process.readAllStandardOutput().trimmed();
-  LOG_DEBUG("Default sink: " << output);
-  return output.contains(connectedDeviceMacAddress);
+  QString defaultSink = m_pulseAudio->getDefaultSink();
+  LOG_DEBUG("Default sink: " << defaultSink);
+  return defaultSink.contains(connectedDeviceMacAddress);
 }
 
 void MediaController::handleConversationalAwareness(const QByteArray &data) {
@@ -102,32 +106,29 @@ void MediaController::handleConversationalAwareness(const QByteArray &data) {
 
   if (lowered) {
     if (initialVolume == -1 && isActiveOutputDeviceAirPods()) {
-      QProcess process;
-      process.start("pactl", QStringList()
-                                 << "get-sink-volume" << "@DEFAULT_SINK@");
-      process.waitForFinished();
-      QString output = process.readAllStandardOutput();
-      QRegularExpression re("front-left: \\d+ /\\s*(\\d+)%");
-      QRegularExpressionMatch match = re.match(output);
-      if (match.hasMatch()) {
-        LOG_DEBUG("Matched: " << match.captured(1));
-        initialVolume = match.captured(1).toInt();
-      } else {
-        LOG_ERROR("Failed to parse initial volume from output: " << output);
+      QString defaultSink = m_pulseAudio->getDefaultSink();
+      initialVolume = m_pulseAudio->getSinkVolume(defaultSink);
+      if (initialVolume == -1) {
+        LOG_ERROR("Failed to get initial volume");
         return;
       }
+      LOG_DEBUG("Initial volume: " << initialVolume << "%");
+    }
+    QString defaultSink = m_pulseAudio->getDefaultSink();
+    int targetVolume = initialVolume * 0.20;
+    if (m_pulseAudio->setSinkVolume(defaultSink, targetVolume)) {
+      LOG_INFO("Volume lowered to 0.20 of initial which is " << targetVolume << "%");
+    } else {
+      LOG_ERROR("Failed to lower volume");
     }
-    QProcess::execute(
-        "pactl", QStringList() << "set-sink-volume" << "@DEFAULT_SINK@"
-                               << QString::number(initialVolume * 0.20) + "%");
-    LOG_INFO("Volume lowered to 0.20 of initial which is "
-             << initialVolume * 0.20 << "%");
   } else {
     if (initialVolume != -1 && isActiveOutputDeviceAirPods()) {
-      QProcess::execute("pactl", QStringList()
-                                     << "set-sink-volume" << "@DEFAULT_SINK@"
-                                     << QString::number(initialVolume) + "%");
-      LOG_INFO("Volume restored to " << initialVolume << "%");
+      QString defaultSink = m_pulseAudio->getDefaultSink();
+      if (m_pulseAudio->setSinkVolume(defaultSink, initialVolume)) {
+        LOG_INFO("Volume restored to " << initialVolume << "%");
+      } else {
+        LOG_ERROR("Failed to restore volume");
+      }
       initialVolume = -1;
     }
   }
@@ -138,38 +139,44 @@ bool MediaController::isA2dpProfileAvailable() {
     return false;
   }
 
-  QProcess process;
-  process.start("pactl", QStringList() << "list" << "cards");
-  if (!process.waitForFinished(3000)) {
-    LOG_ERROR("pactl command timed out while checking A2DP availability");
-    return false;
-  }
+  return m_pulseAudio->isProfileAvailable(m_deviceOutputName, "a2dp-sink-sbc_xq") || 
+         m_pulseAudio->isProfileAvailable(m_deviceOutputName, "a2dp-sink-sbc") ||
+         m_pulseAudio->isProfileAvailable(m_deviceOutputName, "a2dp-sink");
+}
 
-  QString output = process.readAllStandardOutput();
+QString MediaController::getPreferredA2dpProfile() {
+  if (m_deviceOutputName.isEmpty()) {
+    return QString();
+  }
 
-  // Check if the card section contains our device
-  int cardStart = output.indexOf(m_deviceOutputName);
-  if (cardStart == -1) {
-    return false;
+  if (!m_cachedA2dpProfile.isEmpty() && 
+      m_pulseAudio->isProfileAvailable(m_deviceOutputName, m_cachedA2dpProfile)) {
+    return m_cachedA2dpProfile;
   }
 
-  // Look for a2dp-sink profile in the card's section
-  int nextCard = output.indexOf("Name: ", cardStart + m_deviceOutputName.length());
-  QString cardSection = (nextCard == -1) ? output.mid(cardStart) : output.mid(cardStart, nextCard - cardStart);
+  QStringList profiles = {"a2dp-sink-sbc_xq", "a2dp-sink-sbc", "a2dp-sink"};
 
-  return cardSection.contains("a2dp-sink");
+  for (const QString &profile : profiles) {
+    if (m_pulseAudio->isProfileAvailable(m_deviceOutputName, profile)) {
+      LOG_INFO("Selected best available A2DP profile: " << profile);
+      m_cachedA2dpProfile = profile;
+      return profile;
+    }
+  }
+
+  m_cachedA2dpProfile.clear();
+  return QString();
 }
 
 bool MediaController::restartWirePlumber() {
   LOG_INFO("Restarting WirePlumber to rediscover A2DP profiles");
   int result = QProcess::execute("systemctl", QStringList() << "--user" << "restart" << "wireplumber");
   if (result == 0) {
     LOG_INFO("WirePlumber restarted successfully");
-    // Wait a bit for WirePlumber to rediscover profiles
-    QProcess::execute("sleep", QStringList() << "2");
+    QThread::sleep(2);
     return true;
   } else {
-    LOG_ERROR("Failed to restart WirePlumber");
+    LOG_ERROR("Failed to restart WirePlumber. Do you use wireplumber?");
     return false;
   }
 }
@@ -180,11 +187,9 @@ void MediaController::activateA2dpProfile() {
     return;
   }
 
-  // Check if A2DP profile is available
   if (!isA2dpProfileAvailable()) {
     LOG_WARN("A2DP profile not available, attempting to restart WirePlumber");
     if (restartWirePlumber()) {
-      // Update device output name after restart
       m_deviceOutputName = getAudioDeviceName();
       if (!isA2dpProfileAvailable()) {
         LOG_ERROR("A2DP profile still not available after WirePlumber restart");
@@ -196,13 +201,15 @@ void MediaController::activateA2dpProfile() {
     }
   }
 
-  LOG_INFO("Activating A2DP profile for AirPods");
-  int result = QProcess::execute(
-      "pactl", QStringList()
-                   << "set-card-profile"
-                   << m_deviceOutputName << "a2dp-sink");
-  if (result != 0) {
-    LOG_ERROR("Failed to activate A2DP profile");
+  QString preferredProfile = getPreferredA2dpProfile();
+  if (preferredProfile.isEmpty()) {
+    LOG_ERROR("No suitable A2DP profile found");
+    return;
+  }
+
+  LOG_INFO("Activating A2DP profile for AirPods: " << preferredProfile);
+  if (!m_pulseAudio->setCardProfile(m_deviceOutputName, preferredProfile)) {
+    LOG_ERROR("Failed to activate A2DP profile: " << preferredProfile);
   }
 }
 
@@ -213,18 +220,15 @@ void MediaController::removeAudioOutputDevice() {
   }
 
   LOG_INFO("Removing AirPods as audio output device");
-  int result = QProcess::execute(
-      "pactl", QStringList()
-                   << "set-card-profile"
-                   << m_deviceOutputName << "off");
-  if (result != 0) {
+  if (!m_pulseAudio->setCardProfile(m_deviceOutputName, "off")) {
     LOG_ERROR("Failed to remove AirPods as audio output device");
   }
 }
 
 void MediaController::setConnectedDeviceMacAddress(const QString &macAddress) {
   connectedDeviceMacAddress = macAddress;
   m_deviceOutputName = getAudioDeviceName();
+  m_cachedA2dpProfile.clear();
   LOG_INFO("Device output name set to: " << m_deviceOutputName);
 }
 
@@ -345,40 +349,9 @@ QString MediaController::getAudioDeviceName()
 {
   if (connectedDeviceMacAddress.isEmpty()) { return QString(); }
 
-  // Set up QProcess to run pactl directly
-  QProcess process;
-  process.start("pactl", QStringList() << "list" << "cards" << "short");
-  if (!process.waitForFinished(3000)) // Timeout after 3 seconds
-  {
-    LOG_ERROR("pactl command failed or timed out: " << process.errorString());
-    return QString();
-  }
-
-  // Check for execution errors
-  if (process.exitCode() != 0)
-  {
-    LOG_ERROR("pactl exited with error code: " << process.exitCode());
-    return QString();
-  }
-
-  // Read and parse the command output
-  QString output = process.readAllStandardOutput();
-  QStringList lines = output.split("\n", Qt::SkipEmptyParts);
-
-  // Iterate through each line to find a matching Bluetooth sink
-  for (const QString &line : lines)
-  {
-    QStringList fields = line.split("\t", Qt::SkipEmptyParts);
-    if (fields.size() < 2) { continue; }
-
-    QString sinkName = fields[1].trimmed();
-    if (sinkName.startsWith("bluez") && sinkName.contains(connectedDeviceMacAddress))
-    {
-      return sinkName;
-    }
+  QString cardName = m_pulseAudio->getCardNameForDevice(connectedDeviceMacAddress);
+  if (cardName.isEmpty()) {
+    LOG_ERROR("No matching Bluetooth card found for MAC address: " << connectedDeviceMacAddress);
   }
-
-  // No matching sink found
-  LOG_ERROR("No matching Bluetooth sink found for MAC address: " << connectedDeviceMacAddress);
-  return QString();
+  return cardName;
 }

linux/media/mediacontroller.h

@@ -2,6 +2,7 @@
 #define MEDIACONTROLLER_H
 
 #include <QObject>
+#include "pulseaudiocontroller.h"
 
 class QProcess;
 class EarDetection;
@@ -38,6 +39,7 @@ class MediaController : public QObject
   void removeAudioOutputDevice();
   void setConnectedDeviceMacAddress(const QString &macAddress);
   bool isA2dpProfileAvailable();
+  QString getBestA2dpProfile();
   bool restartWirePlumber();
 
   void setEarDetectionBehavior(EarDetectionBehavior behavior);
@@ -61,6 +63,8 @@ class MediaController : public QObject
   EarDetectionBehavior earDetectionBehavior = PauseWhenOneRemoved;
   QString m_deviceOutputName;
   PlayerStatusWatcher *playerStatusWatcher = nullptr;
+  PulseAudioController *m_pulseAudio = nullptr;
+  QString m_cachedA2dpProfile;
 };
 
 #endif // MEDIACONTROLLER_H