Skip to content

Commit cc7aac3

Browse files
committed
DROPME: bump TRACE_PAYLOAD_LEN
Gobally increase TRACE_PAYLOAD_LEN to include overlay headers to be decoded by Hubble. This is a temporary hack, and datapath should dynamically increase TRACE_PAYLOAD_LEN based on configuration / trace points. Signed-off-by: Alexandre Perrin <alex@isovalent.com>
1 parent 79b206e commit cc7aac3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

bpf/lib/common.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,8 @@ enum {
543543
};
544544

545545
#ifndef TRACE_PAYLOAD_LEN
546-
#define TRACE_PAYLOAD_LEN 128ULL
546+
/* Ethernet 16 + IPv6 40 + UDP 8 + VXLAN 8 (Geneve up to 260) [ Ethernet 16 + IPv6 40 + TCP 20 ] = 148 */
547+
#define TRACE_PAYLOAD_LEN 148ULL
547548
#endif
548549

549550
#ifndef BPF_F_PSEUDO_HDR

daemon/cmd/daemon_main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -723,7 +723,7 @@ func InitGlobalFlags(cmd *cobra.Command, vp *viper.Viper) {
723723
flags.String(option.ServiceNoBackendResponse, defaults.ServiceNoBackendResponse, "Response to traffic for a service without backends")
724724
option.BindEnv(vp, option.ServiceNoBackendResponse)
725725

726-
flags.Int(option.TracePayloadlen, 128, "Length of payload to capture when tracing")
726+
flags.Int(option.TracePayloadlen, 148, "Length of payload to capture when tracing")
727727
option.BindEnv(vp, option.TracePayloadlen)
728728

729729
flags.Bool(option.Version, false, "Print version information")

0 commit comments

Comments
 (0)