chore: fix compile-time warning of Elixir 1.18

Author: Krapaince

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## [Unreleased]
 
+## [0.2.2] (2025-11-05)
+
+### Fixed
+
+- Warnings emitted by Elixir 1.18/OTP 27
+
 ## [0.2.1] (2024-03-12)
 
 ### Fixed

lib/dkim.ex

@@ -11,7 +11,7 @@ defmodule DKIM do
       nil -> :none
       sig ->
         if (sig.bh == body_hash(body,sig)) do
-          case :inet_res.lookup('#{sig.s}._domainkey.#{sig.d}', :in, :txt, edns: 0) do
+          case :inet_res.lookup(~c"#{sig.s}._domainkey.#{sig.d}", :in, :txt, edns: 0) do
             [rec|_] ->
               pubkey = MimeMail.Params.parse_header(IO.chardata_to_string(rec))
               if :"#{pubkey[:k]||"rsa"}" == sig.a.sig do

lib/dmarc.ex

@@ -11,7 +11,7 @@ defmodule DMARC do
 
   :ssl.start ; :inets.start
   url = "https://publicsuffix.org/list/effective_tld_names.dat"
-  case :httpc.request(:get,{'#{url}',[]},[], body_format: :binary) do
+  case :httpc.request(:get,{~c"#{url}",[]},[], body_format: :binary) do
     {:ok,{{_,200,_},_,r}} ->
       Logger.debug("Download suffix from #{url}")
       r

lib/mime_types.ex

@@ -1,6 +1,6 @@
 defmodule MimeTypes do
   :ssl.start ; :inets.start
-  {ext2mime,mime2ext} = case :httpc.request('https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types') do
+  {ext2mime,mime2ext} = case :httpc.request(~c"https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types") do
     {:ok,{{_,200,_},_,r}} -> "#{r}"
     _ -> File.read!("#{:code.priv_dir(:mailibex)}/mime.types")
   end
@@ -55,11 +55,11 @@ defmodule MimeTypes do
     {:ok,files} = :zip.zip_list_dir(ziph)
     files = for {:zip_file,name,_,_,_,_}<-files, do: name
     res = cond do
-      Enum.all?(['[Content_Types].xml','word/styles.xml'],&(&1 in files))-> ".docx"
-      Enum.all?(['[Content_Types].xml','xl/styles.xml'],&(&1 in files))-> ".xlsx"
-      Enum.all?(['[Content_Types].xml','ppt/presProps.xml'],&(&1 in files))-> ".pptx"
-      Enum.all?(['content.xml','styles.xml','META-INF/manifest.xml'],&(&1 in files))->
-        {:ok,{_,manifest}}=:zip.zip_get('META-INF/manifest.xml',ziph) 
+      Enum.all?([~c"[Content_Types].xml",~c"word/styles.xml"],&(&1 in files))-> ".docx"
+      Enum.all?([~c"[Content_Types].xml",~c"xl/styles.xml"],&(&1 in files))-> ".xlsx"
+      Enum.all?([~c"[Content_Types].xml",~c"ppt/presProps.xml"],&(&1 in files))-> ".pptx"
+      Enum.all?([~c"content.xml",~c"styles.xml",~c"META-INF/manifest.xml"],&(&1 in files))->
+        {:ok,{_,manifest}}=:zip.zip_get(~c"META-INF/manifest.xml",ziph) 
         case Regex.run(~r/media-type="([^"]*)"/,manifest) do #"
           [_,"application/vnd.oasis.opendocument.text"]->".odt"
           [_,"application/vnd.oasis.opendocument.presentation"]->".odp"
@@ -71,7 +71,7 @@ defmodule MimeTypes do
           [_,"application/vnd.oasis.opendocument.base"]->".odb"
           [_,"application/vnd.oasis.opendocument.database"]->".odb"
         end
-      'META-INF/MANIFEST.MF' in files->".jar"
+      ~c"META-INF/MANIFEST.MF" in files->".jar"
       true -> ".zip"
     end
     :zip.zip_close(ziph)
@@ -164,7 +164,7 @@ defmodule EBML do
     :calendar.now_to_datetime {div(ts,1_000_000),rem(ts,1_000_000),0}
   end
 
-  ebml_spec = case :httpc.request('https://raw.githubusercontent.com/Matroska-Org/foundation-source/master/spectool/specdata.xml') do
+  ebml_spec = case :httpc.request(~c"https://raw.githubusercontent.com/Matroska-Org/foundation-source/master/spectool/specdata.xml") do
     {:ok,{{_,200,_},_,r}} -> "#{r}"
     _ -> File.read!("#{:code.priv_dir(:mailibex)}/ebml.xml")
   end 

lib/mimemail.ex

@@ -53,7 +53,7 @@ defmodule MimeMail do
         escaped_bound = Regex.escape(bound)
         body 
           |> String.split(~r"\s*--#{escaped_bound}\s*") 
-          |> Enum.slice(1..-2) 
+          |> Enum.slice(1..-2//-1) 
           |> Enum.map(&from_string/1) 
           |> Enum.map(&decode_body/1)
       {"text/"<>_,%{charset: charset}} ->
@@ -70,13 +70,13 @@ defmodule MimeMail do
     case mail.headers[:'content-type'] do
       {"text/"<>_=type,params}-> 
         headers = Keyword.drop(mail.headers,[:'content-type',:'content-transfer-encoding']) ++[
-          'content-type': {type,Map.put(params,:charset,"utf-8")},
-          'content-transfer-encoding': "quoted-printable"
+          {:"content-type", {type,Map.put(params,:charset,"utf-8")}},
+          {:"content-transfer-encoding", "quoted-printable"}
         ]
         %{mail|headers: headers, body: {:raw,string_to_qp(body)}}
       _->
         headers = Keyword.delete(mail.headers,:'content-transfer-encoding')
-                 ++['content-transfer-encoding': "base64"]
+                 ++[{:"content-transfer-encoding", "base64"}]
         %{mail|headers: headers, body: {:raw,(body |> Base.encode64 |> chunk64 |> Enum.join("\r\n"))}}
     end
   end
@@ -86,7 +86,7 @@ defmodule MimeMail do
     full_boundary = "--#{boundary}"
     {"multipart/"<>_=type,params} = mail.headers[:'content-type']
     headers = Keyword.delete(mail.headers,:'content-type')
-              ++['content-type': {type,Map.put(params,:boundary,boundary)}]
+              ++[{:"content-type", {type,Map.put(params,:boundary,boundary)}}]
     body = childs |> Enum.map(&MimeMail.to_string/1) |> Enum.join("\r\n\r\n"<>full_boundary<>"\r\n")
     %{mail|body: {:raw,"#{full_boundary}\r\n#{body}\r\n\r\n#{full_boundary}--\r\n"}, headers: headers}
   end
@@ -96,7 +96,7 @@ defmodule MimeMail do
 
   def string_to_qp(str) do
     str |> String.split("\r\n") |> Enum.map(fn line->
-      {eol,line} = '#{line}' |> Enum.reverse |> Enum.split_while(&(&1==?\t or &1==?\s))
+      {eol,line} = ~c"#{line}" |> Enum.reverse |> Enum.split_while(&(&1==?\t or &1==?\s))
       Enum.concat(Enum.map(eol,&char_to_qp/1),Enum.map(line,fn
         c when c == ?\t or (c < 127 and c > 31 and c !== ?=) -> c
         c -> char_to_qp(c)
@@ -172,7 +172,7 @@ end
 defmodule Iconv do
   @on_load :init
   def init do
-    ret = :erlang.load_nif('#{:code.priv_dir(:mailibex)}/Elixir.Iconv_nif',0)
+    ret = :erlang.load_nif(~c"#{:code.priv_dir(:mailibex)}/Elixir.Iconv_nif",0)
     case ret do
       {:error, {:load_failed, _} }->
         if Code.ensure_loaded?(Codepagex), do: :ok, else: {:error, "Codepagex is not available. Cannot fallback."}

lib/mimemail_flat.ex

@@ -82,53 +82,53 @@ defmodule MimeMail.Flat do
 
   defp mail_htmlcontent(nil,_), do: nil
   defp mail_htmlcontent(body,[]), do:
-    %MimeMail{headers: ['content-type': {"text/html",%{}}], body: body}
+    %MimeMail{headers: [{:"content-type", {"text/html",%{}}}], body: body}
   defp mail_htmlcontent(body,included), do:
     %MimeMail{
-      headers: ['content-type': {"multipart/related",%{}}],
+      headers: [{:"content-type", {"multipart/related",%{}}}],
       body: [mail_htmlcontent(body,[]) | for {id,contenttype,binary}<-included do
         %MimeMail{
-          headers: ['content-type': {contenttype,%{name: id}},
-                    'content-disposition': {"inline",%{filename: id}},
-                    'content-id': "<#{id}>"],
+          headers: [{:"content-type", {contenttype,%{name: id}}},
+                    {:"content-disposition", {"inline",%{filename: id}}},
+                    {:"content-id", "<#{id}>"}],
           body: binary
         }
       end]
     }
 
   defp mail_plaincontent(nil), do: nil
   defp mail_plaincontent(body), do:
-    %MimeMail{headers: ['content-type': {"text/plain",%{}}], body: body}
+    %MimeMail{headers: [{:"content-type", {"text/plain",%{}}}], body: body}
 
   defp mail_icalcontent(nil), do: nil
   defp mail_icalcontent(body) when is_binary(body), do: mail_icalcontent({:request,body})
   defp mail_icalcontent({method,body}), do: 
-    %MimeMail{headers: ['content-type': {"text/calendar",%{method: String.upcase("#{method}")}}], body: body}
+    %MimeMail{headers: [{:"content-type", {"text/calendar",%{method: String.upcase("#{method}")}}}], body: body}
 
   defp mail_content([]), do: mail_plaincontent(" ")
   defp mail_content([singlecontent]), do: singlecontent
   defp mail_content([_|_]=contents), do:
     %MimeMail{
-      headers: ['content-type': {"multipart/alternative",%{}}], 
+      headers: [{:"content-type", {"multipart/alternative",%{}}}], 
       body: contents 
     }
 
   defp mail_final(content,[],[]), do: content
   defp mail_final(content,attached,attached_in), do:
     %MimeMail{
-      headers: ['content-type': {"multipart/mixed",%{}}], 
+      headers: [{:"content-type", {"multipart/mixed",%{}}}], 
       body: [content | 
         for {name,contenttype,binary}<-attached do
           %MimeMail{
-            headers: ['content-type': {contenttype,%{name: name}},
-                      'content-disposition': {"attachment",%{filename: name}}], 
+            headers: [{:"content-type", {contenttype,%{name: name}}},
+                      {:"content-disposition", {"attachment",%{filename: name}}}], 
             body: binary
           }
         end ++
         for {name,contenttype,binary}<-attached_in do
           %MimeMail{
-            headers: ['content-type': {contenttype,%{name: name}},
-                      'content-disposition': {"inline",%{filename: name}}],
+            headers: [{:"content-type", {contenttype,%{name: name}}},
+                      {:"content-disposition", {"inline",%{filename: name}}}],
             body: binary
           }
         end

lib/spf.ex

@@ -33,7 +33,7 @@ defmodule SPF do
   # check_host returns : none, :neutral,:pass,{:fail,msg},:softfail,:temperror,:permerror
   defp check_host(params) do
     if lookup_limit_exceeded() do :permerror else
-      case :inet_res.lookup('#{params.domain}', :in, :txt, edns: 0) do
+      case :inet_res.lookup(~c"#{params.domain}", :in, :txt, edns: 0) do
         [] -> :temperror
         recs ->
           rules=recs|>Enum.map(&Enum.join/1)|>Enum.filter(&match?("v=sp"<>_,&1))
@@ -52,7 +52,7 @@ defmodule SPF do
       {modifiers,mechanisms} = Enum.split_with(terms,&Regex.match?(~r/^[^:\/]+=/,&1))
       modifiers = Enum.map modifiers, fn modifier->
         [name,value]=String.split(modifier,"=")
-        {:"#{name}",target_name(value,params) || ""}
+        {:"#{name}",target_name(value,params)}
       end
       matches = Enum.map mechanisms, fn term->
         fn->
@@ -78,7 +78,7 @@ defmodule SPF do
         {:fail,expdomain}->
           try do
             false = lookup_limit_exceeded()
-            [rec] = :inet_res.lookup('#{expdomain}', :in, :txt, edns: 0)
+            [rec] = :inet_res.lookup(~c"#{expdomain}", :in, :txt, edns: 0)
             {:fail,rec|>IO.chardata_to_string|>target_name(params)}
           catch _, _ -> {:fail,defaultfail}
           end
@@ -113,7 +113,7 @@ defmodule SPF do
     family = if tuple_size(params.client_ip) == 4, do: :inet, else: :inet6
     {domain,prefix}=extract_prefix(target_name(domain_spec,params),family)
     false = lookup_limit_exceeded()
-    case :inet_res.gethostbyname('#{domain}',family) do
+    case :inet_res.gethostbyname(~c"#{domain}",family) do
       {:ok,{:hostent,_,_,_,_,ip_list}}->
         if Enum.any?(ip_list,&ip_in_network(params.client_ip,&1,prefix)), do: :match, else: :notmatch
       _->:notmatch
@@ -124,7 +124,7 @@ defmodule SPF do
     family = if tuple_size(params.client_ip) == 4, do: :inet, else: :inet6
     {domain,prefix}=extract_prefix(target_name(domain_spec,params),family)
     false = lookup_limit_exceeded()
-    case :inet_res.lookup('#{domain}', :in, :mx, edns: 0) do
+    case :inet_res.lookup(~c"#{domain}", :in, :mx, edns: 0) do
       []->:notmatch
       res->
         Enum.find_value(res,fn {_prio,name}->
@@ -158,7 +158,7 @@ defmodule SPF do
     family = if tuple_size(params.client_ip) == 4, do: :inet, else: :inet6
     if (family==:inet and v !== ?4) or (family==:inet6 and v !== ?6) do :notmatch else
       {addr_spec,prefix}=extract_prefix(target_name(addr_spec,params),family)
-      case :inet.parse_address('#{addr_spec}') do
+      case :inet.parse_address(~c"#{addr_spec}") do
         {:ok,addr} when (tuple_size(addr)==4 and family==:inet) or
                         (tuple_size(addr)==8 and family==:inet6)->
           if ip_in_network(params.client_ip,addr,prefix), do: :match, else: :notmatch
@@ -167,7 +167,7 @@ defmodule SPF do
   end
   def term_match("exists:"<>domain_spec,params) do
     false = lookup_limit_exceeded()
-    case :inet_res.gethostbyname('#{target_name(domain_spec,params)}',:inet) do
+    case :inet_res.gethostbyname(~c"#{target_name(domain_spec,params)}",:inet) do
       {:ok,{:hostent,_,_,_,_,ip_list}} when ip_list != [] -> :match
       _->:notmatch
     end

mix.exs

@@ -22,12 +22,12 @@ defmodule Mix.Tasks.Compile.Iconv do
     lib_file = "priv/Elixir.Iconv_nif.#{lib_ext}"
     if not File.exists?(lib_file) do
       [i_erts]=Path.wildcard("#{:code.root_dir}/erts*/include")
-      i_ei=:code.lib_dir(:erl_interface,:include)
-      l_ei=:code.lib_dir(:erl_interface,:lib)
+      i_ei= Path.join(:code.lib_dir(:erl_interface), "include")
+      l_ei=Path.join(:code.lib_dir(:erl_interface), "lib")
       args = "-L\"#{l_ei}\" -lei -I\"#{i_ei}\" -I\"#{i_erts}\" -Wall -shared -fPIC"
       args = args <> if {:unix, :darwin}==:os.type, do: " -undefined dynamic_lookup -dynamiclib", else: ""
       args = args <> if {:win32, :nt}==:os.type, do: " -liconv", else: ""
-      Mix.shell.info to_string :os.cmd('gcc #{args} -v -o #{lib_file} c_src/iconv_nif.c')
+      Mix.shell.info to_string :os.cmd(~c"gcc #{args} -v -o #{lib_file} c_src/iconv_nif.c")
     end
     :ok
   end
@@ -38,7 +38,7 @@ defmodule Mailibex.Mixfile do
 
   def app, do: :mailibex
 
-  def version, do: "0.2.1"
+  def version, do: "0.2.2"
 
   def source_url, do: "https://github.com/kbrw/#{app()}"
 

test/dkim_test.exs

@@ -2,18 +2,18 @@ defmodule DKIMTest do
   use ExUnit.Case
 
   setup_all do
-    :code.unstick_dir(:code.lib_dir(:kernel)++'/ebin')
+    :code.unstick_dir(:code.lib_dir(:kernel)++~c"/ebin")
     previous_compiler_options = Code.compiler_options(ignore_module_conflict: true)
     defmodule :inet_res do #mock external dns calls to hard define DKIM pub key when mock mails were constructed
       def lookup(dns,type,class,_opts), do: lookup(dns,type,class)
-      def lookup('20120113._domainkey.gmail.com',:in,:txt) do
-        [['k=rsa; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1Kd87/UeJjenpabgbFwh+eBCsSTrqmwIYYvywlbhbqoo2DymndFkbjOVIPIldNs/m40KF+yzMn1skyoxcTUGCQs8g3FgD2Ap3ZB5DekAo5wMmk4wimDO+U8QzI3SD0', '7y2+07wlNWwIt8svnxgdxGkVbbhzY8i+RQ9DpSVpPbF7ykQxtKXkv/ahW3KjViiAH+ghvvIhkx4xYSIc9oSwVmAl5OctMEeWUwg8Istjqz8BZeTWbf41fbNhte7Y+YqZOwq1Sd0DbvYAD9NOZK9vlfuac0598HY+vtSBczUiKERHv1yRbcaQtZFh5wtiRrN04BLUTD21MycBX5jYchHjPY/wIDAQAB']]
+      def lookup(~c"20120113._domainkey.gmail.com",:in,:txt) do
+        [[~c"k=rsa; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA1Kd87/UeJjenpabgbFwh+eBCsSTrqmwIYYvywlbhbqoo2DymndFkbjOVIPIldNs/m40KF+yzMn1skyoxcTUGCQs8g3FgD2Ap3ZB5DekAo5wMmk4wimDO+U8QzI3SD0", ~c"7y2+07wlNWwIt8svnxgdxGkVbbhzY8i+RQ9DpSVpPbF7ykQxtKXkv/ahW3KjViiAH+ghvvIhkx4xYSIc9oSwVmAl5OctMEeWUwg8Istjqz8BZeTWbf41fbNhte7Y+YqZOwq1Sd0DbvYAD9NOZK9vlfuac0598HY+vtSBczUiKERHv1yRbcaQtZFh5wtiRrN04BLUTD21MycBX5jYchHjPY/wIDAQAB"]]
       end
-      def lookup('cobrason._domainkey.order.brendy.fr',:in,:txt) do
-        [['k=rsa; t=y; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAofRImu739BK3m4Qj6uxZr/IBb2Jk5xuxY17pBgRp1ANAPFqJBg1mgUiwooT5n6/EjSA3dvt8MarlGNl+fOOOY02IWttkXW0fXWxW324iNaNE1aSyhHaP7dTmcSE3BnVjOVUGbZ5voLxjULq5+Ml1sy5Xt17cW38I0gja4ZtC0HQ9aUv4+eWZwxv4WIWpPUVH', 'qEFEptOHc1v1YbKO8lo9JFlO1wVvnQjEpWbg5ORGxaBnr92I0bZ2Hm5gU4WHOUiPKKk7J94wpO1KV++SGLaCeHDV8cW9e3RgGJs2IQzpjMDTyGEyHTo5WrgN3d9AOljyb2GOCnFEZ3lqI/+4XXbyHQIDAQAB']]
+      def lookup(~c"cobrason._domainkey.order.brendy.fr",:in,:txt) do
+        [[~c"k=rsa; t=y; p=MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAofRImu739BK3m4Qj6uxZr/IBb2Jk5xuxY17pBgRp1ANAPFqJBg1mgUiwooT5n6/EjSA3dvt8MarlGNl+fOOOY02IWttkXW0fXWxW324iNaNE1aSyhHaP7dTmcSE3BnVjOVUGbZ5voLxjULq5+Ml1sy5Xt17cW38I0gja4ZtC0HQ9aUv4+eWZwxv4WIWpPUVH", ~c"qEFEptOHc1v1YbKO8lo9JFlO1wVvnQjEpWbg5ORGxaBnr92I0bZ2Hm5gU4WHOUiPKKk7J94wpO1KV++SGLaCeHDV8cW9e3RgGJs2IQzpjMDTyGEyHTo5WrgN3d9AOljyb2GOCnFEZ3lqI/+4XXbyHQIDAQAB"]]
       end
-      def lookup('amazon201209._domainkey.amazon.fr',:in,:txt) do
-        [['p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDAjRD+MR0FAGIKMgpN6eK/z7Z+ojWuvb3a79qsLS3IU/hdifXxhoi9+ttd4eUBZKfwtSGVg8uOxGFJpPnp4MvZUgb8L6ZCkB/Big6l9JGPNHXCUo4e3RIQJzgWOuqPpO8pS+8HOJiH+fjxGwTZipiK353MlTudq9b6z8Gn8HCXkQIDAQAB;']]
+      def lookup(~c"amazon201209._domainkey.amazon.fr",:in,:txt) do
+        [[~c"p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDAjRD+MR0FAGIKMgpN6eK/z7Z+ojWuvb3a79qsLS3IU/hdifXxhoi9+ttd4eUBZKfwtSGVg8uOxGFJpPnp4MvZUgb8L6ZCkB/Big6l9JGPNHXCUo4e3RIQJzgWOuqPpO8pS+8HOJiH+fjxGwTZipiK353MlTudq9b6z8Gn8HCXkQIDAQAB;"]]
       end
       def lookup(_,_,_), do: []
     end

test/mime_test.exs

@@ -14,7 +14,7 @@ defmodule MimeMailTest do
     Enum.each String.split(res,"\r\n"), fn line->
       assert !Regex.match? ~r/\s+$/, line
       assert String.length(line) < 77
-      assert [] = Enum.filter('#{line}',&(&1 < 32 or &1 > 127))
+      assert [] = Enum.filter(~c"#{line}",&(&1 < 32 or &1 > 127))
     end
   end
   test "round trip quoted-printable" do