Skip to content

Commit 1a87ddf

Browse files
marioevzspencer-tb
andauthored
fix(types,tests): EIP-7685 fixes for devnet-5 (ethereum#990)
* fix(forks): Update EIP-7002, EIP-7251 contracts * fix(types): Remove empty requests from list * fix(tests): Remove empty requests from lists in all tests * chore: tox black fix. --------- Co-authored-by: spencer-tb <[email protected]>
1 parent 10bf57e commit 1a87ddf

File tree

8 files changed

+14
-54
lines changed

8 files changed

+14
-54
lines changed

prague/eip6110_deposits/conftest.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,12 +75,10 @@ def blocks(
7575
header_verify=Header(
7676
requests_hash=Requests(
7777
*included_requests,
78-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
7978
),
8079
),
8180
requests=Requests(
8281
*block_body_override_requests,
83-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
8482
).requests_list
8583
if block_body_override_requests is not None
8684
else None,

prague/eip7002_el_triggerable_withdrawals/conftest.py

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -95,16 +95,14 @@ def blocks(
9595
included_requests,
9696
fillvalue=[],
9797
):
98-
max_request_type = fork.max_request_type(
98+
header_verify: Header | None = None
99+
if fork.header_requests_required(
99100
block_number=len(blocks) + 1,
100101
timestamp=timestamp,
101-
)
102-
header_verify: Header | None = None
103-
if max_request_type > -1:
102+
):
104103
header_verify = Header(
105104
requests_hash=Requests(
106105
*block_included_requests,
107-
max_request_type=max_request_type,
108106
)
109107
)
110108
else:
@@ -120,14 +118,7 @@ def blocks(
120118

121119
return blocks + [
122120
Block(
123-
header_verify=Header(
124-
requests_hash=Requests(
125-
max_request_type=fork.max_request_type(
126-
block_number=len(blocks) + 1,
127-
timestamp=timestamp,
128-
)
129-
)
130-
),
121+
header_verify=Header(requests_hash=Requests()),
131122
timestamp=timestamp,
132123
)
133124
] # Add an empty block at the end to verify that no more withdrawal requests are included

prague/eip7002_el_triggerable_withdrawals/test_withdrawal_requests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -711,13 +711,11 @@ def test_withdrawal_requests_negative(
711711
header_verify=Header(
712712
requests_hash=Requests(
713713
*included_requests,
714-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
715714
),
716715
),
717716
requests=(
718717
Requests(
719718
*block_body_override_requests,
720-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
721719
).requests_list
722720
if block_body_override_requests is not None
723721
else None

prague/eip7251_consolidations/conftest.py

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -96,18 +96,12 @@ def blocks(
9696
included_requests,
9797
fillvalue=[],
9898
):
99-
max_request_type = fork.max_request_type(
99+
header_verify: Header | None = None
100+
if fork.header_requests_required(
100101
block_number=len(blocks) + 1,
101102
timestamp=timestamp,
102-
)
103-
header_verify: Header | None = None
104-
if max_request_type > -1:
105-
header_verify = Header(
106-
requests_hash=Requests(
107-
*block_included_requests,
108-
max_request_type=max_request_type,
109-
)
110-
)
103+
):
104+
header_verify = Header(requests_hash=Requests(*block_included_requests))
111105
else:
112106
assert not block_included_requests
113107
blocks.append(
@@ -121,14 +115,7 @@ def blocks(
121115

122116
return blocks + [
123117
Block(
124-
header_verify=Header(
125-
requests_hash=Requests(
126-
max_request_type=fork.max_request_type(
127-
block_number=len(blocks) + 1,
128-
timestamp=timestamp,
129-
)
130-
)
131-
),
118+
header_verify=Header(requests_hash=Requests()),
132119
timestamp=timestamp,
133120
)
134121
] # Add an empty block at the end to verify that no more consolidation requests are included

prague/eip7251_consolidations/test_consolidations.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -760,16 +760,10 @@ def test_consolidation_requests_negative(
760760
Block(
761761
txs=sum((r.transactions() for r in requests), []),
762762
header_verify=Header(
763-
requests_hash=Requests(
764-
*included_requests,
765-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
766-
),
763+
requests_hash=Requests(*included_requests),
767764
),
768765
requests=(
769-
Requests(
770-
*block_body_override_requests,
771-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
772-
).requests_list
766+
Requests(*block_body_override_requests).requests_list
773767
if block_body_override_requests is not None
774768
else None
775769
),

prague/eip7685_general_purpose_el_requests/conftest.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,7 @@ def blocks(
8080
elif isinstance(r, ConsolidationRequestInteractionBase):
8181
valid_requests_list += r.valid_requests(consolidation_request_fee)
8282

83-
valid_requests = Requests(
84-
*valid_requests_list,
85-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
86-
)
83+
valid_requests = Requests(*valid_requests_list)
8784

8885
if block_body_override_requests is None and block_body_extra_requests is not None:
8986
block_body_override_requests = valid_requests.requests_list + block_body_extra_requests
@@ -96,9 +93,7 @@ def blocks(
9693
return [
9794
Block(
9895
txs=sum((r.transactions() for r in requests), []),
99-
header_verify=Header(
100-
requests_hash=valid_requests,
101-
),
96+
header_verify=Header(requests_hash=valid_requests),
10297
requests=block_body_override_requests,
10398
exception=exception,
10499
rlp_modifier=rlp_modifier,

prague/eip7685_general_purpose_el_requests/test_deposits_withdrawals_consolidations.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ def test_valid_deposit_withdrawal_consolidation_request_from_same_tx(
314314
request.with_source_address(contract_address)
315315
for request in sorted(requests, key=lambda r: r.type)
316316
],
317-
max_request_type=fork.max_request_type(block_number=1, timestamp=1),
318317
)
319318
),
320319
)

prague/eip7702_set_code_tx/test_set_code_txs.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2884,9 +2884,7 @@ def test_set_code_to_system_contract(
28842884
blocks=[
28852885
Block(
28862886
txs=txs,
2887-
requests_hash=Requests(
2888-
max_request_type=fork.max_request_type(block_number=1)
2889-
), # Verify nothing slipped into the requests trie
2887+
requests_hash=Requests(), # Verify nothing slipped into the requests trie
28902888
)
28912889
],
28922890
post={

0 commit comments

Comments
 (0)