fix tests

On-behalf-of: @SAP [email protected]

Author: xrstf

internal/sync/object_syncer.go

@@ -129,7 +129,6 @@ func (s *objectSyncer) Sync(ctx context.Context, log *zap.SugaredLogger, source,
 
 		// The function above either created a new destination object or patched-in the missing labels,
 		// in both cases do we want to requeue.
-		s.recordEvent(ctx, source, dest, corev1.EventTypeNormal, "ObjectPlaced", "Object has been placed.")
 		return true, nil
 	}
 
@@ -361,6 +360,9 @@ func (s *objectSyncer) ensureDestinationObject(ctx context.Context, log *zap.Sug
 		}
 	}
 
+	dest.object = destObj
+	s.recordEvent(ctx, source, dest, corev1.EventTypeNormal, "ObjectPlaced", "Object has been placed.")
+
 	// remember the state of the object that we just created
 	if err := s.stateStore.Put(ctx, source.object, source.clusterName, s.subresources); err != nil {
 		return fmt.Errorf("failed to update sync state: %w", err)

test/e2e/apiexport/apiexport_test.go

@@ -114,8 +114,8 @@ func TestPermissionsClaims(t *testing.T) {
 		t.Fatalf("Failed to wait for APIExport to be updated: %v", err)
 	}
 
-	if claims := apiExport.Spec.PermissionClaims; len(claims) > 0 {
-		t.Fatalf("APIExport should have no permissions claims, but has %v", claims)
+	if claims := apiExport.Spec.PermissionClaims; len(claims) > 1 {
+		t.Fatalf("APIExport should have only events permissions claims, but has %v", claims)
 	}
 
 	// let's configure some related resources
@@ -206,7 +206,8 @@ func TestPermissionsClaims(t *testing.T) {
 			return false, err
 		}
 
-		return len(apiExport.Spec.PermissionClaims) == 3, nil
+		// 4 = events (always) + configmaps + secrets + namespaces (because of configmaps and secrets)
+		return len(apiExport.Spec.PermissionClaims) == 4, nil
 	})
 	if err != nil {
 		t.Fatalf("Failed to wait for APIExport to be updated: %v", err)
@@ -220,6 +221,13 @@ func TestPermissionsClaims(t *testing.T) {
 			},
 			All: true,
 		},
+		{
+			GroupResource: kcpapisv1alpha1.GroupResource{
+				Group:    "",
+				Resource: "events",
+			},
+			All: true,
+		},
 		{
 			GroupResource: kcpapisv1alpha1.GroupResource{
 				Group:    "",
@@ -331,6 +339,13 @@ func TestExistingPermissionsClaimsAreKept(t *testing.T) {
 			},
 			All: true,
 		},
+		{
+			GroupResource: kcpapisv1alpha1.GroupResource{
+				Group:    "",
+				Resource: "events",
+			},
+			All: true,
+		},
 		{
 			GroupResource: kcpapisv1alpha1.GroupResource{
 				Group:    "",