download kcp via Makefile, do not mark tools as PHONY

On-behalf-of: @SAP [email protected]

Author: xrstf

Makefile

@@ -91,6 +91,23 @@ $(YQ):
 	  ${YQ_VERSION} \
 	  yq_*
 
+KCP = _tools/kcp
+KCP_VERSION = 0.26.1
+
+.PHONY: $(KCP)
+$(KCP):
+	@hack/download-tool.sh \
+	  https://github.com/kcp-dev/kcp/releases/download/v${KCP_VERSION}/kcp_${KCP_VERSION}_${GOOS}_${GOARCH}.tar.gz \
+	  kcp \
+	  ${KCP_VERSION}
+
+ENVTEST = _tools/setup-envtest
+ENVTEST_VERSION = release-0.19
+
+.PHONY: $(ENVTEST)
+$(ENVTEST):
+	@GO_MODULE=true hack/download-tool.sh sigs.k8s.io/controller-runtime/tools/setup-envtest setup-envtest $(ENVTEST_VERSION)
+
 .PHONY: test
 test:
 	./hack/run-tests.sh

hack/download-tool.sh

@@ -17,7 +17,6 @@
 set -euo pipefail
 
 cd $(dirname $0)/..
-source hack/lib.sh
 
 mkdir -p _tools
 cd _tools
@@ -26,6 +25,8 @@ URL="$1"
 BINARY="$2"
 VERSION="$3"
 BINARY_PATTERN="${4:-**/$BINARY}"
+GO_MODULE=${GO_MODULE:-false}
+UNCOMPRESSED=${UNCOMPRESSED:-false}
 
 # Check if and what version we installed already.
 versionFile="$BINARY.version"
@@ -45,27 +46,31 @@ fi
   cd tmp
 
   echo "Downloading $BINARY version $VERSION …" >&2
-  curl --fail --silent -LO "$URL"
-  archive="$(ls)"
 
-  UNCOMPRESSED=${UNCOMPRESSED:-false}
+  if $GO_MODULE; then
+    GOBIN=$(realpath .) go install "$URL@$VERSION"
+    mv * "../$BINARY"
+  else
+    curl --fail --silent -LO "$URL"
+    archive="$(ls)"
 
-  if ! $UNCOMPRESSED; then
-    case "$archive" in
-      *.tar.gz | *.tgz)
-        tar xzf "$archive"
-        ;;
-      *.zip)
-        unzip "$archive"
-        ;;
-      *)
-        echo "Unknown file type: $archive" >&2
-        exit 1
-    esac
-  fi
+    if ! $UNCOMPRESSED; then
+      case "$archive" in
+        *.tar.gz | *.tgz)
+          tar xzf "$archive"
+          ;;
+        *.zip)
+          unzip "$archive"
+          ;;
+        *)
+          echo "Unknown file type: $archive" >&2
+          exit 1
+      esac
+    fi
 
-  mv $BINARY_PATTERN ../$BINARY
-  chmod +x ../$BINARY
+    mv $BINARY_PATTERN ../$BINARY
+    chmod +x ../$BINARY
+  fi
 )
 
 rm -rf tmp