Skip to content

Commit 76d7d0e

Browse files
committed
improve import sorting
On-behalf-of: @SAP [email protected]
1 parent 583e819 commit 76d7d0e

File tree

6 files changed

+19
-13
lines changed

6 files changed

+19
-13
lines changed

.gimps.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,14 @@ sets:
1919
- name: kubernetes
2020
patterns:
2121
- 'k8s.io/**'
22-
- '*.k8s.io/**'
22+
- 'sigs.k8s.io/controller-runtime/**'
23+
- 'sigs.k8s.io/controller-tools/**'
24+
- 'sigs.k8s.io/yaml/**'
2325
- 'github.com/kcp-dev/client-go/**'
2426
- 'github.com/kcp-dev/kubernetes/**'
2527
- name: kcp
2628
patterns:
2729
- 'github.com/kcp-dev/kcp/**'
30+
- 'github.com/kcp-dev/multicluster-provider/**'
31+
- 'github.com/kcp-dev/code-generator/**'
32+
- 'sigs.k8s.io/multicluster-runtime/**'

hack/tools.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,11 @@ limitations under the License.
1919
package tools
2020

2121
import (
22-
_ "github.com/kcp-dev/code-generator/v2"
2322
_ "github.com/openshift-eng/openshift-goimports"
2423
_ "k8c.io/reconciler/cmd/reconciler-gen"
2524

25+
_ "github.com/kcp-dev/code-generator/v2"
26+
2627
_ "k8s.io/code-generator/cmd/applyconfiguration-gen"
2728
_ "k8s.io/code-generator/cmd/client-gen"
2829
_ "sigs.k8s.io/controller-tools/cmd/controller-gen"

internal/controller/sync/controller.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@ import (
3232

3333
kcpcore "github.com/kcp-dev/kcp/sdk/apis/core"
3434
kcpdevcorev1alpha1 "github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1"
35+
mccontroller "sigs.k8s.io/multicluster-runtime/pkg/controller"
36+
mchandler "sigs.k8s.io/multicluster-runtime/pkg/handler"
37+
mcmanager "sigs.k8s.io/multicluster-runtime/pkg/manager"
38+
mcreconcile "sigs.k8s.io/multicluster-runtime/pkg/reconcile"
39+
mcsource "sigs.k8s.io/multicluster-runtime/pkg/source"
3540

3641
corev1 "k8s.io/api/core/v1"
3742
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
@@ -46,11 +51,6 @@ import (
4651
"sigs.k8s.io/controller-runtime/pkg/predicate"
4752
"sigs.k8s.io/controller-runtime/pkg/reconcile"
4853
"sigs.k8s.io/controller-runtime/pkg/source"
49-
mccontroller "sigs.k8s.io/multicluster-runtime/pkg/controller"
50-
mchandler "sigs.k8s.io/multicluster-runtime/pkg/handler"
51-
mcmanager "sigs.k8s.io/multicluster-runtime/pkg/manager"
52-
mcreconcile "sigs.k8s.io/multicluster-runtime/pkg/reconcile"
53-
mcsource "sigs.k8s.io/multicluster-runtime/pkg/source"
5454
)
5555

5656
const (

internal/controller/syncmanager/controller.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
"context"
2121
"fmt"
2222

23-
apiexportprovider "github.com/kcp-dev/multicluster-provider/apiexport"
2423
"go.uber.org/zap"
2524

2625
"github.com/kcp-dev/api-syncagent/internal/controller/sync"
@@ -31,6 +30,9 @@ import (
3130

3231
kcpapisv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
3332
kcpdevv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
33+
apiexportprovider "github.com/kcp-dev/multicluster-provider/apiexport"
34+
mccontroller "sigs.k8s.io/multicluster-runtime/pkg/controller"
35+
mcmanager "sigs.k8s.io/multicluster-runtime/pkg/manager"
3436

3537
corev1 "k8s.io/api/core/v1"
3638
"k8s.io/apimachinery/pkg/labels"
@@ -47,8 +49,6 @@ import (
4749
"sigs.k8s.io/controller-runtime/pkg/metrics/server"
4850
"sigs.k8s.io/controller-runtime/pkg/reconcile"
4951
"sigs.k8s.io/controller-runtime/pkg/source"
50-
mccontroller "sigs.k8s.io/multicluster-runtime/pkg/controller"
51-
mcmanager "sigs.k8s.io/multicluster-runtime/pkg/manager"
5252
)
5353

5454
const (

internal/sync/metadata.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,15 @@ import (
2121
"maps"
2222
"strings"
2323

24+
mcreconcile "sigs.k8s.io/multicluster-runtime/pkg/reconcile"
25+
2426
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2527
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
2628
"k8s.io/apimachinery/pkg/labels"
2729
"k8s.io/apimachinery/pkg/types"
2830
"k8s.io/apimachinery/pkg/util/sets"
2931
ctrlruntimeclient "sigs.k8s.io/controller-runtime/pkg/client"
3032
"sigs.k8s.io/controller-runtime/pkg/reconcile"
31-
mcreconcile "sigs.k8s.io/multicluster-runtime/pkg/reconcile"
3233
)
3334

3435
func stripMetadata(obj *unstructured.Unstructured) error {

test/utils/utils.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,11 @@ import (
2323
"regexp"
2424
"testing"
2525

26-
mcclient "github.com/kcp-dev/multicluster-provider/client"
27-
2826
syncagentv1alpha1 "github.com/kcp-dev/api-syncagent/sdk/apis/syncagent/v1alpha1"
2927

3028
kcpapisv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1"
3129
kcptenancyv1alpha1 "github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1"
30+
mcclient "github.com/kcp-dev/multicluster-provider/client"
3231

3332
corev1 "k8s.io/api/core/v1"
3433
rbacv1 "k8s.io/api/rbac/v1"

0 commit comments

Comments
 (0)