work around inconsistency in kcp 0.27 API binding

On-behalf-of: @SAP [email protected]

Author: xrstf

test/e2e/sync/apiexportendpointslice_test.go

@@ -122,6 +122,14 @@ func TestAPIExportEndpointSliceSameCluster(t *testing.T) {
 		Resource: "crontabs",
 	})
 
+	// In kcp 0.27, the binding' status is not perfectly in-sync with the actual APIs available in
+	// the workspace; since this is fixed in 0.28+ and we really care about the APIBinding, not necessarily
+	// the Kubernetes magic behind it, we keep the loop above but on 0.27 add a small synthetic delay.
+	// TODO: Remove this once we do not support kcp 0.27 anymore.
+	if utils.KCPMinor() < 28 {
+		time.Sleep(2 * time.Second)
+	}
+
 	// create a Crontab object in a team workspace
 	t.Log("Creating CronTab in kcp…")
 	crontab := utils.YAMLToUnstructured(t, `
@@ -258,6 +266,11 @@ func TestAPIExportEndpointSliceDifferentCluster(t *testing.T) {
 		Resource: "crontabs",
 	})
 
+	// TODO: Remove this once we do not support kcp 0.27 anymore.
+	if utils.KCPMinor() < 28 {
+		time.Sleep(2 * time.Second)
+	}
+
 	// create a Crontab object in a team workspace
 	t.Log("Creating CronTab in kcp…")
 	crontab := utils.YAMLToUnstructured(t, `

test/utils/utils.go

@@ -21,6 +21,7 @@ import (
 	"net/url"
 	"os"
 	"regexp"
+	"strconv"
 	"strings"
 	"testing"
 
@@ -205,3 +206,22 @@ func YAMLToUnstructured(t *testing.T, data string) *unstructured.Unstructured {
 
 	return ToUnstructured(t, obj)
 }
+
+func KCPMinor() int {
+	version := os.Getenv("KCP_VERSION")
+	if version == "" {
+		panic("No $KCP_VERSION environment variable defined.")
+	}
+
+	parts := strings.SplitN(version, ".", 3)
+	if len(parts) != 3 {
+		panic("Invalid $KCP_VERSION, must be X.Y.Z.")
+	}
+
+	minor, err := strconv.ParseInt(parts[1], 10, 32)
+	if err != nil {
+		panic(fmt.Sprintf("Invalid $KCP_VERSION: not parseable: %v", err))
+	}
+
+	return int(minor)
+}