Skip to content

🐛 Fix labels on related resources, fix syncing related resources, add first e2e test #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2025
Merged

🐛 Fix labels on related resources, fix syncing related resources, add first e2e test #42

merged 2 commits into from
Mar 18, 2025

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Mar 18, 2025

Summary

This PR fixes two issues:

Release Notes

* Fix syncing related resources that originate on the service cluster.
* Fix stripping sync-related labels and annotations from related resources.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2025
cnvergence
cnvergence approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@cnvergence cnvergence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2025
@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Mar 18, 2025

LGTM label has been added.

Git tree hash: c0a6b0ed648c46356aabce3ce21f1713c8b030a0

@xrstf
Copy link
Contributor Author

xrstf commented Mar 18, 2025

/approve

@kcp-ci-bot
Copy link
Contributor

kcp-ci-bot commented Mar 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2025
@kcp-ci-bot kcp-ci-bot merged commit c53499a into main Mar 18, 2025
11 checks passed
@kcp-ci-bot kcp-ci-bot deleted the add-tests-related-resources branch March 18, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cnvergence cnvergence cnvergence approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cnvergence cnvergence

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Agent fails to sync related resources up to kcp bug: sync-related labels are not stripped from related objects

4 participants

@xrstf @kcp-ci-bot @cnvergence