Skip to content

Commit b9189ef

Browse files
committed
PR feedback
On-behalf-of: @SAP christoph.mewes@sap.com
1 parent a62ae16 commit b9189ef

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

docs/content/readiness.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ individual manifests.
1010

1111
## How It Works
1212

13-
When the init-agent encounters a manifest (from any of its [init sources](./init-sources/)) with
13+
When the init-agent encounters a manifest (from any of its [init sources](init-sources/README.md)) with
1414
the `initialization.kcp.io/wait-for-ready` annotation, it will:
1515

1616
1. Create (or confirm the existence of) the object as usual.

docs/content/setup/production.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -205,18 +205,17 @@ Briefly after creating these objects, the resulting kubeconfig Secrets should ap
205205
namespace. For installing the init-agent, we now need to fetch the admin kubecofig (the first one):
206206

207207
```bash
208-
kubectl --namespace my-kcp get secret my-admin-kubeconfig --output json |
209-
jq -r '.data.kubeconfig' |
208+
kubectl --namespace my-kcp get secret my-admin-kubeconfig --output jsonpath="{.data.kubeconfig}" |
210209
base64 -d > kcp-admin.kubeconfig
211210
```
212211

213212
The 2nd kubeconfig Secret can stay in the host cluster, the init-agent will pick it up itself.
214213

215214
### kcp Access
216215

217-
Since in this guide, kind is used to provision the hosting cluster, no real Ingress/Gateway exists
218-
for the kcp-front-proxy. Instead, we will be creating port-forwardings to the front-proxy in order
219-
to install the init-agent.
216+
Since this guide uses kind to provision the hosting cluster, no real Ingress/Gateway exists for the
217+
kcp-front-proxy. Instead, we will be creating port-forwardings to the front-proxy in order to
218+
install the init-agent.
220219

221220
To accomplish this, **either** edit the `kcp-admin.kubeconfig` and replace the hostnames with
222221
"localhost", **or** setup a host alias in your system's `/etc/hosts` file. In this guide, we will
@@ -343,3 +342,5 @@ This completes the installation :-) If you have more workspaces than `:root:my-t
343342

344343
You are now ready to create `InitTarget` objects inside the `:root:init-agent` workspace, referring
345344
to `WorkspaceTypes` in the `:root:my-types` workspace.
345+
346+
[kcp]: https://kcp.io

0 commit comments

Comments
 (0)