Merge pull request #118 from aaronschweig/main

kcp-ci-bot · web-flow · commit 5c8362fe4f5b · 2025-10-19T11:24:23.000+02:00
fix: check if external.hostname is empty to not set an invalid value to the certificate
diff --git a/internal/resources/frontproxy/certificates.go b/internal/resources/frontproxy/certificates.go
@@ -91,7 +91,7 @@ func (r *reconciler) serverCertificateReconciler() reconciling.NamedCertificateR
 		// to not break existing front-proxy installations.
 		if r.frontProxy.Spec.ExternalHostname != "" {
 			dnsNames = append(dnsNames, r.frontProxy.Spec.ExternalHostname)
-		} else {
+		} else if r.frontProxy.Spec.External.Hostname != "" {
 			dnsNames = append(dnsNames, r.frontProxy.Spec.External.Hostname)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func (r *reconciler) serverCertificateReconciler() reconciling.NamedCertificateR`
`91`	`91`	`// to not break existing front-proxy installations.`
`92`	`92`	`if r.frontProxy.Spec.ExternalHostname != "" {`
`93`	`93`	`dnsNames = append(dnsNames, r.frontProxy.Spec.ExternalHostname)`
`94`		`- } else {`
	`94`	`+ } else if r.frontProxy.Spec.External.Hostname != "" {`
`95`	`95`	`dnsNames = append(dnsNames, r.frontProxy.Spec.External.Hostname)`
`96`	`96`	`}`
`97`	`97`	`}`