Skip to content

Commit 01e670f

Browse files
committed
Update scripts with new sdk path
On-behalf-of: @SAP [email protected] Signed-off-by: Marko Mudrinić <[email protected]>
1 parent 02cc624 commit 01e670f

File tree

7 files changed

+52
-51
lines changed

7 files changed

+52
-51
lines changed

.prow.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ presubmits:
9898
- name: pull-kcp-test-integration
9999
decorate: true
100100
# only run integration tests if code changed.
101-
run_if_changed: "(cmd|config|pkg|sdk|test|go.mod|go.sum|Makefile|.prow.yaml)"
101+
run_if_changed: "(cmd|config|pkg|staging|test|go.mod|go.sum|Makefile|.prow.yaml)"
102102
clone_uri: "https://github.com/kcp-dev/kcp"
103103
labels:
104104
preset-goproxy: "true"
@@ -125,7 +125,7 @@ presubmits:
125125
- name: pull-kcp-test-e2e
126126
decorate: true
127127
# only run e2e tests if code changed.
128-
run_if_changed: "(cmd|config|pkg|sdk|test|go.mod|go.sum|Makefile|.prow.yaml)"
128+
run_if_changed: "(cmd|config|pkg|staging|test|go.mod|go.sum|Makefile|.prow.yaml)"
129129
clone_uri: "https://github.com/kcp-dev/kcp"
130130
labels:
131131
preset-goproxy: "true"
@@ -154,7 +154,7 @@ presubmits:
154154
- name: pull-kcp-test-e2e-multiple-runs
155155
decorate: true
156156
# only run e2e tests if code changed.
157-
run_if_changed: "(cmd|config|pkg|sdk|test|go.mod|go.sum|Makefile|.prow.yaml)"
157+
run_if_changed: "(cmd|config|pkg|staging|test|go.mod|go.sum|Makefile|.prow.yaml)"
158158
clone_uri: "https://github.com/kcp-dev/kcp"
159159
labels:
160160
preset-goproxy: "true"
@@ -187,7 +187,7 @@ presubmits:
187187
- name: pull-kcp-test-e2e-shared
188188
decorate: true
189189
# only run e2e tests if code changed.
190-
run_if_changed: "(cmd|config|pkg|sdk|test|go.mod|go.sum|Makefile|.prow.yaml)"
190+
run_if_changed: "(cmd|config|pkg|staging|test|go.mod|go.sum|Makefile|.prow.yaml)"
191191
clone_uri: "https://github.com/kcp-dev/kcp"
192192
labels:
193193
preset-goproxy: "true"
@@ -216,7 +216,7 @@ presubmits:
216216
- name: pull-kcp-test-e2e-sharded
217217
decorate: true
218218
# only run e2e tests if code changed.
219-
run_if_changed: "(cmd|config|pkg|sdk|test|go.mod|go.sum|Makefile|.prow.yaml)"
219+
run_if_changed: "(cmd|config|pkg|staging|test|go.mod|go.sum|Makefile|.prow.yaml)"
220220
clone_uri: "https://github.com/kcp-dev/kcp"
221221
labels:
222222
preset-goproxy: "true"

.typos.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,6 @@ extend-ignore-identifiers-re = [
1818
extend-exclude = [
1919
"config/crds",
2020
"contrib/crds",
21-
"sdk/apis/third_party",
22-
"sdk/testing/third_party",
21+
"staging/src/github.com/kcp-dev/sdk/apis/third_party",
22+
"staging/src/github.com/kcp-dev/sdk/testing/third_party",
2323
]

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ ENV GOPROXY=$goproxy
2828
# Copy the Go Modules manifests
2929
COPY go.mod go.mod
3030
COPY go.sum go.sum
31-
COPY sdk/go.mod sdk/go.mod
32-
COPY sdk/go.sum sdk/go.sum
3331
COPY cli/go.mod cli/go.mod
3432
COPY cli/go.sum cli/go.sum
3533
COPY staging/src/github.com/kcp-dev/apimachinery/go.mod staging/src/github.com/kcp-dev/apimachinery/go.mod
@@ -38,6 +36,8 @@ COPY staging/src/github.com/kcp-dev/client-go/go.mod staging/src/github.com/kcp-
3836
COPY staging/src/github.com/kcp-dev/client-go/go.sum staging/src/github.com/kcp-dev/client-go/go.sum
3937
COPY staging/src/github.com/kcp-dev/code-generator/go.mod staging/src/github.com/kcp-dev/code-generator/go.mod
4038
COPY staging/src/github.com/kcp-dev/code-generator/go.sum staging/src/github.com/kcp-dev/code-generator/go.sum
39+
COPY staging/src/github.com/kcp-dev/sdk/go.mod staging/src/github.com/kcp-dev/sdk/go.mod
40+
COPY staging/src/github.com/kcp-dev/sdk/go.sum staging/src/github.com/kcp-dev/sdk/go.sum
4141
USER 0
4242

4343
# Install kubectl.

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ ldflags:
106106
require-%:
107107
@if ! command -v $* 1> /dev/null 2>&1; then echo "$* not found in ${PATH}"; exit 1; fi
108108

109-
build: WHAT ?= ./cmd/... ./cli/cmd/... ./sdk/cmd/...
109+
build: WHAT ?= ./cmd/... ./cli/cmd/... ./staging/src/github.com/kcp-dev/sdk/cmd/...
110110
build: require-jq require-go require-git verify-go-versions ## Build the project
111111
set -x; for W in $(WHAT); do \
112112
pushd . && cd $${W%..}; \
@@ -119,7 +119,7 @@ build: require-jq require-go require-git verify-go-versions ## Build the project
119119
build-all:
120120
GOOS=$(OS) GOARCH=$(ARCH) $(MAKE) build WHAT='./cmd/...'
121121

122-
install: WHAT ?= ./cmd/... ./cli/cmd/... ./sdk/cmd/...
122+
install: WHAT ?= ./cmd/... ./cli/cmd/... ./staging/src/github.com/kcp-dev/sdk/cmd/...
123123
install: require-jq require-go require-git verify-go-versions ## Install the project
124124
set -x; for W in $(WHAT); do \
125125
pushd . && cd $${W%..}; \
@@ -138,7 +138,7 @@ $(LOGCHECK):
138138
GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) sigs.k8s.io/logtools/logcheck $(LOGCHECK_BIN) $(LOGCHECK_VER)
139139

140140
$(KCP_APIGEN_GEN):
141-
pushd . && cd sdk && GOBIN=$(TOOLS_GOBIN_DIR) go install ./cmd/apigen && popd
141+
pushd . && cd staging/src/github.com/kcp-dev/sdk && GOBIN=$(TOOLS_GOBIN_DIR) go install ./cmd/apigen && popd
142142

143143
lint: $(GOLANGCI_LINT) $(LOGCHECK) ## Verify lint
144144
echo "Linting root module..."; \

hack/update-codegen-clients.sh

Lines changed: 36 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ SCRIPT_ROOT=$(dirname "${BASH_SOURCE[0]}")/..
2525
pushd "${SCRIPT_ROOT}"
2626
BOILERPLATE_HEADER="$( pwd )/hack/boilerplate/boilerplate.generatego.txt"
2727
popd
28+
SDK_PKG=${SDK_PKG:-$(cd "${SCRIPT_ROOT}"; go list -f '{{.Dir}}' -m github.com/kcp-dev/sdk)}
2829
CODEGEN_PKG=${CODEGEN_PKG:-$(cd "${SCRIPT_ROOT}"; go list -f '{{.Dir}}' -m k8s.io/code-generator)}
2930
CLUSTER_CODEGEN_PKG=${CLUSTER_CODEGEN_PKG:-$(cd "${SCRIPT_ROOT}"; go list -f '{{.Dir}}' -m github.com/kcp-dev/code-generator/v3)}
3031
OPENAPI_PKG=${OPENAPI_PKG:-$(cd "${SCRIPT_ROOT}"; go list -f '{{.Dir}}' -m k8s.io/kube-openapi)}
@@ -39,54 +40,54 @@ chmod +x "${CODEGEN_PKG}"/generate-internal-groups.sh
3940
source "${CODEGEN_PKG}/kube_codegen.sh"
4041
source "${CLUSTER_CODEGEN_PKG}/cluster_codegen.sh"
4142

42-
rm -rf ${SCRIPT_ROOT}/sdk/client/{clientset,applyconfiguration,listers,informers}
43-
mkdir -p ${SCRIPT_ROOT}/sdk/client/{clientset,applyconfiguration,listers,informers}
43+
rm -rf ${SDK_PKG}/client/{clientset,applyconfiguration,listers,informers}
44+
mkdir -p ${SDK_PKG}/client/{clientset,applyconfiguration,listers,informers}
4445

4546
"$GOPATH"/bin/applyconfiguration-gen \
4647
--go-header-file "${BOILERPLATE_HEADER}" \
47-
--output-pkg github.com/kcp-dev/kcp/sdk/client/applyconfiguration \
48-
--output-dir "${SCRIPT_ROOT}/sdk/client/applyconfiguration" \
49-
github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1 \
50-
github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1 \
51-
github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1 \
52-
github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha2 \
53-
github.com/kcp-dev/kcp/sdk/apis/cache/v1alpha1 \
54-
github.com/kcp-dev/kcp/sdk/apis/topology/v1alpha1 \
55-
github.com/kcp-dev/kcp/sdk/apis/third_party/conditions/apis/conditions/v1alpha1 \
48+
--output-pkg github.com/kcp-dev/sdk/client/applyconfiguration \
49+
--output-dir "${SDK_PKG}/client/applyconfiguration" \
50+
github.com/kcp-dev/sdk/apis/core/v1alpha1 \
51+
github.com/kcp-dev/sdk/apis/tenancy/v1alpha1 \
52+
github.com/kcp-dev/sdk/apis/apis/v1alpha1 \
53+
github.com/kcp-dev/sdk/apis/apis/v1alpha2 \
54+
github.com/kcp-dev/sdk/apis/cache/v1alpha1 \
55+
github.com/kcp-dev/sdk/apis/topology/v1alpha1 \
56+
github.com/kcp-dev/sdk/apis/third_party/conditions/apis/conditions/v1alpha1 \
5657
k8s.io/apimachinery/pkg/apis/meta/v1 \
5758
k8s.io/apimachinery/pkg/runtime \
5859
k8s.io/apimachinery/pkg/version
5960

6061
"$GOPATH"/bin/client-gen \
6162
--go-header-file "${BOILERPLATE_HEADER}" \
62-
--output-pkg github.com/kcp-dev/kcp/sdk/client/clientset \
63-
--output-dir "${SCRIPT_ROOT}/sdk/client/clientset" \
64-
--input github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1 \
65-
--input github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1 \
66-
--input github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1 \
67-
--input github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha2 \
68-
--input github.com/kcp-dev/kcp/sdk/apis/topology/v1alpha1 \
69-
--input github.com/kcp-dev/kcp/sdk/apis/cache/v1alpha1 \
63+
--output-pkg github.com/kcp-dev/sdk/client/clientset \
64+
--output-dir "${SDK_PKG}/client/clientset" \
65+
--input github.com/kcp-dev/sdk/apis/core/v1alpha1 \
66+
--input github.com/kcp-dev/sdk/apis/tenancy/v1alpha1 \
67+
--input github.com/kcp-dev/sdk/apis/apis/v1alpha1 \
68+
--input github.com/kcp-dev/sdk/apis/apis/v1alpha2 \
69+
--input github.com/kcp-dev/sdk/apis/topology/v1alpha1 \
70+
--input github.com/kcp-dev/sdk/apis/cache/v1alpha1 \
7071
--input-base="" \
71-
--apply-configuration-package=github.com/kcp-dev/kcp/sdk/client/applyconfiguration \
72+
--apply-configuration-package=github.com/kcp-dev/sdk/client/applyconfiguration \
7273
--clientset-name "versioned"
7374

7475
kube::codegen::gen_helpers \
7576
--boilerplate "${BOILERPLATE_HEADER}" \
76-
./sdk/apis
77+
./staging/src/github.com/kcp-dev/sdk/apis
7778

78-
cd sdk
79+
cd ./staging/src/github.com/kcp-dev/sdk
7980
cluster::codegen::gen_client \
8081
--boilerplate "${BOILERPLATE_HEADER}" \
8182
--versioned-clientset-dir client/clientset/versioned/cluster \
82-
--versioned-clientset-pkg github.com/kcp-dev/kcp/sdk/client/clientset/versioned/cluster \
83+
--versioned-clientset-pkg github.com/kcp-dev/sdk/client/clientset/versioned/cluster \
8384
--listers-dir client/listers \
84-
--listers-pkg github.com/kcp-dev/kcp/sdk/client/listers \
85+
--listers-pkg github.com/kcp-dev/sdk/client/listers \
8586
--informers-dir client/informers/externalversions \
86-
--informers-pkg github.com/kcp-dev/kcp/sdk/client/informers/externalversions \
87+
--informers-pkg github.com/kcp-dev/sdk/client/informers/externalversions \
8788
--with-watch \
88-
--single-cluster-versioned-clientset-pkg github.com/kcp-dev/kcp/sdk/client/clientset/versioned \
89-
--single-cluster-applyconfigurations-pkg github.com/kcp-dev/kcp/sdk/client/applyconfiguration \
89+
--single-cluster-versioned-clientset-pkg github.com/kcp-dev/sdk/client/clientset/versioned \
90+
--single-cluster-applyconfigurations-pkg github.com/kcp-dev/sdk/client/applyconfiguration \
9091
apis
9192
cd -
9293

@@ -108,7 +109,7 @@ cd -
108109

109110
kube::codegen::gen_helpers \
110111
--boilerplate "${BOILERPLATE_HEADER}" \
111-
./sdk/third_party/conditions/apis
112+
./staging/src/github.com/kcp-dev/sdk/third_party/conditions/apis
112113

113114
kube::codegen::gen_helpers \
114115
--boilerplate "${BOILERPLATE_HEADER}" \
@@ -136,13 +137,13 @@ go install "${OPENAPI_PKG}"/cmd/openapi-gen
136137
--output-pkg github.com/kcp-dev/kcp/pkg/openapi \
137138
--output-file zz_generated.openapi.go \
138139
--output-dir "${SCRIPT_ROOT}/pkg/openapi" \
139-
github.com/kcp-dev/kcp/sdk/apis/core/v1alpha1 \
140-
github.com/kcp-dev/kcp/sdk/apis/tenancy/v1alpha1 \
141-
github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha1 \
142-
github.com/kcp-dev/kcp/sdk/apis/apis/v1alpha2 \
143-
github.com/kcp-dev/kcp/sdk/apis/topology/v1alpha1 \
144-
github.com/kcp-dev/kcp/sdk/apis/cache/v1alpha1 \
145-
github.com/kcp-dev/kcp/sdk/apis/third_party/conditions/apis/conditions/v1alpha1 \
140+
github.com/kcp-dev/sdk/apis/core/v1alpha1 \
141+
github.com/kcp-dev/sdk/apis/tenancy/v1alpha1 \
142+
github.com/kcp-dev/sdk/apis/apis/v1alpha1 \
143+
github.com/kcp-dev/sdk/apis/apis/v1alpha2 \
144+
github.com/kcp-dev/sdk/apis/topology/v1alpha1 \
145+
github.com/kcp-dev/sdk/apis/cache/v1alpha1 \
146+
github.com/kcp-dev/sdk/apis/third_party/conditions/apis/conditions/v1alpha1 \
146147
k8s.io/apimachinery/pkg/apis/meta/v1 \
147148
k8s.io/apimachinery/pkg/runtime \
148149
k8s.io/apimachinery/pkg/version

hack/update-codegen-crds.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ REPO_ROOT=$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)
2828

2929
# Update generated CRD YAML
3030
(
31-
cd "${REPO_ROOT}/sdk/apis"
32-
"../../${CONTROLLER_GEN}" \
31+
cd "${REPO_ROOT}/staging/src/github.com/kcp-dev/sdk/apis"
32+
"../../../../../../${CONTROLLER_GEN}" \
3333
crd \
3434
rbac:roleName=manager-role \
3535
webhook \

hack/verify-contextual-logging.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ ${LOGCHECK} ${LOGCHECK_ARGS} ./... > "${work_file}" 2>&1
3131
set -o errexit
3232

3333
# sdk is a separate module, so check that in addition to our root packages
34-
echo "Checking "${REPO_ROOT}"/sdk"
35-
cd "${REPO_ROOT}"/sdk
34+
echo "Checking "${REPO_ROOT}"/staging/src/github.com/kcp-dev/sdk"
35+
cd "${REPO_ROOT}"/staging/src/github.com/kcp-dev/sdk
3636
set +o errexit
3737
${LOGCHECK} ${LOGCHECK_ARGS} ./... >> "${work_file}" 2>&1
3838
set -o errexit

0 commit comments

Comments
 (0)