enable intrange linter

xrstf · xrstf · commit 44d7239a5ef1 · 2025-06-18T15:50:24.000+02:00
On-behalf-of: @SAP christoph.mewes@sap.com
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -22,6 +22,7 @@ linters:
     - govet
     - importas
     - ineffassign
+    - intrange
     - misspell
     - nilerr
     - noctx
diff --git a/cmd/sharded-test-server/main.go b/cmd/sharded-test-server/main.go
@@ -217,7 +217,7 @@ func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numb
 
 	// start shards
 	var shards []*testshard.Shard
-	for i := 0; i < numberOfShards; i++ {
+	for i := range numberOfShards {
 		shard, err := newShard(ctx, i, shardFlags, standaloneVW, servingCA, hostIP.String(), logDirPath, workDirPath, cacheServerConfigPath, clientCA)
 		if err != nil {
 			return err
@@ -235,7 +235,7 @@ func start(proxyFlags, shardFlags []string, logDirPath, workDirPath string, numb
 		// TODO: support multiple virtual workspace servers (i.e. multiple ports)
 		vwPort = "7444"
 
-		for i := 0; i < numberOfShards; i++ {
+		for i := range numberOfShards {
 			vw, err := newVirtualWorkspace(ctx, i, servingCA, hostIP.String(), logDirPath, workDirPath, clientCA, cacheServerConfigPath)
 			if err != nil {
 				return err
diff --git a/pkg/proxy/index/index_controller.go b/pkg/proxy/index/index_controller.go
@@ -146,7 +146,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/apibinding/apibinding_controller.go b/pkg/reconciler/apis/apibinding/apibinding_controller.go
@@ -420,7 +420,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/apibindingdeletion/apibinding_deletion_controller.go b/pkg/reconciler/apis/apibindingdeletion/apibinding_deletion_controller.go
@@ -149,7 +149,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/apis/apiexport/apiexport_controller.go b/pkg/reconciler/apis/apiexport/apiexport_controller.go
@@ -271,7 +271,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/apiexportendpointslice/apiexportendpointslice_controller.go b/pkg/reconciler/apis/apiexportendpointslice/apiexportendpointslice_controller.go
@@ -235,7 +235,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/apiexportendpointsliceurls/apiexportendpointsliceurls_controller.go b/pkg/reconciler/apis/apiexportendpointsliceurls/apiexportendpointsliceurls_controller.go
@@ -272,7 +272,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/crdcleanup/crdcleanup_controller.go b/pkg/reconciler/apis/crdcleanup/crdcleanup_controller.go
@@ -162,7 +162,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/extraannotationsync/apibindingannotation_controller.go b/pkg/reconciler/apis/extraannotationsync/apibindingannotation_controller.go
@@ -185,7 +185,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/logicalclustercleanup/logicalclustercleanup_controller.go b/pkg/reconciler/apis/logicalclustercleanup/logicalclustercleanup_controller.go
@@ -173,7 +173,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_controller.go b/pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_controller.go
@@ -139,7 +139,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("starting controller")
 	defer logger.Info("shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_resource_controller.go b/pkg/reconciler/apis/permissionclaimlabel/permissionclaimlabel_resource_controller.go
@@ -112,7 +112,7 @@ func (c *resourceController) Start(ctx context.Context, numThreads int) {
 	logger.Info("starting controller")
 	defer logger.Info("shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/cache/cachedresources/cachedresources_controller.go b/pkg/reconciler/cache/cachedresources/cachedresources_controller.go
@@ -200,7 +200,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 	c.started = true
diff --git a/pkg/reconciler/cache/cachedresources/replication/replication_controller.go b/pkg/reconciler/cache/cachedresources/replication/replication_controller.go
@@ -154,7 +154,7 @@ func (c *Controller) Start(ctx context.Context, workers int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 	c.started = true
diff --git a/pkg/reconciler/cache/labelclusterrolebindings/labelclusterrolebinding_controller.go b/pkg/reconciler/cache/labelclusterrolebindings/labelclusterrolebinding_controller.go
@@ -203,7 +203,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/cache/labelclusterroles/labelclusterrole_controller.go b/pkg/reconciler/cache/labelclusterroles/labelclusterrole_controller.go
@@ -203,7 +203,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/cache/labellogicalcluster/labellogicalcluster_controller.go b/pkg/reconciler/cache/labellogicalcluster/labellogicalcluster_controller.go
@@ -146,7 +146,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/cache/replication/replication_controller.go b/pkg/reconciler/cache/replication/replication_controller.go
@@ -129,7 +129,7 @@ func (c *controller) Start(ctx context.Context, workers int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < workers; i++ {
+	for range workers {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 	<-ctx.Done()
diff --git a/pkg/reconciler/core/logicalcluster/logicalcluster_controller.go b/pkg/reconciler/core/logicalcluster/logicalcluster_controller.go
@@ -109,7 +109,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/core/logicalclusterdeletion/logicalcluster_deletion_controller.go b/pkg/reconciler/core/logicalclusterdeletion/logicalcluster_deletion_controller.go
@@ -178,7 +178,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	}
 	c.dynamicFrontProxyClient = dynamicFrontProxyClient
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/core/shard/shard_controller.go b/pkg/reconciler/core/shard/shard_controller.go
@@ -108,7 +108,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/dynamicrestmapper/dynamicrestmapper_controller.go b/pkg/reconciler/dynamicrestmapper/dynamicrestmapper_controller.go
@@ -260,7 +260,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/garbagecollector/garbagecollector_controller.go b/pkg/reconciler/garbagecollector/garbagecollector_controller.go
@@ -145,7 +145,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/kubequota/kubequota_controller.go b/pkg/reconciler/kubequota/kubequota_controller.go
@@ -153,7 +153,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/tenancy/bootstrap/bootstrap_controller.go b/pkg/reconciler/tenancy/bootstrap/bootstrap_controller.go
@@ -131,7 +131,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/tenancy/defaultapibindinglifecycle/default_apibinding_lifecycle_controller.go b/pkg/reconciler/tenancy/defaultapibindinglifecycle/default_apibinding_lifecycle_controller.go
@@ -224,7 +224,7 @@ func (c *DefaultAPIBindingController) Start(ctx context.Context, numThreads int)
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 	<-ctx.Done()
diff --git a/pkg/reconciler/tenancy/initialization/apibinder_initializer_controller.go b/pkg/reconciler/tenancy/initialization/apibinder_initializer_controller.go
@@ -244,7 +244,7 @@ func (b *APIBinder) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, b.startWorker, time.Second)
 	}
 	<-ctx.Done()
diff --git a/pkg/reconciler/tenancy/logicalcluster/logicalcluster_controller.go b/pkg/reconciler/tenancy/logicalcluster/logicalcluster_controller.go
@@ -137,7 +137,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/tenancy/workspace/workspace_controller.go b/pkg/reconciler/tenancy/workspace/workspace_controller.go
@@ -197,7 +197,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/tenancy/workspacemounts/workspacemounts_controller.go b/pkg/reconciler/tenancy/workspacemounts/workspacemounts_controller.go
@@ -135,7 +135,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())
 	}
 
diff --git a/pkg/reconciler/tenancy/workspacetype/workspacetype_controller.go b/pkg/reconciler/tenancy/workspacetype/workspacetype_controller.go
@@ -171,7 +171,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/reconciler/topology/partitionset/partitionset_controller.go b/pkg/reconciler/topology/partitionset/partitionset_controller.go
@@ -258,7 +258,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {
 	logger.Info("Starting controller")
 	defer logger.Info("Shutting down controller")
 
-	for i := 0; i < numThreads; i++ {
+	for range numThreads {
 		go wait.UntilWithContext(ctx, c.startWorker, time.Second)
 	}
 
diff --git a/pkg/virtual/framework/forwardingregistry/store_test.go b/pkg/virtual/framework/forwardingregistry/store_test.go
@@ -31,7 +31,7 @@ func TestUpdateToCreateOptions(t *testing.T) {
 	require.Equalf(t, 4, numField, "UpdateOptions is expected to have 4 fields")
 
 	var fields []string
-	for i := 0; i < numField; i++ {
+	for i := range numField {
 		fields = append(fields, updateOptions.Field(i).Name)
 	}
 
diff --git a/sdk/apis/apis/fuzzer/fuzzer.go b/sdk/apis/apis/fuzzer/fuzzer.go
@@ -58,7 +58,7 @@ func Funcs(codecs runtimeserializer.CodecFactory) []interface{} {
 		func(r *v1alpha2.APIExportSpec, c fuzz.Continue) {
 			c.FuzzNoCustom(r)
 			r.Resources = nil
-			for i := 0; i < c.Intn(5); i++ {
+			for range c.Intn(5) {
 				name := nonEmptyString(c.RandString)
 				group := nonEmptyString(c.RandString)
 				schema := nonEmptyString(c.RandString) + "." + name + "." + group
@@ -72,13 +72,13 @@ func Funcs(codecs runtimeserializer.CodecFactory) []interface{} {
 				})
 			}
 			r.PermissionClaims = nil
-			for i := 0; i < c.Intn(5); i++ {
+			for range c.Intn(5) {
 				group := nonEmptyString(c.RandString)
 				resource := nonEmptyString(c.RandString)
 				identityHash := nonEmptyString(c.RandString)
 				verbs := []string{}
 				numVerbs := c.Intn(5) + 1 // the lower bound is 0, but 0 verbs is not a valid combination
-				for j := 0; j < numVerbs; j++ {
+				for range numVerbs {
 					verbs = append(verbs, nonEmptyString(c.RandString))
 				}
 				r.PermissionClaims = append(r.PermissionClaims, v1alpha2.PermissionClaim{
diff --git a/sdk/apis/roundtrip_test.go b/sdk/apis/roundtrip_test.go
@@ -95,7 +95,7 @@ func TestConversion(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			for i := 0; i < *FuzzIters; i++ {
+			for range *FuzzIters {
 				testGenericConversion(t, test.v1.DeepCopyObject, test.v2.DeepCopyObject, test.toV1, test.toV2)
 			}
 		})
diff --git a/test/e2e/conformance/cross_logical_cluster_list_test.go b/test/e2e/conformance/cross_logical_cluster_list_test.go
@@ -289,7 +289,7 @@ func TestBuiltInCrossLogicalClusterListPartialObjectMetadata(t *testing.T) {
 	kubeClusterClient, err := kcpkubernetesclientset.NewForConfig(cfg)
 	require.NoError(t, err, "error creating kube cluster client")
 
-	for i := 0; i < 3; i++ {
+	for i := range 3 {
 		wsPath, _ := kcptesting.NewWorkspaceFixture(t, server, orgPath, kcptesting.WithRootShard())
 
 		configMapName := fmt.Sprintf("test-cm-%d", i)
diff --git a/test/e2e/garbagecollector/garbagecollector_test.go b/test/e2e/garbagecollector/garbagecollector_test.go
@@ -153,7 +153,7 @@ func TestGarbageCollectorTypesFromBinding(t *testing.T) {
 	require.NoError(t, err)
 
 	// Test multiple workspaces in parallel
-	for i := 0; i < 3; i++ {
+	for i := range 3 {
 		t.Run(fmt.Sprintf("tc%d", i), func(t *testing.T) {
 			t.Parallel()
 
diff --git a/test/e2e/quota/quota_test.go b/test/e2e/quota/quota_test.go
@@ -70,7 +70,7 @@ func TestKubeQuotaBuiltInCoreV1Types(t *testing.T) {
 
 	// Create more than 1 workspace with the same quota restrictions to validate that after we create the first workspace
 	// and fill its quota to capacity, subsequent workspaces have independent quota.
-	for i := 0; i < 3; i++ {
+	for i := range 3 {
 		wsPath, _ := kcptesting.NewWorkspaceFixture(t, server, orgPath, kcptesting.WithName("quota-%d", i))
 
 		ws1Quota := &corev1.ResourceQuota{
@@ -119,7 +119,7 @@ func TestKubeQuotaCoreV1TypesFromBinding(t *testing.T) {
 	t.Cleanup(cancel)
 
 	// Test multiple workspaces in parallel
-	for i := 0; i < 5; i++ {
+	for i := range 5 {
 		t.Run(fmt.Sprintf("tc%d", i), func(t *testing.T) {
 			t.Parallel()
 
@@ -350,7 +350,7 @@ func TestClusterScopedQuota(t *testing.T) {
 
 	// Create more than 1 workspace with the same quota restrictions to validate that after we create the first workspace
 	// and fill its quota to capacity, subsequent workspaces have independent quota.
-	for i := 0; i < 3; i++ {
+	for i := range 3 {
 		wsPath, _ := kcptesting.NewWorkspaceFixture(t, server, orgPath, kcptesting.WithName("quota-%d", i))
 
 		const adminNamespace = "admin"
diff --git a/test/e2e/virtual/apiexport/virtualworkspace_test.go b/test/e2e/virtual/apiexport/virtualworkspace_test.go
diff --git a/test/e2e/watchcache/watchcache_enabled_test.go b/test/e2e/watchcache/watchcache_enabled_test.go

Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {`
`146`	`146`	`logger.Info("Starting controller")`
`147`	`147`	`defer logger.Info("Shutting down controller")`
`148`	`148`
`149`		`- for i := 0; i < numThreads; i++ {`
	`149`	`+ for range numThreads {`
`150`	`150`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`151`	`151`	`}`
`152`	`152`
Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`420`	`420`	`logger.Info("Starting controller")`
`421`	`421`	`defer logger.Info("Shutting down controller")`
`422`	`422`
`423`		`- for i := 0; i < numThreads; i++ {`
	`423`	`+ for range numThreads {`
`424`	`424`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`425`	`425`	`}`
`426`	`426`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ func (c *Controller) Start(ctx context.Context, numThreads int) {`
`149`	`149`	`logger.Info("Starting controller")`
`150`	`150`	`defer logger.Info("Shutting down controller")`
`151`	`151`
`152`		`- for i := 0; i < numThreads; i++ {`
	`152`	`+ for range numThreads {`
`153`	`153`	`go wait.Until(func() { c.startWorker(ctx) }, time.Second, ctx.Done())`
`154`	`154`	`}`
`155`	`155`
Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`271`	`271`	`logger.Info("Starting controller")`
`272`	`272`	`defer logger.Info("Shutting down controller")`
`273`	`273`
`274`		`- for i := 0; i < numThreads; i++ {`
	`274`	`+ for range numThreads {`
`275`	`275`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`276`	`276`	`}`
`277`	`277`
Original file line number	Diff line number	Diff line change
`@@ -235,7 +235,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`235`	`235`	`logger.Info("Starting controller")`
`236`	`236`	`defer logger.Info("Shutting down controller")`
`237`	`237`
`238`		`- for i := 0; i < numThreads; i++ {`
	`238`	`+ for range numThreads {`
`239`	`239`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`240`	`240`	`}`
`241`	`241`
Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`272`	`272`	`logger.Info("Starting controller")`
`273`	`273`	`defer logger.Info("Shutting down controller")`
`274`	`274`
`275`		`- for i := 0; i < numThreads; i++ {`
	`275`	`+ for range numThreads {`
`276`	`276`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`277`	`277`	`}`
`278`	`278`
Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`162`	`162`	`logger.Info("Starting controller")`
`163`	`163`	`defer logger.Info("Shutting down controller")`
`164`	`164`
`165`		`- for i := 0; i < numThreads; i++ {`
	`165`	`+ for range numThreads {`
`166`	`166`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`167`	`167`	`}`
`168`	`168`
Original file line number	Diff line number	Diff line change
`@@ -185,7 +185,7 @@ func (c *controller) Start(ctx context.Context, numThreads int) {`
`185`	`185`	`logger.Info("Starting controller")`
`186`	`186`	`defer logger.Info("Shutting down controller")`
`187`	`187`
`188`		`- for i := 0; i < numThreads; i++ {`
	`188`	`+ for range numThreads {`
`189`	`189`	`go wait.UntilWithContext(ctx, c.startWorker, time.Second)`
`190`	`190`	`}`
`191`	`191`