Replace require.Eventually with kcptestinghelpers.Eventually

Signed-off-by: Nelo-T. Wallus <[email protected]>

Author: ntnn

test/e2e/apibinding/apibinding_webhook_test.go

@@ -29,7 +29,7 @@ import (
 
 	admissionv1 "k8s.io/api/admission/v1"
 	admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
-	"k8s.io/apimachinery/pkg/api/errors"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -197,14 +197,13 @@ func TestAPIBindingMutatingWebhook(t *testing.T) {
 
 	// Avoid race condition here by making sure that CRD is served after installing the types into logical clusters
 	t.Logf("Creating cowboy resource in target logical cluster")
-	require.Eventually(t, func() bool {
-		_, err = cowbyClusterClient.Cluster(targetPath).WildwestV1alpha1().Cowboys("default").Create(ctx, &cowboy, metav1.CreateOptions{})
-		t.Log(err)
-		if err != nil && !errors.IsAlreadyExists(err) {
-			return false
+	kcptestinghelpers.Eventually(t, func() (bool, string) {
+		_, err := cowbyClusterClient.Cluster(targetPath).WildwestV1alpha1().Cowboys("default").Create(ctx, &cowboy, metav1.CreateOptions{})
+		if err != nil && !apierrors.IsAlreadyExists(err) {
+			return false, err.Error()
 		}
-		return testWebhooks[sourcePath].Calls() >= 1
-	}, wait.ForeverTestTimeout, 100*time.Millisecond)
+		return testWebhooks[sourcePath].Calls() >= 1, ""
+	}, wait.ForeverTestTimeout, 100*time.Millisecond, "failed to create cowboy resource")
 
 	t.Logf("Check that the in-workspace webhook was NOT called")
 	require.Zero(t, testWebhooks[targetPath].Calls(), "in-workspace webhook should not have been called")