fix .Error calls under .V wrapper

This is required as .V().Error actually ignores the logging level and
will always log, which is not as intended.

This is a new finding in recent k8s logcheck versions

On-behalf-of: SAP <simon.bein@sap.com>
Signed-off-by: Simon Bein <simontheleg@gmail.com>

Author: SimonTheLeg

pkg/reconciler/core/logicalclusterdeletion/deletion/logicalcluster_resource_deletor.go

@@ -174,7 +174,7 @@ func (d *logicalClusterResourcesDeleter) deleteCollection(ctx context.Context, c
 	opts := metav1.DeleteOptions{PropagationPolicy: &background}
 	if err := d.metadataClusterClient.Resource(gvr).Cluster(clusterName.Path()).DeleteCollection(
 		ctx, opts, metav1.ListOptions{}); err != nil {
-		logger.V(5).Error(err, "unexpected deleteCollection error")
+		logger.V(5).Info("unexpected deleteCollection error", "err", err)
 		return true, err
 	}
 
@@ -262,7 +262,7 @@ func (d *logicalClusterResourcesDeleter) deleteAllContentForGroupVersionResource
 	// estimate how long it will take for the resource to be deleted (needed for objects that support graceful delete)
 	estimate, err := d.estimateGracefulTermination(ctx, gvr, clusterName, clusterDeletedAt)
 	if err != nil {
-		logger.V(5).Error(err, "unable to estimate")
+		logger.V(5).Info("unable to estimate", "err", err)
 		return gvrDeletionMetadata{}, err
 	}
 	logger.V(5).Info("created estimate", "estimate", estimate)
@@ -286,7 +286,7 @@ func (d *logicalClusterResourcesDeleter) deleteAllContentForGroupVersionResource
 	logger.V(5).Info("checking for no more items")
 	unstructuredList, listSupported, err := d.listCollection(ctx, clusterName, gvr, verbs)
 	if err != nil {
-		logger.V(5).Error(err, "error verifying no items in logical cluster")
+		logger.V(5).Info("error verifying no items in logical cluster", "err", err)
 		return gvrDeletionMetadata{finalizerEstimateSeconds: estimate}, err
 	}
 	if !listSupported {
@@ -453,7 +453,7 @@ func (d *logicalClusterResourcesDeleter) deleteAllContent(ctx context.Context, w
 			"%s",
 			message,
 		)
-		logger.V(4).Error(utilerrors.NewAggregate(errs), "resource remaining")
+		logger.V(4).Info("resource remaining", "err", utilerrors.NewAggregate(errs))
 		return estimate, message, utilerrors.NewAggregate(errs)
 	}
 

pkg/reconciler/core/logicalclusterdeletion/logicalcluster_deletion_controller.go

@@ -216,7 +216,7 @@ func (c *Controller) processNextWorkItem(ctx context.Context) bool {
 	if errors.As(err, &estimate) {
 		t := estimate.Estimate/2 + 1
 		duration := time.Duration(t) * time.Second
-		logger.V(2).Error(err, "content remaining in logical cluster after a wait, waiting more to continue", "duration", time.Since(startTime), "waiting", duration)
+		logger.V(2).Info("content remaining in logical cluster after a wait, waiting more to continue", "duration", time.Since(startTime), "waiting", duration, "err", err)
 
 		c.queue.AddAfter(key, duration)
 	} else {