Skip to content

Commit 77913c5

Browse files
committed
Remove test failing due to list-via-watch removal
Upstream disabled list-via-watch in kubernetes/kubernetes#131359 Reenabling would be possible through a feature gate but upstream doesn't seem keen on continuing the feature. Signed-off-by: Nelo-T. Wallus <[email protected]>
1 parent c220e1f commit 77913c5

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

test/e2e/virtual/replication/virtualworkspace_test.go

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@ import (
2828
apierrors "k8s.io/apimachinery/pkg/api/errors"
2929
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
3030
"k8s.io/apimachinery/pkg/labels"
31-
"k8s.io/apimachinery/pkg/util/sets"
3231
"k8s.io/apimachinery/pkg/util/wait"
3332
"k8s.io/apimachinery/pkg/watch"
3433
"k8s.io/client-go/discovery/cached/memory"
3534
kubernetesclientset "k8s.io/client-go/kubernetes"
3635
"k8s.io/client-go/rest"
3736
"k8s.io/client-go/restmapper"
37+
"k8s.io/kube-openapi/pkg/util/sets"
3838

3939
kcpdiscovery "github.com/kcp-dev/client-go/discovery"
4040
kcpdynamic "github.com/kcp-dev/client-go/dynamic"
@@ -277,17 +277,10 @@ func TestCachedResourceVirtualWorkspace(t *testing.T) {
277277
}
278278
}
279279

280-
t.Logf("Verify that the first watched event is the second cowboy with labels %v", cowboyLabels)
281-
e, next := waitForEvent()
282-
checkEvent(e, watch.Added, true, next, func(cowboy *wildwestv1alpha1.Cowboy) {
283-
require.Equal(t, cowboyName2, cowboy.Name, "expected to receive the second cowboy")
284-
require.Equal(t, cowboyLabels, cowboy.GetLabels(), "expected the cowboy to have labels defined")
285-
})
286-
287280
t.Logf("Set labels on first cowboy to %v", cowboyLabels)
288281
setLabelsOnCowboyInConsumer(ctx, t, consumerPath, wildwestClusterClient, cowboyName1, cowboyLabels)
289282
t.Logf("Verify that the second watched event is the first cowboy with updated labels %v", cowboyLabels)
290-
e, next = waitForEvent()
283+
e, next := waitForEvent()
291284
checkEvent(e, watch.Modified, true, next, func(cowboy *wildwestv1alpha1.Cowboy) {
292285
require.Equal(t, cowboyName1, cowboy.Name, "expected to receive the first cowboy")
293286
require.Equal(t, cowboyLabels, cowboy.GetLabels(), "expected the cowboy to have labels defined")

0 commit comments

Comments
 (0)