Skip to content

Commit 7d17f91

Browse files
committed
fix docs validation in Pull Requests
On-behalf-of: @SAP [email protected]
1 parent 973ea74 commit 7d17f91

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

.github/workflows/docs-gen-and-push.yaml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Generate and push docs
1+
name: Documentation
22

33
on:
44
# So we can trigger manually if needed
@@ -24,7 +24,7 @@ concurrency:
2424

2525
jobs:
2626
generate-and-push:
27-
name: Generate and push docs
27+
name: Generate and push
2828
runs-on: ubuntu-latest
2929
steps:
3030
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # tag=v4.2.2
@@ -42,4 +42,10 @@ jobs:
4242
python-version: '3.10'
4343
cache: 'pip'
4444

45+
# mike does not support giving CLI flags for mkdocs, but we also do not
46+
# want to permanently enable strict mode, so here we enable it just for this
47+
# task
48+
- run: |
49+
echo "strict: true" >> docs/mkdocs.yml
50+
4551
- run: make generate-cli-docs generate-api-docs deploy-docs

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ generate-cli-docs: ## Generate cli docs
168168

169169
.PHONY: generate-api-docs
170170
generate-api-docs: ## Generate api docs
171-
git clean -fdX docs/content/reference/api
171+
git clean -fdX docs/content/reference/crd
172172
docs/generators/crd-ref/run-crd-ref-gen.sh
173173

174174
VENVDIR=$(abspath docs/venv)

docs/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
mike==2.1.3
22
mkdocs==1.5.3
33
mkdocs-awesome-pages-plugin==2.9.2
4-
mkdocs-macros-plugin==1.0.5
4+
mkdocs-macros-plugin==1.3.7
55
mkdocs-material==9.5.17
66
mkdocs-material-extensions==1.3.1
77
mkdocs-static-i18n==1.2.2

0 commit comments

Comments
 (0)