refactor: allow for generation of multiple virtual workspace urls

On-behalf-of: SAP <[email protected]>
Signed-off-by: Simon Bein <[email protected]>

Author: SimonTheLeg

pkg/reconciler/tenancy/workspacetype/workspacetype_controller_reconcile.go

@@ -66,26 +66,29 @@ func (c *controller) updateVirtualWorkspaceURLs(ctx context.Context, wt *tenancy
 			continue
 		}
 
-		u, err := url.Parse(shard.Spec.VirtualWorkspaceURL)
-		if err != nil {
-			// Should never happen
-			logger.Error(err, "error parsing shard.spec.virtualWorkspaceURL", "virtualWorkspaceURL", shard.Spec.VirtualWorkspaceURL)
-			continue
+		// generate URLs for initializing workspaces
+		for _, virtualWorkspaceName := range []string{initializingworkspaces.VirtualWorkspaceName} {
+			u, err := url.Parse(shard.Spec.VirtualWorkspaceURL)
+			if err != nil {
+				// Should never happen
+				logger.Error(err, "error parsing shard.spec.virtualWorkspaceURL", "virtualWorkspaceURL", shard.Spec.VirtualWorkspaceURL)
+				continue
+			}
+
+			u.Path = path.Join(
+				u.Path,
+				virtualworkspacesoptions.DefaultRootPathPrefix,
+				virtualWorkspaceName,
+				string(initialization.InitializerForType(wt)),
+			)
+
+			desiredURLs.Insert(u.String())
 		}
 
-		u.Path = path.Join(
-			u.Path,
-			virtualworkspacesoptions.DefaultRootPathPrefix,
-			initializingworkspaces.VirtualWorkspaceName,
-			string(initialization.InitializerForType(wt)),
-		)
-
-		desiredURLs.Insert(u.String())
+		wt.Status.VirtualWorkspaces = nil
 	}
 
-	wt.Status.VirtualWorkspaces = nil
-
-	for _, u := range sets.List[string](desiredURLs) {
+	for _, u := range sets.List(desiredURLs) {
 		wt.Status.VirtualWorkspaces = append(wt.Status.VirtualWorkspaces, tenancyv1alpha1.VirtualWorkspace{
 			URL: u,
 		})