do not enable, but improve one spot appendAssign found

On-behalf-of: @SAP [email protected]

Author: xrstf

.golangci.yaml

@@ -41,20 +41,20 @@ linters:
   settings:
     gocritic:
       disabled-checks:
-        # - appendAssign
+        - appendAssign
         - dupImport # https://github.com/go-critic/go-critic/issues/845
         - ifElseChain
         - octalLiteral
         - typeDefFirst
         - unnamedResult
         - whyNoLint
-        # - unnecessaryBlock
+        - unnecessaryBlock
         - rangeValCopy
         - hugeParam
         - commentedOutCode
         - emptyStringTest
         - singleCaseSwitch
-        # - nestingReduce
+        - nestingReduce
         - tooManyResultsChecker
       enabled-tags:
         - diagnostic
@@ -78,7 +78,7 @@ linters:
       require-specific: true
       allow-unused: false
     revive:
-    # make sure error-strings issues actually surface (default confidence is 0.8)
+      # make sure error-strings issues actually surface (default confidence is 0.8)
       confidence: 0.6
       rules:
         - name: context-keys-type

test/e2e/apibinding/default_apibinding_test.go

@@ -111,7 +111,7 @@ func TestDefaultAPIBinding(t *testing.T) {
 			},
 		},
 	}
-	apiExportCreated, err := kcpClusterClient.Cluster(providerPath).ApisV1alpha2().APIExports().Create(ctx, apiExport, metav1.CreateOptions{})
+	_, err = kcpClusterClient.Cluster(providerPath).ApisV1alpha2().APIExports().Create(ctx, apiExport, metav1.CreateOptions{})
 	require.NoError(t, err)
 
 	workspaceType := tenancyv1alpha1.WorkspaceType{
@@ -195,7 +195,7 @@ func TestDefaultAPIBinding(t *testing.T) {
 
 	updatedAPIExport := currentAPIExport.DeepCopy()
 
-	updatedAPIExport.Spec.Resources = append(apiExportCreated.Spec.Resources, apisv1alpha2.ResourceSchema{
+	updatedAPIExport.Spec.Resources = append(updatedAPIExport.Spec.Resources, apisv1alpha2.ResourceSchema{
 		Group:  "gateway.networking.k8s.io",
 		Name:   "tlsroutes",
 		Schema: "latest.tlsroutes.gateway.networking.k8s.io",

test/integration/framework/goleak.go

@@ -95,7 +95,7 @@ var (
 	// 14s as etcd sets a client request timeout of up to 7 seconds when
 	// shutting down the server and then starts shutting down everything
 	// else.
-	// A shorter timestan d would lead to false positives in the tests.
+	// A shorter timespan d would lead to false positives in the tests.
 	WaitTime = 14 * time.Second
 )