PR feedback

On-behalf-of: @SAP [email protected]

Author: xrstf

test/e2e/authorizer/authorizationorder_test.go

@@ -43,8 +43,8 @@ func TestAuthorizationOrder(t *testing.T) {
 		webhookPort := "8080"
 		ctx, cancelFunc := context.WithCancel(context.Background())
 		t.Cleanup(cancelFunc)
-		webhookStop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:allow")
-		t.Cleanup(webhookStop)
+		webhook1Stop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:allow")
+		t.Cleanup(webhook1Stop)
 
 		server, kcpClusterClient, kubeClusterClient := setupTest(t, "AlwaysAllowGroups,AlwaysAllowPaths,Webhook,RBAC", "testdata/webhook1.kubeconfig")
 
@@ -53,9 +53,9 @@ func TestAuthorizationOrder(t *testing.T) {
 		require.NoError(t, err)
 
 		// stop the webhook and switch to a deny policy
-		webhookStop()
-		webhookStop = RunWebhook(ctx, t, webhookPort, "kubernetes:authz:deny")
-		t.Cleanup(webhookStop)
+		webhook1Stop()
+		webhook2Stop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:deny")
+		t.Cleanup(webhook2Stop)
 
 		t.Log("Admin should not be allowed to list ConfigMaps.")
 		_, err = kubeClusterClient.Cluster(logicalcluster.NewPath("root")).CoreV1().ConfigMaps("default").List(ctx, metav1.ListOptions{})
@@ -70,8 +70,8 @@ func TestAuthorizationOrder(t *testing.T) {
 		webhookPort := "8081"
 		ctx, cancelFunc := context.WithCancel(context.Background())
 		t.Cleanup(cancelFunc)
-		webhookStop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:allow")
-		t.Cleanup(webhookStop)
+		webhook1Stop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:allow")
+		t.Cleanup(webhook1Stop)
 
 		server, kcpClusterClient, kubeClusterClient := setupTest(t, "Webhook,AlwaysAllowGroups,AlwaysAllowPaths,RBAC", "testdata/webhook2.kubeconfig")
 
@@ -83,9 +83,9 @@ func TestAuthorizationOrder(t *testing.T) {
 		require.NoError(t, err)
 
 		// stop the webhook and switch to a deny policy
-		webhookStop()
-		webhookStop = RunWebhook(ctx, t, webhookPort, "kubernetes:authz:deny")
-		t.Cleanup(webhookStop)
+		webhook1Stop()
+		webhook2Stop := RunWebhook(ctx, t, webhookPort, "kubernetes:authz:deny")
+		t.Cleanup(webhook2Stop)
 
 		t.Log("Admin should not be allowed now to list Logical clusters.")
 		_, err = kcpClusterClient.Cluster(logicalcluster.NewPath("root")).CoreV1alpha1().LogicalClusters().List(ctx, metav1.ListOptions{})