Skip to content

Commit bc2a3e0

Browse files
committed
improve staging modules
On-behalf-of: @SAP [email protected]
1 parent beb6b92 commit bc2a3e0

File tree

3 files changed

+15
-18
lines changed

3 files changed

+15
-18
lines changed

Makefile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@ install: require-jq require-go require-git verify-go-versions ## Install the pro
128128
done
129129
.PHONY: install
130130

131+
golangci-lint: $(GOLANGCI_LINT)
132+
.PHONY: golangci-lint
133+
131134
$(GOLANGCI_LINT):
132135
@hack/uget.sh \
133136
https://github.com/golangci/golangci-lint/releases/download/v{VERSION}/golangci-lint-{VERSION}-{GOOS}-{GOARCH}.tar.gz \

staging/src/github.com/kcp-dev/client-go/Makefile

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,17 @@ SHELL := /usr/bin/env bash -e
1717

1818
KCP_ROOT_DIR ?= $(abspath ../../../../..)
1919

20-
GO_INSTALL = $(KCP_ROOT_DIR)/hack/go-install.sh
21-
22-
TOOLS_DIR=hack/tools
20+
TOOLS_DIR = hack/tools
2321
TOOLS_GOBIN_DIR := $(KCP_ROOT_DIR)/$(TOOLS_DIR)
24-
GOBIN_DIR=$(abspath ./bin)
25-
PATH := $(GOBIN_DIR):$(TOOLS_GOBIN_DIR):$(PATH)
22+
PATH := $(TOOLS_GOBIN_DIR):$(PATH)
2623

27-
GOLANGCI_LINT_VER := v2.1.6
2824
GOLANGCI_LINT_BIN := golangci-lint
29-
GOLANGCI_LINT := $(TOOLS_GOBIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
30-
GOLANGCI_LINT_FLAGS ?=
25+
GOLANGCI_LINT := $(TOOLS_GOBIN_DIR)/$(GOLANGCI_LINT_BIN)
3126

3227
$(GOLANGCI_LINT):
33-
GOBIN=$(TOOLS_GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/v2/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
28+
make -C ../../../../.. $(GOLANGCI_LINT_BIN)
3429

35-
tools: $(CODE_GENERATOR)
30+
tools: $(CODE_GENERATOR) $(GOLANGCI_LINT)
3631
.PHONY: tools
3732

3833
codegen:

staging/src/github.com/kcp-dev/code-generator/Makefile

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,23 +15,22 @@
1515
SHELL := /usr/bin/env bash
1616

1717
KCP_ROOT_DIR ?= $(abspath ../../../../..)
18-
19-
GO_INSTALL = $(KCP_ROOT_DIR)/hack/go-install.sh
18+
UGET = $(KCP_ROOT_DIR)/hack/uget.sh
2019

2120
BUILD_DEST ?= _build
2221
BUILDFLAGS ?=
2322
CMD ?= $(notdir $(wildcard ./cmd/*))
2423

25-
TOOLS_DIR=hack/tools
26-
GOBIN_DIR := $(KCP_ROOT_DIR)/$(TOOLS_DIR)
27-
TMPDIR := $(shell mktemp -d)
24+
TOOLS_DIR = hack/tools
25+
export UGET_DIRECTORY = $(TOOLS_DIR)
26+
export UGET_CHECKSUMS = hack/tools.checksums
27+
TOOLS_GOBIN_DIR := $(KCP_ROOT_DIR)/$(TOOLS_DIR)
2828

29-
GOLANGCI_LINT_VER := v2.1.6
3029
GOLANGCI_LINT_BIN := golangci-lint
31-
GOLANGCI_LINT := $(GOBIN_DIR)/$(GOLANGCI_LINT_BIN)-$(GOLANGCI_LINT_VER)
30+
GOLANGCI_LINT := $(TOOLS_GOBIN_DIR)/$(GOLANGCI_LINT_BIN)
3231

3332
$(GOLANGCI_LINT):
34-
GOBIN=$(GOBIN_DIR) $(GO_INSTALL) github.com/golangci/golangci-lint/cmd/golangci-lint $(GOLANGCI_LINT_BIN) $(GOLANGCI_LINT_VER)
33+
make -C ../../../../.. $(GOLANGCI_LINT_BIN)
3534

3635
.PHONY: imports
3736
imports: WHAT ?=

0 commit comments

Comments
 (0)