Maintain a minimum and a build go version

Signed-off-by: Nelo-T. Wallus <[email protected]>

Author: ntnn

go.mod

@@ -1,5 +1,12 @@
 module github.com/kcp-dev/kcp
 
+// Two Go versions are maintained - the minimum supported Go version as
+// noted in the go directive and the build version used in PROW and GHA
+// jobs and Docker builds as noted in the comment.
+// The script hack/verify-go-versions.sh checks that all version
+// references across the codebase are consistent with the versions
+// maintained here.
+// go-build-version 1.23.10
 go 1.23.0
 
 require (

hack/verify-go-versions.sh

@@ -17,20 +17,62 @@
 set -e
 set -o pipefail
 
-VERSION=$(grep "go 1." go.mod | sed 's/go //' | sed 's/.0$//')
+gomod_version() {
+    awk '/^go / { print $2 }' "$1" | sed 's/.0$//'
+}
 
-grep "FROM .* docker.io/golang:" Dockerfile | { ! grep -v "${VERSION}"; } || { echo "Wrong go version in Dockerfile, expected ${VERSION}"; exit 1; }
-grep -w "go-version:" .github/workflows/*.yaml | { ! grep -v "go-version: v${VERSION}"; } || { echo "Wrong go version in .github/workflows/*.yaml, expected ${VERSION}"; exit 1; }
+minimum_go_version="$(gomod_version go.mod)"
+build_go_version="$(awk '/go-build-version/ { print $3 }' go.mod)"
+errors=0
 
-shopt -s dotglob
-# Note CONTRIBUTING.md isn't copied in the Dockerfile
-for f in docs/content/contributing/getting-started.md; do
-  grep "golang.org/doc/install" "$f" | { ! grep -v "${VERSION}"; } || { echo "Wrong go version in $f; expected ${VERSION}"; exit 1; }
+echo "Verifying minimum Go version: $minimum_go_version"
+
+for gomod in $(git ls-files '**/go.mod'); do
+    if [[ "$(gomod_version $gomod)" != "$minimum_go_version" ]]; then
+        echo "  Wrong go version in $gomod, expected $minimum_go_version"
+        errors=$((errors + 1))
+    fi
+done
+
+if ! grep "golang.org/doc/install" $(git ls-files 'docs/**/*.md') | grep -q "$minimum_go_version"; then
+    echo "  Wrong go version in docs/content/contributing/getting-started.md; expected $minimum_go_version"
+fi
+
+echo "Verifying build Go version: $build_go_version"
+
+for dockerfile in $(git ls-files Dockerfile '**/Dockerfile'); do
+    for version in $(sed -nE -e '/^FROM .*golang:/ s#^.*:([1-9.-rc]+).*$#\1#p' "$dockerfile"); do
+        if [[ "$version" != "$build_go_version" ]]; then
+            echo "  Wrong go version in $dockerfile, expected $build_go_version, found $version"
+            errors=$((errors + 1))
+        fi
+    done
 done
 
-# Check prow config
-grep "ghcr.io/kcp-dev/infra/build" ".prow.yaml" | { ! grep -v "${VERSION}"; } || { echo "Wrong go version in .prow.yaml; expected ${VERSION}"; exit 1; }
+for workflow in $(git ls-files '.github/workflows/*.yaml' '.github/workflows/*.yml'); do
+    if grep -q 'go-version-file:' "$workflow"; then
+        echo "  Workflow $workflow uses go-version-file, should use go-version instead"
+        errors=$((errors + 1))
+    fi
 
-if [ -z "${IGNORE_GO_VERSION}" ]; then
-  go version | { ! grep -v go${VERSION}; } || { echo "Unexpected go version installed, expected ${VERSION}. Use IGNORE_GO_VERSION=1 to skip this check."; exit 1; }
+    for version in $(sed -nE -e '/^  go-version: / s#^  go-version: v([1-9.-rc]+)$#\1#p' "$workflow"); do
+        if [[ "$version" != "$build_go_version" ]]; then
+            echo "  Wrong go version in $workflow, expected v${build_go_version}, found v${version}"
+            errors=$((errors + 1))
+        fi
+    done
+done
+
+for prow_image_version in $(sed -nE -e '/kcp-dev\/infra/ s#^.*:([1-9.-rc]+)-[1-9]+.*$#\1#p' .prow.yaml); do
+    if [[ "$prow_image_version" != "$build_go_version" ]]; then
+        echo "  Wrong go version in .prow.yaml, expected ${build_go_version}, found ${prow_image_version}"
+        errors=$((errors + 1))
+    fi
+done
+
+if ! go version | grep -q "go${minimum_go_version}"; then
+    echo "  Wrong go version installed, expected ${minimum_go_version}"
+    errors=$((errors + 1))
 fi
+
+exit $errors