Skip to content

Commit cee7843

Browse files
committed
mark these targets as PHONY because µget cannot (yet?) handle binaries with versions appended to them
On-behalf-of: @SAP [email protected]
1 parent 6dfddb1 commit cee7843

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

Makefile

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,24 +128,28 @@ install: require-jq require-go require-git verify-go-versions ## Install the pro
128128
done
129129
.PHONY: install
130130

131+
.PHONY: $(GOLANGCI_LINT)
131132
$(GOLANGCI_LINT):
132133
@hack/uget.sh \
133134
https://github.com/golangci/golangci-lint/releases/download/v{VERSION}/golangci-lint-{VERSION}-{GOOS}-{GOARCH}.tar.gz \
134135
${GOLANGCI_LINT_BIN} \
135136
${GOLANGCI_LINT_VER}
136137

138+
.PHONY: $(HTTEST)
137139
$(HTTEST):
138140
@hack/uget.sh \
139141
https://codeberg.org/xrstf/httest/releases/download/v{VERSION}/httest_{VERSION}_{GOOS}_{GOARCH}.tar.gz \
140142
${HTTEST_BIN} \
141143
${HTTEST_VER}
142144

145+
.PHONY: $(LOGCHECK)
143146
$(LOGCHECK):
144147
@GO_MODULE=true hack/uget.sh \
145148
sigs.k8s.io/logtools/logcheck \
146149
${LOGCHECK_BIN} \
147150
$(LOGCHECK_VER)
148151

152+
.PHONY: $(KCP_APIGEN_GEN)
149153
$(KCP_APIGEN_GEN):
150154
pushd . && cd staging/src/github.com/kcp-dev/sdk && GOBIN=$(TOOLS_GOBIN_DIR) go install ./cmd/apigen && popd
151155

@@ -205,12 +209,15 @@ vendor: ## Vendor the dependencies
205209
tools: $(GOLANGCI_LINT) $(HTTEST) $(CONTROLLER_GEN) $(KCP_APIGEN_GEN) $(YAML_PATCH) $(GOTESTSUM) ## Install tools
206210
.PHONY: tools
207211

212+
.PHONY: $(CONTROLLER_GEN)
208213
$(CONTROLLER_GEN):
209214
@UNCOMPRESSED=true hack/uget.sh https://github.com/kubernetes-sigs/controller-tools/releases/download/{VERSION}/controller-gen-{GOOS}-{GOARCH} ${CONTROLLER_GEN_BIN} $(CONTROLLER_GEN_VER) controller-gen*
210215

216+
.PHONY: $(YAML_PATCH)
211217
$(YAML_PATCH):
212218
@GO_MODULE=true hack/uget.sh github.com/pivotal-cf/yaml-patch/cmd/yaml-patch $(YAML_PATCH_BIN) $(YAML_PATCH_VER)
213219

220+
.PHONY: $(GOTESTSUM)
214221
$(GOTESTSUM):
215222
@hack/uget.sh \
216223
https://github.com/gotestyourself/gotestsum/releases/download/v{VERSION}/gotestsum_{VERSION}_{GOOS}_{GOARCH}.tar.gz \

0 commit comments

Comments
 (0)