flake: TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled

[ntnn]

Describe the bug

The test TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled has been flaking a bit recently:

    controller_test.go:171: Create a workspace without shards
    controller_test.go:171: Expect workspace to be unschedulable
    eventually.go:123: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:123
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:43
        	            				/usr/local/go/src/runtime/asm_arm64.s:1223
        	Error:      	Received unexpected error:
        	            	the server is currently unable to handle the request (get workspaces.tenancy.kcp.io steve)
        	Test:       	TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled
        	Messages:   	Error fetching object
    controller_test.go:171: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:40
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:121
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspace/controller_test.go:111
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspace/controller_test.go:171
        	Error:      	Condition never satisfied
        	Test:       	TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled
    fixture.go:525: 
        	Error Trace:	/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/server/fixture.go:525
        	            				/usr/local/go/src/testing/testing.go:1211
        	            				/usr/local/go/src/testing/testing.go:1445
        	            				/usr/local/go/src/testing/testing.go:1786
        	            				/usr/local/go/src/runtime/panic.go:636
        	            				/usr/local/go/src/testing/testing.go:1041
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:40
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/sdk/testing/helpers/eventually.go:121
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspace/controller_test.go:111
        	            				/home/prow/go/src/github.com/kcp-dev/kcp/test/e2e/reconciler/workspace/controller_test.go:171
        	Error:      	Received unexpected error:
        	            	the server is currently unable to handle the request (get workspaces.tenancy.kcp.io steve)
        	Test:       	TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled
        	Messages:   	error fetching artifact
    fixture.go:145: Gathering metrics from kcp servers...

Just from my recent issues:

• Rebase to kube 1.33.3 #3511 (comment)
• Maintain a minimum and a build go version #3515 (comment)

I know I have seen this fail more often but didn't comment it so I can't find it now.

The test has been flaking before:

• bug? flake? TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled #2603
• Test flake: TestWorkspaceController/add_a_shard_after_a_workspace_is_unschedulable,_expect_it_to_be_scheduled #688

Steps To Reproduce

Expected Behaviour

Not flaking

Additional Context

No response

[ntnn]

/kind flake