Improve version banner in our docs#3872
Merged
kcp-ci-bot merged 3 commits intokcp-dev:mainfrom Mar 2, 2026
Merged
Conversation
kcp-ci-bot
added
release-note-none
ntnn
reviewed
Mar 2, 2026
Contributor
|
LGTM label has been added. DetailsGit tree hash: 691c6a426cdb3ae2809565627fd40921f9bbda09 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I got triggered hard by our docs shifting themselves down by a few lines every time you navigate through them and load a new page. Everytime I clicked on a link, began to rea---- ah, sorry, everything just shifted down. Infuriating.
This PR moves the JS code from the page head to the end of the
<body>, which allows it to immediately get all the necessary DOM elements and inject itself into the page. This significantly reduces the likelihood of a visual tear on pageload.I also changed the background color a bit, since the contrast was very low and it was hard to read for me. The color was chosen from the
!!! noteblocks' border.Old:
New:
I also removed the explicit positioning (setting the
topCSS property) since I could not see/reproduce what this might be used for. Without it, it still looks fine in Chrome and Firefox.Lastly, since I got bit by that, too, I ran
txtidyon the docs and stripped all trailing whitespace.What Type of PR Is This?
/kind documentation
Release Notes