Merged
Conversation
On-behalf-of: @SAP christoph.mewes@sap.com
kcp-ci-bot
added
release-note-none
Contributor
|
LGTM label has been added. DetailsGit tree hash: 1ee6afa4828dd55feb4c28cf4af06639ca07201c |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ntnn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When doing the
kcprenaming mega PR, I first changed all the code and then must have manually updated some generated files. This lead to the outcome that the root-phase0 APIResourceSchemas were updated, but their name was never re-calculated and so I accidentally made a PR that tried to upgrade an APIResourceSchema in-place.I do not really understand what happened. But when you go back to ae9fdd9 and then do a
make codegen, you will see the correct new names being generated. Why themake codegencommit right after that (181f6f1) did not rename the ARS, I have no idea.So I went to ae9fdd9, did a
make codegen, stash the changes and then unstashed them on main, leading to this PR here.What Type of PR Is This?
/kind regression
Related Issue(s)
Fixes #3873
Release Notes