Skip to content

Commit 60dffe9

Browse files
committed
mtd: spinand: winbond: Fix W35N number of planes/LUN
There's been a mistake when extracting the geometry of the W35N02 and W35N04 chips from the datasheet. There is a single plane, however there are respectively 2 and 4 LUNs. They are actually referred in the datasheet as dies (equivalent of target), but as there is no die select operation and the chips only feature a single configuration register for the entire chip (instead of one per die), we can reasonably assume we are talking about LUNs and not dies. Reported-by: Andreas Dannenberg <[email protected]> Suggested-by: Vignesh Raghavendra <[email protected]> Fixes: 25e08bf ("mtd: spinand: winbond: Add support for W35N02JW and W35N04JW chips") Cc: [email protected] Signed-off-by: Miquel Raynal <[email protected]>
1 parent 635e118 commit 60dffe9

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/mtd/nand/spi/winbond.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ static const struct spinand_info winbond_spinand_table[] = {
289289
SPINAND_ECCINFO(&w35n01jw_ooblayout, NULL)),
290290
SPINAND_INFO("W35N02JW", /* 1.8V */
291291
SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xdf, 0x22),
292-
NAND_MEMORG(1, 4096, 128, 64, 512, 10, 2, 1, 1),
292+
NAND_MEMORG(1, 4096, 128, 64, 512, 10, 1, 2, 1),
293293
NAND_ECCREQ(1, 512),
294294
SPINAND_INFO_OP_VARIANTS(&read_cache_octal_variants,
295295
&write_cache_octal_variants,
@@ -298,7 +298,7 @@ static const struct spinand_info winbond_spinand_table[] = {
298298
SPINAND_ECCINFO(&w35n01jw_ooblayout, NULL)),
299299
SPINAND_INFO("W35N04JW", /* 1.8V */
300300
SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0xdf, 0x23),
301-
NAND_MEMORG(1, 4096, 128, 64, 512, 10, 4, 1, 1),
301+
NAND_MEMORG(1, 4096, 128, 64, 512, 10, 1, 4, 1),
302302
NAND_ECCREQ(1, 512),
303303
SPINAND_INFO_OP_VARIANTS(&read_cache_octal_variants,
304304
&write_cache_octal_variants,

0 commit comments

Comments
 (0)