Skip to content

Commit f0c28ac

Browse files
morbidrsakdave
authored andcommitted
btrfs: remove redundant auto reclaim log message
Remove the log message before reclaiming a chunk in btrfs_reclaim_bgs_work(). Especially with automatic block-group reclaiming these messages spam the kernel log. Note there is also a tracepoint for the same condition to ease debugging. Reviewed-by: Boris Burkov <[email protected]> Signed-off-by: Johannes Thumshirn <[email protected]> Signed-off-by: David Sterba <[email protected]>
1 parent eb2f466 commit f0c28ac

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

fs/btrfs/block-group.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1843,7 +1843,6 @@ void btrfs_reclaim_bgs_work(struct work_struct *work)
18431843
*/
18441844
list_sort(NULL, &fs_info->reclaim_bgs, reclaim_bgs_cmp);
18451845
while (!list_empty(&fs_info->reclaim_bgs)) {
1846-
u64 zone_unusable;
18471846
u64 used;
18481847
u64 reserved;
18491848
int ret = 0;
@@ -1910,16 +1909,6 @@ void btrfs_reclaim_bgs_work(struct work_struct *work)
19101909
goto next;
19111910
}
19121911

1913-
/*
1914-
* Cache the zone_unusable value before turning the block group
1915-
* to read only. As soon as the block group is read only it's
1916-
* zone_unusable value gets moved to the block group's read-only
1917-
* bytes and isn't available for calculations anymore. We also
1918-
* cache it before unlocking the block group, to prevent races
1919-
* (reports from KCSAN and such tools) with tasks updating it.
1920-
*/
1921-
zone_unusable = bg->zone_unusable;
1922-
19231912
spin_unlock(&bg->lock);
19241913
spin_unlock(&space_info->lock);
19251914

@@ -1963,12 +1952,6 @@ void btrfs_reclaim_bgs_work(struct work_struct *work)
19631952
reserved = bg->reserved;
19641953
spin_unlock(&bg->lock);
19651954

1966-
btrfs_info(fs_info,
1967-
"reclaiming chunk %llu with %llu%% used %llu%% reserved %llu%% unusable",
1968-
bg->start,
1969-
div64_u64(used * 100, bg->length),
1970-
div64_u64(reserved * 100, bg->length),
1971-
div64_u64(zone_unusable * 100, bg->length));
19721955
trace_btrfs_reclaim_block_group(bg);
19731956
ret = btrfs_relocate_chunk(fs_info, bg->start);
19741957
if (ret) {

0 commit comments

Comments
 (0)