Skip to content

Commit cd26a8c

Browse files
committed
Note why we use minCoeff in matrix_is_pos_semidef
1 parent 913df63 commit cd26a8c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/kwip-utils.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ bool
126126
matrix_is_pos_semidef(MatrixXd &mat)
127127
{
128128
VectorXd eigenvalues = mat.eigenvalues().real();
129+
// To be PSD, all eigenvalues must be greater than negative 1e-5. So check
130+
// that the smallest is (as (eigenvalues > -1e-5).all() doesn't work).
129131
return eigenvalues.minCoeff() > -1e-5;
130132
}
131133

0 commit comments

Comments
 (0)