Skip to content

Commit b7c5655

Browse files
JorTurFerrickbrouwermatchan26nusmqljameswilliams1
authored
Prepare 2.18.2 (#7299)
* fix: Correct parse error ActiveMQ (#7245) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: metricUnavailableValue parameter not working in Datadog scaler (#7241) * fix: metricUnavailableValue parameter not working in Datadog scaler The UseFiller flag was not being set correctly when metricUnavailableValue was configured. This fix distinguishes between 'not configured' and 'explicitly set to 0' by checking TriggerMetadata directly. Changes: - Set UseFiller in validateAPIMetadata() when metricUnavailableValue exists - Set UseFiller in validateClusterAgentMetadata() when metricUnavailableValue exists - Remove UseFiller logic from Validate() (responsibility moved to validate functions) - Update tests to verify UseFiller behavior with various values including 0 This allows users to explicitly set metricUnavailableValue to 0 and have it work as a fallback value, while still erroring when not configured. Fixes #7238 Signed-off-by: Hiroki Matsui <fenethtool@gmail.com> * test: cover both API and ClusterAgent modes in UseFiller test Updated TestDatadogMetadataValidateUseFiller to test both validateAPIMetadata() and validateClusterAgentMetadata() code paths. This ensures that the UseFiller flag is correctly set in both integration modes. Test cases now cover: - API mode: 5 test cases (not configured, 0, positive, negative, decimal) - Cluster Agent mode: 5 test cases (same variations) Signed-off-by: Hiroki Matsui <fenethtool@gmail.com> * refactor: use pointer type for FillValue to avoid TriggerMetadata access Changed FillValue from float64 to *float64 to distinguish between 'not configured' (nil) and 'explicitly set to any value including 0'. This addresses reviewer feedback about avoiding direct TriggerMetadata access and improves type safety and refactoring resistance. Changes: - FillValue type changed from float64 to *float64 with optional tag - validateAPIMetadata checks nil instead of TriggerMetadata map - validateClusterAgentMetadata checks nil instead of TriggerMetadata map - Dereference FillValue when returning fallback value (2 locations) - Update tests to handle pointer type with proper nil checks Signed-off-by: Hiroki Matsui <fenethtool@gmail.com> --------- Signed-off-by: Hiroki Matsui <fenethtool@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix ScaledObject pause behavior when HPA doesn't exist (#7233) When a ScaledObject has the paused annotation set before the HPA is created, the controller would fall through and create the HPA, ignoring the pause annotation. The fix writes the paused status to etcd immediately before stopping the scale loop or deleting the HPA. This prevents race conditions where concurrent reconciles triggered by HPA deletion would not see the paused status and perform redundant operations. The key insight is to establish the paused state in etcd BEFORE any operations that trigger new reconciles, ensuring subsequent reconciles see the paused status and exit early. This solution follows the approach suggested by @rickbrouwer. Fixes #7231 Signed-off-by: nusmql <nusmql@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: use TriggerError when all ScaledJob triggers fail (#7205) Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Fix transfer-hpa-ownership panic when hpa name not provided (#7260) * chore: renormalize line endings Signed-off-by: James Williams <jamesleighwilliams@gmail.com> * fix: nil pointer when transfer-hpa-ownership is true but hpa name not specified (#7254) Signed-off-by: James Williams <jamesleighwilliams@gmail.com> * update changelog Signed-off-by: James Williams <jamesleighwilliams@gmail.com> * revert vendor changes Signed-off-by: James Williams <jamesleighwilliams@gmail.com> --------- Signed-off-by: James Williams <jamesleighwilliams@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: restore HPA behavior when paused-scale-in/out annotation is deleted (#7291) When paused-scale-in or paused-scale-out annotation is deleted (not set to "false") and the corresponding selectPolicy (scaleDown.selectPolicy or scaleUp.selectPolicy) is not explicitly set in the ScaledObject spec, the HPA's SelectPolicy remains stuck at "Disabled" instead of being restored. This occurs even if other behavior fields like policies or stabilizationWindowSeconds are defined - only an explicit selectPolicy value triggers the update. Root cause: DeepDerivative treats nil as "unset" and considers it a subset of any value, so DeepDerivative(nil, Disabled) returns true, preventing the HPA update. Fix: Add explicit DeepEqual check for Behavior field, following the existing pattern used for Metrics length check. test: add e2e test for paused-scale-in annotation removal Signed-off-by: Dima Shevchuk <dshedimon@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * refactor: remove unused scaledObjectMetricSpecs variable (#7292) * refactor: remove unused scaledObjectMetricSpecs variable Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> * update CHANGELOG.md Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> --------- Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix: handle requestScaleLoop error in ScaledObject controller (#7273) * fix: handle requestScaleLoop error in ScaledObject controller Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> * chore: update CHANGELOG for PR #7273 Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> --------- Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * bump actions and go version (#7295) * bump actions and go version Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * bump deps Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update pkgs Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update tools Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * . Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix test Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix lint Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update setup-go to use go.mod version Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add nolint to exclude pulsar issues Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix devenv Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix codeql Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix splunk test Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * include job in links Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update to ubuntu-slim some runners Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update apis/keda/v1alpha1/scaledobject_webhook_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> * Update .github/workflows/scorecards.yml Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update changelog Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: Hiroki Matsui <fenethtool@gmail.com> Signed-off-by: nusmql <nusmql@gmail.com> Signed-off-by: James Williams <jamesleighwilliams@gmail.com> Signed-off-by: Dima Shevchuk <dshedimon@gmail.com> Signed-off-by: u-kai <76635578+u-kai@users.noreply.github.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Co-authored-by: Matchan <fenethtool@gmail.com> Co-authored-by: nusmql <nusmql@gmail.com> Co-authored-by: James Williams <jamesleighwilliams@gmail.com> Co-authored-by: Dima Shevchuk <dshedimon@gmail.com> Co-authored-by: Kai Udo <76635578+u-kai@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>
1 parent 3f590ba commit b7c5655

File tree

1,976 files changed

+86657
-53882
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

1,976 files changed

+86657
-53882
lines changed

‎.devcontainer/Dockerfile‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Licensed under the MIT License. See https://go.microsoft.com/fwlink/?linkid=2090316 for license information.
44
#-------------------------------------------------------------------------------------------------------------
55

6-
FROM golang:1.24.7
6+
FROM golang:1.25.5
77

88
# Avoid warnings by switching to noninteractive
99
ENV DEBIAN_FRONTEND=noninteractive
@@ -42,9 +42,9 @@ RUN apt-get update \
4242
&& go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest \
4343
&& go install github.com/mgechev/revive@latest \
4444
&& go install honnef.co/go/tools/cmd/staticcheck@latest \
45-
&& go install golang.org/x/tools/gopls@v0.18.1 \
45+
&& go install golang.org/x/tools/gopls@latest \
4646
# Protocol Buffer Compiler
47-
&& PROTOC_VERSION=29.3 \
47+
&& PROTOC_VERSION=33.2 \
4848
&& case $(dpkg --print-architecture) in \
4949
"amd64") PROTOC_ARCH="x86_64" ;; \
5050
"arm64") PROTOC_ARCH="aarch_64" ;; \

‎.github/workflows/auto-add-issues-to-project.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ permissions:
99

1010
jobs:
1111
track_issue:
12-
runs-on: ubuntu-latest
12+
runs-on: ubuntu-slim
1313
steps:
1414
- name: Get project data
1515
env:

‎.github/workflows/fossa.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ jobs:
2020
build:
2121
runs-on: ubuntu-latest
2222
steps:
23-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
24-
- uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
23+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
24+
- uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
2525
with:
26-
go-version: "1.24"
26+
go-version-file: "go.mod"
2727
- run: go version
2828
- name: Get branch name
2929
id: branch-name

‎.github/workflows/main-build.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
id-token: write # needed for signing the images with GitHub OIDC Token **not production ready**
1717

1818
# keda-tools is built from github.com/test-tools/tools/Dockerfile
19-
container: ghcr.io/kedacore/keda-tools:1.24.7
19+
container: ghcr.io/kedacore/keda-tools:1.25.5
2020
steps:
2121
- name: Check out code
22-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
22+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
2323
with:
2424
fetch-depth: 1
2525

@@ -44,7 +44,7 @@ jobs:
4444
key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}
4545

4646
- name: Go modules sync
47-
run: go mod tidy -compat=1.24
47+
run: go mod tidy -compat=1.25
4848

4949
- name: Test
5050
run: make test

‎.github/workflows/pr-bot-welcome.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ permissions:
1313
jobs:
1414
pr_bot:
1515
name: PR Bot
16-
runs-on: ubuntu-latest
16+
runs-on: ubuntu-slim
1717
steps:
1818
- name: 'Comment on PR'
1919
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7

‎.github/workflows/pr-e2e-checker.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ concurrency:
1919
jobs:
2020
e2e-checker:
2121
name: label checker
22-
runs-on: ubuntu-latest
22+
runs-on: ubuntu-slim
2323
if: github.event.label.name == 'skip-e2e'
2424
steps:
2525
- uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2

‎.github/workflows/pr-e2e-creator.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ concurrency:
1818
jobs:
1919
check-creator:
2020
name: check-creator
21-
runs-on: ubuntu-latest
21+
runs-on: ubuntu-slim
2222
steps:
2323
- uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2
2424
name: Enqueue e2e

‎.github/workflows/pr-e2e.yml‎

Lines changed: 28 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ jobs:
1212
triage:
1313
runs-on: ubuntu-latest
1414
name: Comment evaluate
15-
container: ghcr.io/kedacore/keda-tools:1.24.7
15+
container: ghcr.io/kedacore/keda-tools:1.25.5
1616
outputs:
1717
run-e2e: ${{ startsWith(github.event.comment.body,'/run-e2e') && steps.checkUserMember.outputs.isTeamMember == 'true' }}
1818
pr_num: ${{ steps.parser.outputs.pr_num }}
1919
image_tag: "pr-${{ steps.parser.outputs.pr_num }}-${{ steps.parser.outputs.commit_sha }}"
2020
commit_sha: ${{ steps.parser.outputs.commit_sha }}
2121
steps:
22-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
22+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
2323

2424
- uses: tspascoal/get-user-teams-membership@57e9f42acd78f4d0f496b3be4368fc5f62696662 # v3.0.0
2525
id: checkUserMember
@@ -71,7 +71,7 @@ jobs:
7171
needs: triage
7272
runs-on: ARM64
7373
name: Build images
74-
container: ghcr.io/kedacore/keda-tools:1.24.7
74+
container: ghcr.io/kedacore/keda-tools:1.25.5
7575
if: needs.triage.outputs.run-e2e == 'true'
7676
steps:
7777
- name: Set status in-progress
@@ -81,7 +81,7 @@ jobs:
8181
sha: ${{ needs.triage.outputs.commit_sha }}
8282
name: ${{ env.E2E_CHECK_NAME }}
8383
status: in_progress
84-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
84+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
8585

8686
- name: Set status in-progress
8787
uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2
@@ -90,7 +90,7 @@ jobs:
9090
sha: ${{ needs.triage.outputs.commit_sha }}
9191
name: ${{ env.ARM_SMOKE_CHECK_NAME }}
9292
status: in_progress
93-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
93+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
9494

9595
- name: Set status in-progress
9696
uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2
@@ -99,9 +99,9 @@ jobs:
9999
sha: ${{ needs.triage.outputs.commit_sha }}
100100
name: ${{ env.S390X_SMOKE_CHECK_NAME }}
101101
status: in_progress
102-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
102+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
103103

104-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
104+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
105105

106106
- name: Register workspace path
107107
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
@@ -144,7 +144,7 @@ jobs:
144144
sha: ${{ needs.triage.outputs.commit_sha }}
145145
name: ${{ env.E2E_CHECK_NAME }}
146146
conclusion: failure
147-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
147+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
148148

149149
- name: Set status failure
150150
uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2
@@ -154,7 +154,7 @@ jobs:
154154
sha: ${{ needs.triage.outputs.commit_sha }}
155155
name: ${{ env.ARM_SMOKE_CHECK_NAME }}
156156
status: failure
157-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
157+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
158158

159159
- name: Set status failure
160160
uses: LouisBrunner/checks-action@6b626ffbad7cc56fd58627f774b9067e6118af23 # v2
@@ -164,7 +164,7 @@ jobs:
164164
sha: ${{ needs.triage.outputs.commit_sha }}
165165
name: ${{ env.S390X_SMOKE_CHECK_NAME }}
166166
status: failure
167-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
167+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
168168

169169
- name: Exit on failure
170170
if: steps.regex-validation.outcome != 'success'
@@ -193,7 +193,7 @@ jobs:
193193
needs: [triage, build-test-images]
194194
runs-on: e2e
195195
name: Execute e2e tests
196-
container: ghcr.io/kedacore/keda-tools:1.24.7
196+
container: ghcr.io/kedacore/keda-tools:1.25.5
197197
if: needs.triage.outputs.run-e2e == 'true'
198198
steps:
199199
- name: Set status in-progress
@@ -203,9 +203,9 @@ jobs:
203203
sha: ${{ needs.triage.outputs.commit_sha }}
204204
name: ${{ env.E2E_CHECK_NAME }}
205205
status: in_progress
206-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
206+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
207207

208-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
208+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
209209

210210
- name: Register workspace path
211211
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
@@ -279,7 +279,7 @@ jobs:
279279
sha: ${{ needs.triage.outputs.commit_sha }}
280280
name: ${{ env.E2E_CHECK_NAME }}
281281
conclusion: success
282-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
282+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
283283

284284
- name: React to comment with failure
285285
uses: dkershner6/reaction-action@97ede302a1b145b3739dec3ca84a489a34ef48b5 # v2
@@ -297,7 +297,7 @@ jobs:
297297
sha: ${{ needs.triage.outputs.commit_sha }}
298298
name: ${{ env.E2E_CHECK_NAME }}
299299
conclusion: failure
300-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
300+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
301301

302302
- name: Upload test logs
303303
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
@@ -319,12 +319,12 @@ jobs:
319319
sha: ${{ needs.triage.outputs.commit_sha }}
320320
name: ${{ env.ARM_SMOKE_CHECK_NAME }}
321321
status: in_progress
322-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
322+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
323323

324324
- name: Setup Go
325-
uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
325+
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
326326
with:
327-
go-version: "1.24"
327+
go-version-file: "go.mod"
328328

329329
- name: Install prerequisites
330330
run: |
@@ -334,12 +334,12 @@ jobs:
334334
DEBIAN_FRONTEND: noninteractive
335335

336336
- name: Check out code
337-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
337+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
338338
with:
339339
fetch-depth: 1
340340

341341
- name: Create k8s ${{ inputs.kubernetesVersion }} Kind Cluster
342-
uses: helm/kind-action@0025e74a8c7512023d06dc019c617aa3cf561fde # v1.10.0
342+
uses: helm/kind-action@92086f6be054225fa813e0a4b13787fc9088faab # v1.13.0
343343
with:
344344
node_image: kindest/node:v1.32.0@sha256:c48c62eac5da28cdadcf560d1d8616cfa6783b58f0d94cf63ad1bf49600cb027
345345
cluster_name: ${{ runner.name }}
@@ -368,7 +368,7 @@ jobs:
368368
sha: ${{ needs.triage.outputs.commit_sha }}
369369
name: ${{ env.ARM_SMOKE_CHECK_NAME }}
370370
conclusion: success
371-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
371+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
372372

373373
- name: React to comment with failure
374374
uses: dkershner6/reaction-action@97ede302a1b145b3739dec3ca84a489a34ef48b5 # v2
@@ -386,7 +386,7 @@ jobs:
386386
sha: ${{ needs.triage.outputs.commit_sha }}
387387
name: ${{ env.ARM_SMOKE_CHECK_NAME }}
388388
conclusion: failure
389-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
389+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
390390

391391
- name: Upload test logs
392392
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
@@ -408,12 +408,12 @@ jobs:
408408
sha: ${{ needs.triage.outputs.commit_sha }}
409409
name: ${{ env.S390X_SMOKE_CHECK_NAME }}
410410
status: in_progress
411-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
411+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
412412

413413
- name: Setup Go
414-
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5
414+
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
415415
with:
416-
go-version: "1.24"
416+
go-version-file: "go.mod"
417417

418418
- name: Install prerequisites
419419
run: |
@@ -423,7 +423,7 @@ jobs:
423423
DEBIAN_FRONTEND: noninteractive
424424

425425
- name: Check out code
426-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
426+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
427427
with:
428428
fetch-depth: 1
429429

@@ -464,7 +464,7 @@ jobs:
464464
sha: ${{ needs.triage.outputs.commit_sha }}
465465
name: ${{ env.S390X_SMOKE_CHECK_NAME }}
466466
conclusion: success
467-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
467+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
468468

469469
- name: React to comment with failure
470470
uses: dkershner6/reaction-action@97ede302a1b145b3739dec3ca84a489a34ef48b5 # v2
@@ -482,7 +482,7 @@ jobs:
482482
sha: ${{ needs.triage.outputs.commit_sha }}
483483
name: ${{ env.S390X_SMOKE_CHECK_NAME }}
484484
conclusion: failure
485-
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
485+
details_url: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}/job/${{job.check_run_id}}
486486

487487
- name: Remove Kubernetes
488488
run: |

‎.github/workflows/pr-notify.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ on:
44

55
jobs:
66
assign_reviewer:
7-
runs-on: ARM64
7+
runs-on: ubuntu-slim
88
steps:
99
- uses: shufo/auto-assign-reviewer-by-files@0a7fae44d02e841755d0caaac2ef05ad12a3bbc9 # v1.2.1
1010
with:

‎.github/workflows/pr-validation.yml‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: validate - ${{ matrix.name }}
1212
runs-on: ${{ matrix.runner }}
1313
container:
14-
image: ghcr.io/kedacore/keda-tools:1.24.7
14+
image: ghcr.io/kedacore/keda-tools:1.25.5
1515
volumes:
1616
- /usr:/host/usr
1717
- /opt:/host/opt
@@ -38,7 +38,7 @@ jobs:
3838
rm -rf /host/opt/ghc
3939
4040
- name: Check out code
41-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
41+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
4242
with:
4343
fetch-depth: 1
4444

@@ -72,7 +72,7 @@ jobs:
7272
key: ${{ runner.os }}-go-build-cache-${{ hashFiles('**/go.sum') }}
7373

7474
- name: Go modules sync
75-
run: go mod tidy -compat=1.24
75+
run: go mod tidy -compat=1.25
7676

7777
- name: Verify generated Clientset is up to date
7878
run: make clientset-verify
@@ -106,7 +106,7 @@ jobs:
106106
pull-requests: read # for dorny/paths-filter to read pull requests
107107
name: validate-dockerfiles - ${{ matrix.name }}
108108
runs-on: ${{ matrix.runner }}
109-
container: ghcr.io/kedacore/keda-tools:1.24.7
109+
container: ghcr.io/kedacore/keda-tools:1.25.5
110110
strategy:
111111
matrix:
112112
include:
@@ -118,7 +118,7 @@ jobs:
118118
name: s390x
119119
steps:
120120
- name: Check out code
121-
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
121+
uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
122122
with:
123123
fetch-depth: 1
124124

@@ -142,7 +142,7 @@ jobs:
142142
pull-requests: read # for dorny/paths-filter to read pull requests
143143
name: Validate dev-container - ${{ matrix.name }}
144144
runs-on: ${{ matrix.runner }}
145-
container: ghcr.io/kedacore/keda-tools:1.24.7
145+
container: ghcr.io/kedacore/keda-tools:1.25.5
146146
strategy:
147147
matrix:
148148
include:
@@ -153,7 +153,7 @@ jobs:
153153
- runner: s390x
154154
name: s390x
155155
steps:
156-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
156+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
157157

158158
- name: Register workspace path
159159
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
@@ -173,13 +173,13 @@ jobs:
173173
name: Static Checks
174174
runs-on: ubuntu-latest
175175
steps:
176-
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
177-
- uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
176+
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
177+
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
178178
with:
179179
python-version: 3.x
180-
- uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
180+
- uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # v6.1.0
181181
with:
182-
go-version: "1.24"
182+
go-version-file: "go.mod"
183183
- uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
184184

185185
trivy-scan:

0 commit comments

Comments
 (0)