[ET-VK] Removing descriptor pool intialization from DescriptorPool ctor.

Pull Request resolved: pytorch/executorch#10777

Descriptor pool is initialized with proper capacity while ComputeGraph is build, in ComputeGraph::prepare function.
Thus, initializing descriptor pool in constructor just add throwaway work.

Differential Revision: [D74347030](https://our.internmc.facebook.com/intern/diff/D74347030/)
ghstack-source-id: 283034826

Author: trivedivivek

backends/vulkan/runtime/api/Context.cpp

@@ -235,15 +235,6 @@ Context* context() {
           8u, // cmdPoolBatchSize
       };
 
-      const vkapi::DescriptorPoolConfig descriptor_pool_config{
-          VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorPoolMaxSets
-          VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorUniformBufferCount
-          VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorStorageBufferCount
-          VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorCombinedSamplerCount
-          VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorStorageImageCount
-          32u, // descriptorPileSizes
-      };
-
       const vkapi::QueryPoolConfig query_pool_config{
           VULKAN_QUERY_POOL_SIZE, // maxQueryCount
           256u, // initialReserveSize
@@ -252,7 +243,7 @@ Context* context() {
       const ContextConfig config{
           cmd_submit_frequency,
           cmd_config,
-          descriptor_pool_config,
+          {},
           query_pool_config,
       };
 
@@ -266,6 +257,17 @@ Context* context() {
   return context.get();
 }
 
+vkapi::DescriptorPoolConfig default_descriptor_pool_config() {
+  return {
+      VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorPoolMaxSets
+      VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorUniformBufferCount
+      VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorStorageBufferCount
+      VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorCombinedSamplerCount
+      VULKAN_DESCRIPTOR_POOL_SIZE, // descriptorStorageImageCount
+      32u, // descriptorPileSizes
+  };
+}
+
 #ifdef VULKAN_DEBUG
 
 #ifdef VK_KHR_pipeline_executable_properties

backends/vulkan/runtime/api/Context.h

@@ -267,6 +267,8 @@ bool available();
 // a static local variable.
 Context* context();
 
+vkapi::DescriptorPoolConfig default_descriptor_pool_config();
+
 namespace detail {
 
 inline void arg_is_empty(

backends/vulkan/runtime/vk_api/Descriptor.cpp

@@ -269,11 +269,7 @@ DescriptorPool::DescriptorPool(
       pool_(VK_NULL_HANDLE),
       config_(config),
       mutex_{},
-      piles_{} {
-  if (config.descriptor_pool_max_sets > 0) {
-    init(config);
-  }
-}
+      piles_{} {}
 
 DescriptorPool::~DescriptorPool() {
   if (pool_ == VK_NULL_HANDLE) {

backends/vulkan/test/vulkan_compute_api_test.cpp

@@ -87,6 +87,9 @@ class VulkanComputeAPITest : public ::testing::Test {
   void SetUp() override {
     // Make sure we are starting with a clean slate
     EXPECT_TRUE(get_vma_allocation_count() == 0);
+    if (!context()->descriptor_pool()) {
+      context()->descriptor_pool().init(default_descriptor_pool_config());
+    }
   }
 
   void TearDown() override {