Return retained objects from toNSArray.

Differential Revision: D76491604

Pull Request resolved: pytorch/executorch#11629

Author: shoumikhin

extension/apple/ExecuTorch/Exported/ExecuTorchTensor.mm

@@ -347,7 +347,7 @@ - (instancetype)initWithScalars:(NSArray<NSNumber *> *)scalars
   for (NSUInteger index = 0; index < count; ++index) {
     ET_SWITCH_REALHBBF16_AND_UINT_TYPES(
       static_cast<ScalarType>(dataType), nil, "initWithScalars", CTYPE, [&] {
-        reinterpret_cast<CTYPE *>(data.data())[index] = utils::extractValue<CTYPE>(scalars[index]);
+        reinterpret_cast<CTYPE *>(data.data())[index] = utils::toType<CTYPE>(scalars[index]);
       }
     );
   }
@@ -659,7 +659,7 @@ + (instancetype)fullTensorWithShape:(NSArray<NSNumber *> *)shape
   Scalar fillValue;
   ET_SWITCH_REALHBBF16_AND_UINT_TYPES(
     static_cast<ScalarType>(dataType), nil, "fullTensor", CTYPE, [&] {
-      fillValue = utils::extractValue<CTYPE>(scalar);
+      fillValue = utils::toType<CTYPE>(scalar);
     }
   );
   auto tensor = full_strided(

extension/apple/ExecuTorch/Internal/ExecuTorchUtils.h

@@ -33,7 +33,7 @@ ScalarType deduceType(NSNumber *number);
  * @return The value converted to type T.
  */
 template <typename T>
-T extractValue(NSNumber *number) {
+T toType(NSNumber *number) {
   ET_CHECK_MSG(!(isFloatingType(deduceType(number)) &&
     isIntegralType(CppTypeToScalarType<T>::value, true)),
     "Cannot convert floating point to integral type");
@@ -87,7 +87,7 @@ std::vector<T> toVector(NSArray<NSNumber *> *array) {
   std::vector<T> vector;
   vector.reserve(array.count);
   for (NSNumber *number in array) {
-    vector.push_back(extractValue<T>(number));
+    vector.push_back(toType<T>(number));
   }
   return vector;
 }
@@ -108,10 +108,11 @@ constexpr bool isNSNumberWrapable =
  * @return An NSArray populated with NSNumber objects representing the container's items.
  */
 template <typename Container>
+NS_RETURNS_RETAINED
 NSArray<NSNumber *> *toNSArray(const Container &container) {
   static_assert(isNSNumberWrapable<typename Container::value_type>, "Invalid container value type");
   const NSUInteger count = std::distance(std::begin(container), std::end(container));
-  NSMutableArray<NSNumber *> *array = [NSMutableArray arrayWithCapacity:count];
+  NSMutableArray<NSNumber *> *array = [[NSMutableArray alloc] initWithCapacity:count];
   for (const auto &item : container) {
     [array addObject:@(item)];
   }