Skip to content

Commit 301f644

Browse files
committed
Make sure to use the explicit version for Kedify KEDA & install OTel scaler to keda ns
Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
1 parent bef0bfa commit 301f644

File tree

3 files changed

+25
-7
lines changed

3 files changed

+25
-7
lines changed

examples/dapr/README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ kubectl rollout status -n dapr-system deploy/dapr-sidecar-injector
3434

3535
Deploy this scaler and OTel collector that forwards one whitelisted metric:
3636
```bash
37-
cat <<VALUES | helm upgrade -i kedify-otel oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 -f -
37+
cat <<VALUES | helm upgrade -i keda-otel-scaler -nkeda oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 --create-namespace -f -
3838
opentelemetry-collector:
3939
alternateConfig:
4040
processors:
@@ -70,9 +70,15 @@ Deploy Kedify KEDA:
7070
```bash
7171
helm repo add kedify https://kedify.github.io/charts
7272
helm repo update kedify
73-
helm upgrade -i keda kedify/keda --namespace keda --create-namespace --version v2.16.0-1
73+
helm upgrade -i keda kedify/keda --namespace keda --version vX.Y.Z-n
7474
```
7575

76+
> [!TIP]
77+
> Find out the latest version of Kedify KEDA (the "`X.Y.Z-n`") at [releases](https://github.com/kedify/charts/releases) page or by running:
78+
> ```bash
79+
> curl -s https://api.github.com/repos/kedify/charts/releases | jq -r '[.[].tag_name | select(. | startswith("keda/")) | sub("^keda/"; "")] | first'
80+
> ```
81+
7682
Wait for all the deployment to become ready
7783
```bash
7884
for d in nodeapp pythonapp otelcol otel-add-on-scaler ; do

examples/metric-pull/README.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ open http://localhost:8181/metrics
2727

2828
Install this addon:
2929
```bash
30-
helm upgrade -i kedify-otel oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 -f scaler-with-collector-pull-values.yaml
30+
helm upgrade -i keda-otel-scaler -nkeda oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 --create-namespace -f scaler-with-collector-pull-values.yaml
3131
```
3232

3333
Note the following section in the helm chart values that configures the OTel collector to scrape targets:
@@ -73,9 +73,15 @@ We set these two annotation in our service for podinfo [here](./podinfo-values.y
7373

7474
Install KEDA by Kedify.io:
7575
```bash
76-
helm upgrade -i keda kedify/keda --namespace keda --create-namespace
76+
helm upgrade -i keda kedify/keda --namespace keda --version vX.Y.Z-n
7777
```
7878

79+
> [!TIP]
80+
> Find out the latest version of Kedify KEDA (the "`X.Y.Z-n`") at [releases](https://github.com/kedify/charts/releases) page or by running:
81+
> ```bash
82+
> curl -s https://api.github.com/repos/kedify/charts/releases | jq -r '[.[].tag_name | select(. | startswith("keda/")) | sub("^keda/"; "")] | first'
83+
> ```
84+
7985
Create `ScaledObject`:
8086
```bash
8187
kubectl apply -f podinfo-so.yaml
@@ -100,4 +106,4 @@ watch kubectl get pods -A
100106
Once finished, clean the cluster:
101107
```bash
102108
k3d cluster delete metric-pull
103-
```
109+
```

examples/metric-push/README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ open http://localhost:8080
2828

2929
Install this addon:
3030
```bash
31-
helm upgrade -i kedify-otel oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 -f scaler-only-push-values.yaml
31+
helm upgrade -i keda-otel-scaler oci://ghcr.io/kedify/charts/otel-add-on --version=v0.1.3 --create-namespace -f scaler-only-push-values.yaml
3232
```
3333

3434
In this scenario, we don't install OTel collector using the `kedify-otel/otel-add-on` helm chart, because
@@ -53,9 +53,15 @@ instead we go w/ simple (w/o filtering):
5353

5454
Install KEDA by Kedify.io:
5555
```bash
56-
helm upgrade -i keda kedify/keda --namespace keda --create-namespace
56+
helm upgrade -i keda kedify/keda --namespace keda --version vX.Y.Z-n
5757
```
5858

59+
> [!TIP]
60+
> Find out the latest version of Kedify KEDA (the "`X.Y.Z-n`") at [releases](https://github.com/kedify/charts/releases) page or by running:
61+
> ```bash
62+
> curl -s https://api.github.com/repos/kedify/charts/releases | jq -r '[.[].tag_name | select(. | startswith("keda/")) | sub("^keda/"; "")] | first'
63+
> ```
64+
5965
We will be scaling two microservices for this application, first let's check what metrics are there in shipped
6066
[grafana](http://localhost:8080/grafana/explore?schemaVersion=1&panes=%7B%222n3%22:%7B%22datasource%22:%22webstore-metrics%22,%22queries%22:%5B%7B%22refId%22:%22A%22,%22expr%22:%22app_frontend_requests_total%22,%22range%22:true,%22instant%22:true,%22datasource%22:%7B%22type%22:%22prometheus%22,%22uid%22:%22webstore-metrics%22%7D,%22editorMode%22:%22code%22,%22legendFormat%22:%22__auto%22,%22useBackend%22:false,%22disableTextWrap%22:false,%22fullMetaSearch%22:false,%22includeNullMetadata%22:true%7D%5D,%22range%22:%7B%22from%22:%22now-1h%22,%22to%22:%22now%22%7D%7D%7D&orgId=1).
6167

0 commit comments

Comments
 (0)