fix otel-operator demo

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>

Author: jkremser

examples/metric-pull/podinfo-so.yaml

@@ -11,7 +11,7 @@ spec:
         scalerAddress: "keda-otel-scaler.keda.svc:4318"
         metricQuery: "avg(http_request_duration_seconds_count{path=delay, method=GET, status=200})"
         operationOverTime: "rate"
-        targetValue: "10"
+        targetValue: "2"
         clampMax: "600"
   minReplicaCount: 1
   maxReplicaCount: 3

examples/metric-pull/setup.sh

@@ -27,7 +27,7 @@ kubectl rollout status -n keda --timeout=300s deploy/keda-otel-scaler
 kubectl rollout status --timeout=300s deploy/podinfo
 
 # create scaled objects
-kubectl apply -f podinfo-so.yaml
+kubectl apply -f ${DIR}/podinfo-so.yaml
 
 # create some traffic
 (hey -n 7000 -z 180s http://localhost:8181/delay/2 &> /dev/null)&

examples/otel-operator/setup.sh

@@ -1,11 +1,11 @@
 #!/bin/bash
 DIR="${DIR:-$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )}"
 
-export PR_BRANCH=
-export GH_PAT=
+#export PR_BRANCH=
+#export GH_PAT=
 
 command -v figlet &> /dev/null && figlet OTel Operator + GitHub receiver
-[ -z "${PR_BRANCH}" ] && echo "Set BRANCH env variable to a branch name from which a PR is opened against kedify/otel-add-on repo" && exit 1
+[ -z "${PR_BRANCH}" ] && echo "Set PR_BRANCH env variable to a branch name from which a PR is opened against kedify/otel-add-on repo" && exit 1
 [ -z "${GH_PAT}" ] && echo "Set GH_PAT env variable to a PAT token that has read permissions for content on kedify/otel-add-on repo"  && exit 1
 
 # setup helm repos
@@ -33,7 +33,7 @@ for d in \
   keda-operator-metrics-apiserver \
   otel-operator \
   keda-otel-scaler \
-  otel-add-on-otc-collector ; do
+  otel-add-on-collector ; do
     kubectl rollout status -n keda --timeout=600s deploy/${d}
   done
 

examples/otel-operator/so.yaml

@@ -16,12 +16,14 @@ spec:
         targetValue: "100"
         clampMin: "0"
         clampMax: "300"
-        operationOverTime: "max"
+        operationOverTime: "last_one"
   maxReplicaCount: 3
+  minReplicaCount: 1
   advanced:
     horizontalPodAutoscalerConfig:
       behavior:
         scaleDown:
           stabilizationWindowSeconds: 1
         scaleUp:
           stabilizationWindowSeconds: 10
+

helmchart/otel-add-on/templates/NOTES.txt

@@ -41,6 +41,7 @@ Following components were installed:
 
 Architecture:
 {{- $char := "" -}}
+{{- $isAnySidecar := false -}}
 {{- $m := "" -}}
 {{- if .Values.otelOperator.enabled }}
                    ┏━━━━┓
@@ -72,9 +73,13 @@ Architecture:
 {{- printf "\n" -}}
 {{- range $collectors }}
 {{- $m = .mode -}}
-{{- if and .targetAllocatorEnabled (eq .mode "sidecar") -}}
+
+{{- if eq .mode "sidecar" -}}
+{{- $isAnySidecar = true -}}
+{{- if .targetAllocatorEnabled -}}
 {{- $m = "statefulset" -}}
 {{- end -}}
+{{- end -}}
 {{- printf "   │ %-13s│    " (printf "•%s" ($m | trunc 11)) -}}
 {{- end }}
 {{- printf "\n" -}}
@@ -108,3 +113,9 @@ Architecture:
 {{- if $collectors -}}{{- printf "     " -}}{{- end -}}
 {{- printf "  ╰─────────────────────╯         ╰╶╶╶╶╶╶╯\n" -}}
 {{- end }}
+
+{{- if and $isAnySidecar (or (not .Values.otelOperator.admissionWebhooks.create) (eq .Values.otelOperator.manager.env.ENABLE_WEBHOOKS "false")) }}
+!!! WARNING !!!
+sidecar injection is not going to work without enabling the mutating webhooks,
+use helm ... -f https://raw.githubusercontent.com/kedify/otel-add-on/refs/heads/main/helmchart/otel-add-on/enable-operator-hooks-values.yaml
+{{- end }}