Merge pull request #226 from keep-network/batched-phased-escrow-deploy

BatchedPhasedEscrow: final deployment script updates

Closes #220 

During the work on this PR I updated the deployment scenario in #200 and inspected all deployment scripts. The deployment script code should now reflect the scenario from #200 1:1.

The following changes to the deployment scripts were applied:
- `BatchedPhasedEscrow` is deployed
- `CoveragePoolBeneficiary` is approved as a beneficiary in `BatchedPhasedEscrow`
- `CoveragePoolBeneficiary`'s ownership is transferred to `BatchedPhasedEscrow`
- `BatchedPhasedEscrow`'s drawee role is transferred to Threshold Council
- `BatchedPhasedEscrow`'s ownership is transferred to Threshold Council

Also, Hardhat network config for `mainnet` was added and the Treasury Guild address was set.

Accidentally, I noticed the change from #225 broke the `README` structure. I fixed it in 8707a5b.

**Testing**

This PR was tested by commenting out all `func.skip` occurrences in the deployment scripts, and running `FORKING_URL="..." yarn deploy --network hardhat`. To make it work, you also need to uncomment this line:
https://github.com/keep-network/coverage-pools/blob/0eab64d27020633620ed0a36e89bd92553ab5368/hardhat.config.ts#L87

Author: nkuba

README.adoc

@@ -102,6 +102,7 @@ As a workaround, we advise changing Git configuration to use `https://` protocol
 instead of `git://` by executing:
 ```
 git config --global url."https://".insteadOf git://
+```
 
 === Test contracts
 

deploy/04_deploy_batched_phased_escrow.ts

@@ -0,0 +1,31 @@
+import { HardhatRuntimeEnvironment } from "hardhat/types"
+import { DeployFunction } from "hardhat-deploy/types"
+
+const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
+  const { getNamedAccounts, deployments } = hre
+  const { deployer } = await getNamedAccounts()
+
+  const T = await deployments.get("T")
+
+  const BatchedPhasedEscrow = await deployments.deploy("BatchedPhasedEscrow", {
+    contract: "BatchedPhasedEscrow",
+    from: deployer,
+    args: [T.address],
+    log: true,
+  })
+
+  if (hre.network.tags.tenderly) {
+    await hre.tenderly.verify({
+      name: "BatchedPhasedEscrow",
+      address: BatchedPhasedEscrow.address,
+    })
+  }
+}
+
+export default func
+
+func.tags = ["BatchedPhasedEscrow"]
+func.dependencies = ["T"]
+func.skip = async function (hre: HardhatRuntimeEnvironment): Promise<boolean> {
+  return hre.network.name !== "mainnet"
+}

…y/04_deploy_coverage_pool_beneficiary.ts …y/05_deploy_coverage_pool_beneficiary.tsdeploy/04_deploy_coverage_pool_beneficiary.ts renamed to deploy/05_deploy_coverage_pool_beneficiary.ts deploy/04_deploy_coverage_pool_beneficiary.ts renamed to deploy/05_deploy_coverage_pool_beneficiary.ts

@@ -3,11 +3,11 @@ import { DeployFunction } from "hardhat-deploy/types"
 
 const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
   const { getNamedAccounts, deployments, helpers } = hre
-  const { read } = deployments
+  const { execute, read } = deployments
   const { deployer, rewardManager } = await getNamedAccounts()
 
   const T = await deployments.get("T")
-  // const BatchedPhasedEscrow = await deployments.get("BatchedPhasedEscrow")
+  const BatchedPhasedEscrow = await deployments.get("BatchedPhasedEscrow")
 
   const RewardsPoolAddress = await read("AssetPool", "rewardsPool")
 
@@ -28,13 +28,18 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
     })
   }
 
-  // TODO: depends on https://github.com/keep-network/coverage-pools/issues/220
-  //       and transfer the ownership
-  // await helpers.ownable.transferOwnership(
-  //   "CoveragePoolBeneficiary",
-  //   BatchedPhasedEscrow.address,
-  //   deployer
-  // )
+  await execute(
+    "BatchedPhasedEscrow",
+    { from: deployer, log: true },
+    "approveBeneficiary",
+    CoveragePoolBeneficiary.address
+  )
+
+  await helpers.ownable.transferOwnership(
+    "CoveragePoolBeneficiary",
+    BatchedPhasedEscrow.address,
+    deployer
+  )
 
   await helpers.ownable.transferOwnership(
     "RewardsPool",
@@ -46,7 +51,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
 export default func
 
 func.tags = ["CoveragePoolBeneficiary"]
-func.dependencies = ["T", "AssetPool"]
+func.dependencies = ["T", "BatchedPhasedEscrow", "AssetPool"]
 func.skip = async function (hre: HardhatRuntimeEnvironment): Promise<boolean> {
   return hre.network.name !== "mainnet"
 }

deploy/05_approve_treasury_guild.ts deploy/06_approve_treasury_guild.tsdeploy/05_approve_treasury_guild.ts renamed to deploy/06_approve_treasury_guild.ts

@@ -2,8 +2,22 @@ import { HardhatRuntimeEnvironment } from "hardhat/types"
 import { DeployFunction } from "hardhat-deploy/types"
 
 const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
-  const { getNamedAccounts, helpers } = hre
+  const { getNamedAccounts, deployments, helpers } = hre
   const { deployer, thresholdCouncil } = await getNamedAccounts()
+  const { execute } = deployments
+
+  await execute(
+    "BatchedPhasedEscrow",
+    { from: deployer, log: true },
+    "setDrawee",
+    thresholdCouncil
+  )
+
+  await helpers.ownable.transferOwnership(
+    "BatchedPhasedEscrow",
+    thresholdCouncil,
+    deployer
+  )
 
   await helpers.ownable.transferOwnership(
     "CoveragePool",
@@ -15,7 +29,7 @@ const func: DeployFunction = async function (hre: HardhatRuntimeEnvironment) {
 export default func
 
 func.tags = ["TransferOwnership"]
-func.dependencies = ["CoveragePool"]
+func.dependencies = ["BatchedPhasedEscrow", "CoveragePool"]
 func.runAtTheEnd = true
 func.skip = async function (hre: HardhatRuntimeEnvironment): Promise<boolean> {
   return hre.network.name !== "mainnet"

…oy/06_transfer_ownership_to_t_council.ts …oy/07_transfer_ownership_to_t_council.tsdeploy/06_transfer_ownership_to_t_council.ts renamed to deploy/07_transfer_ownership_to_t_council.ts deploy/06_transfer_ownership_to_t_council.ts renamed to deploy/07_transfer_ownership_to_t_council.ts

@@ -51,6 +51,14 @@ const config: HardhatUserConfig = {
         : undefined,
       tags: ["tenderly"],
     },
+    mainnet: {
+      url: process.env.CHAIN_API_URL || "",
+      chainId: 1,
+      accounts: process.env.CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY
+        ? [process.env.CONTRACT_OWNER_ACCOUNT_PRIVATE_KEY]
+        : undefined,
+      tags: ["etherscan", "tenderly"],
+    },
   },
   tenderly: {
     username: "thesis",
@@ -73,7 +81,7 @@ const config: HardhatUserConfig = {
     deployments: {
       // For hardhat environment we can fork the mainnet, so we need to point it
       // to the contract artifacts.
-      // hardhat: ["./external/mainnet"],
+      // hardhat: ["./external/mainnet-v2"],
       // For development environment we expect the local dependencies to be linked
       // with `yarn link` command.
       development: [
@@ -103,7 +111,7 @@ const config: HardhatUserConfig = {
     },
     treasuryGuild: {
       default: 3,
-      mainnet: "0x0", // tbd
+      mainnet: "0x71E47a4429d35827e0312AA13162197C23287546",
     },
   },
   mocha: {