[codex] fail fast on incomplete RPC data (#524)

* fail fast on incomplete RPC data

* stabilize e2e RPC-driven class fetches

* fix fmt and clippy warnings

* address PR review feedback

Author: prkpndy

Makefile

@@ -3,6 +3,8 @@
 
 DEFAULT_NETWORK := sepolia
 DEFAULT_BLOCK_NUMBERS := 924015
+E2E_TEST_THREADS ?= 1
+E2E_SNOS_MAX_PARALLEL_BLOCKS ?= 1
 
 # Starknet Sepolia
 SEPOLIA_RPC_URL ?= https://pathfinder-sepolia.d.karnot.xyz
@@ -143,7 +145,8 @@ test-e2e: ## Run simple parameterized PIE generation tests
 	RUST_LOG=info \
 	SNOS_RPC_URL="$(MAINNET_RPC_URL)" \
 	SNOS_RPC_URL_SEPOLIA="$(SEPOLIA_RPC_URL)" \
-	cargo test -p e2e-tests test_pie_generation -- --nocapture
+	SNOS_MAX_PARALLEL_BLOCKS="$(E2E_SNOS_MAX_PARALLEL_BLOCKS)" \
+	cargo test -p e2e-tests test_pie_generation -- --nocapture --test-threads=$(E2E_TEST_THREADS)
 
 test-all: test-workspace test-e2e ## Run all tests (unit + integration + e2e)
 

crates/core/generate-pie/src/conversions.rs

@@ -63,6 +63,8 @@ pub enum ConversionError {
     FieldConversionFailed { field: String, reason: String },
     #[error("Missing transaction receipt for {tx_hash:#x}")]
     MissingTransactionReceipt { tx_hash: Felt },
+    #[error("Missing proof facts in RPC response for transaction {tx_hash:#x}")]
+    MissingProofFacts { tx_hash: Felt },
 }
 
 // ================================================================================================
@@ -306,8 +308,15 @@ pub(crate) fn transaction_receipt_hash(receipt: &TransactionReceipt) -> Felt {
     }
 }
 
-fn proof_facts_from_rpc(proof_facts: Option<Vec<Felt>>) -> starknet_api::transaction::fields::ProofFacts {
-    proof_facts.unwrap_or_default().into()
+#[expect(
+    clippy::result_large_err,
+    reason = "ConversionError is shared across transaction conversions and not worth boxing here"
+)]
+fn proof_facts_from_rpc(
+    tx_hash: Felt,
+    proof_facts: Option<Vec<Felt>>,
+) -> Result<starknet_api::transaction::fields::ProofFacts, ConversionError> {
+    proof_facts.ok_or(ConversionError::MissingProofFacts { tx_hash }).map(Into::into)
 }
 
 #[allow(clippy::result_large_err)]
@@ -425,7 +434,7 @@ impl TryIntoBlockifierAsync<TransactionConversionResult> for InvokeTransactionV3
             account_deployment_data: starknet_api::transaction::fields::AccountDeploymentData(
                 self.account_deployment_data,
             ),
-            proof_facts: proof_facts_from_rpc(self.proof_facts),
+            proof_facts: proof_facts_from_rpc(self.transaction_hash, self.proof_facts)?,
         });
 
         let invoke_tx = starknet_api::executable_transaction::InvokeTransaction::create(api_tx, ctx.chain_id)?;
@@ -795,4 +804,75 @@ mod tests {
         assert_eq!(converted_tx.proof_facts_length(), 3);
         assert_eq!(converted_tx.tx_hash().0, tx.transaction_hash);
     }
+
+    #[tokio::test]
+    async fn invoke_v3_conversion_rejects_missing_proof_facts() {
+        let chain_id = ChainId::Sepolia;
+        let rpc_client = RpcClient::try_new("http://localhost:9545").expect("valid dummy rpc url");
+        let transaction_receipts = HashMap::new();
+        let ctx = ConversionContext::new(&chain_id, 9112643, &rpc_client, &transaction_receipts);
+        let tx = InvokeTransactionV3 {
+            transaction_hash: Felt::from(123_u64),
+            sender_address: Felt::from_hex_unchecked(
+                "0x041c9dbe8ab9b414fa0ec4d22b7a41d80a3911b77a2c9c819ce949faa5edb9f9",
+            ),
+            calldata: vec![Felt::ONE],
+            signature: vec![Felt::TWO],
+            nonce: Felt::from(7_u64),
+            resource_bounds: ResourceBoundsMapping {
+                l1_gas: ResourceBounds { max_amount: 1_000_000, max_price_per_unit: 1 },
+                l2_gas: ResourceBounds { max_amount: 2_000_000, max_price_per_unit: 3 },
+                l1_data_gas: ResourceBounds { max_amount: 4_000_000, max_price_per_unit: 5 },
+            },
+            tip: 0,
+            paymaster_data: vec![],
+            account_deployment_data: vec![],
+            nonce_data_availability_mode: DataAvailabilityMode::L1,
+            fee_data_availability_mode: DataAvailabilityMode::L1,
+            proof_facts: None,
+        };
+
+        let error = tx.try_into_blockifier_async(&ctx).await.expect_err("missing proof facts must fail");
+
+        assert!(matches!(error, ConversionError::MissingProofFacts { tx_hash } if tx_hash == Felt::from(123_u64)));
+    }
+
+    #[tokio::test]
+    async fn invoke_v3_conversion_accepts_empty_proof_facts() {
+        let chain_id = ChainId::Sepolia;
+        let rpc_client = RpcClient::try_new("http://localhost:9545").expect("valid dummy rpc url");
+        let transaction_receipts = HashMap::new();
+        let ctx = ConversionContext::new(&chain_id, 9112643, &rpc_client, &transaction_receipts);
+        let tx = InvokeTransactionV3 {
+            transaction_hash: Felt::ZERO,
+            sender_address: Felt::from_hex_unchecked(
+                "0x041c9dbe8ab9b414fa0ec4d22b7a41d80a3911b77a2c9c819ce949faa5edb9f9",
+            ),
+            calldata: vec![Felt::ONE],
+            signature: vec![Felt::TWO],
+            nonce: Felt::from(7_u64),
+            resource_bounds: ResourceBoundsMapping {
+                l1_gas: ResourceBounds { max_amount: 1_000_000, max_price_per_unit: 1 },
+                l2_gas: ResourceBounds { max_amount: 2_000_000, max_price_per_unit: 3 },
+                l1_data_gas: ResourceBounds { max_amount: 4_000_000, max_price_per_unit: 5 },
+            },
+            tip: 0,
+            paymaster_data: vec![],
+            account_deployment_data: vec![],
+            nonce_data_availability_mode: DataAvailabilityMode::L1,
+            fee_data_availability_mode: DataAvailabilityMode::L1,
+            proof_facts: Some(vec![]),
+        };
+
+        let result = tx.try_into_blockifier_async(&ctx).await.expect("empty proof facts should be accepted");
+
+        let converted_tx = match result.starknet_api_tx {
+            starknet_api::executable_transaction::Transaction::Account(
+                starknet_api::executable_transaction::AccountTransaction::Invoke(invoke_tx),
+            ) => invoke_tx,
+            other => panic!("expected invoke account transaction, got {other:?}"),
+        };
+
+        assert_eq!(converted_tx.proof_facts_length(), 0);
+    }
 }

crates/core/generate-pie/src/error.rs

@@ -164,6 +164,19 @@ pub enum BlockProcessingError {
         source: StarknetApiError,
     },
 
+    /// Missing field in an RPC proof payload.
+    #[error("Missing proof field `{field}` in {proof_side} {proof_kind} proof")]
+    MissingProofField { proof_side: &'static str, proof_kind: &'static str, field: &'static str },
+
+    /// Missing field in an RPC proof payload for a specific contract.
+    #[error("Missing proof field `{field}` in {proof_side} {proof_kind} proof for contract {contract_address:#x}")]
+    MissingProofFieldForContract {
+        proof_side: &'static str,
+        proof_kind: &'static str,
+        field: &'static str,
+        contract_address: Felt,
+    },
+
     /// Initial reads storage extension error.
     #[error("Failed to extend initial reads storage witness: {source}")]
     InitialReadsExtension {