added skip_rollback_on_validation_failure param for conditionally skip transaction rollback; update RODATransactionManager logic for reports with failed steps. (#3572)

Author: eduardojst10

roda-common/roda-common-data/src/main/java/org/roda/core/data/common/RodaConstants.java

@@ -1382,6 +1382,7 @@ public enum OrchestratorType {
   public static final String PLUGIN_PARAMS_DONT_CHECK_RELATIVES = "parameter.dont_check_relatives";
   public static final String PLUGIN_PARAMS_REPRESENTATION_INFORMATION_FILTER = "parameter.representation_information_filter";
   public static final String PLUGIN_PARAMS_RODA_MEMBER_ACTIVATE = "parameter.activate";
+  public static final String PLUGIN_PARAM_SKIP_ROLLBACK_ON_VALIDATION_FAILURE = "parameter.skip_rollback_on_validation_failure";
 
   public static final String PLUGIN_PARAMS_VALIDATE_DESCRIPTIVE_METADATA = "parameter.validate_descriptive_metadata";
   public static final String PLUGIN_PARAMS_DESCRIPTIVE_METADATA_TYPE = "parameter.metadata_type";

roda-core/roda-core/src/main/java/org/roda/core/transaction/RODATransactionManager.java

@@ -8,11 +8,14 @@
 package org.roda.core.transaction;
 
 import java.nio.file.Path;
+import java.util.Arrays;
 import java.util.Date;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 import java.util.UUID;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.stream.Collectors;
 
 import org.roda.core.config.ConfigurationManager;
 import org.roda.core.data.common.RodaConstants;
@@ -126,11 +129,24 @@ private void processPluginExecutionResult(Plugin<IsRODAObject> plugin, UUID tran
       List<Report> nonFailedReports = relatedReports.stream()
         .filter(report -> !PluginState.FAILURE.equals(report.getPluginState())).toList();
 
-      if (!failedReports.isEmpty()) {
-        rollbackTransaction(transactionId);
-        RODATransactionManagerUtils.createTransactionFailureReports(failedReports, nonFailedReports, transactionId,
-          initDate, mainModelService);
-      } else {
+      String noRollback = plugin.getParameterValues()
+        .getOrDefault(RodaConstants.PLUGIN_PARAM_SKIP_ROLLBACK_ON_VALIDATION_FAILURE, "");
+      Set<String> noRollbackPlugins = Arrays.stream(noRollback.split(",")).map(String::trim).filter(s -> !s.isEmpty())
+        .collect(Collectors.toSet());
+      boolean shouldRollback = false;
+      for (Report failedReport : failedReports) {
+        for (Report nestedReport : failedReport.getReports()) {
+          if (nestedReport.getPluginState().equals(PluginState.FAILURE)
+            && !noRollbackPlugins.contains(nestedReport.getPlugin())) {
+            rollbackTransaction(transactionId);
+            RODATransactionManagerUtils.createTransactionFailureReports(failedReports, nonFailedReports, transactionId,
+              initDate, mainModelService);
+            shouldRollback = true;
+          }
+        }
+      }
+
+      if (!shouldRollback) {
         endTransaction(transactionId);
         RODATransactionManagerUtils.createTransactionSuccessReports(relatedReports, transactionId, initDate,
           mainModelService);