fix rust ci, take 2 (#15)

* try not installing rust from `conda-forge`

* link libpython on macos

* guard against an unset `$CONDA_PREFIX`

* more debugging

* use the rust toolchain in python, too

* use maturin to install the library

* set `PYO3_PYTHON` to the python binary in PATH

* create the path that is linked into

* skip testing on windows

* back to setting the absolute python path for pyo3

* skip windows for the python tests, as well

* add a rust cache to speed up the builds

Author: keewis

.github/workflows/python-ci.yml

@@ -45,12 +45,19 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: ["ubuntu-latest", "macos-latest", "windows-latest"]
+        os:
+          - "ubuntu-latest"
+          - "macos-latest"
+          # building the proj-sys crate appears to be tricky on windows
+          # - "windows-latest"
         python-version: ["3.10", "3.12"]
 
     steps:
       - uses: actions/checkout@v4
 
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
       - name: Setup micromamba
         uses: mamba-org/setup-micromamba@v2
         with:
@@ -61,16 +68,24 @@ jobs:
           create-args: >-
             python=${{matrix.python-version}}
 
+      - name: Create rust cache
+        uses: Swatinem/rust-cache@v2
+
       - name: Help finding installed libraries
         run: |
           pushd $CONDA_PREFIX
           echo "PKG_CONFIG_PATH=$(readlink -f lib/pkgconfig)" >> $GITHUB_ENV
           echo "LD_LIBRARY_PATH=$(readlink -f lib)" >> $GITHUB_ENV
           popd
 
+          if [[ -z "$CONDA_PREFIX" ]]; then
+            echo "CONDA_PREFIX is unset!"
+            exit 1
+          fi
+
       - name: Install the package
         run: |
-          python -m pip install --no-deps -e .
+          maturin develop
 
       - name: Check imports
         run: |

.github/workflows/rust-ci.yml

@@ -39,7 +39,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: ["ubuntu-latest", "windows-latest", "macos-latest"]
+        os:
+          - "ubuntu-latest"
+          # building proj-sys on windows appears to not really be possible
+          # - "windows-latest"
+          - "macos-latest"
         python-version: ["3.10", "3.12", "3.13"]
 
     env:
@@ -52,6 +56,10 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
       - name: Setup micromamba
         uses: mamba-org/setup-micromamba@v2
         with:
@@ -60,11 +68,9 @@ jobs:
           cache-environment: true
           cache-environment-key: "${{runner.os}}-${{runner.arch}}-rust-py${{ matrix.python-version }}-${{env.TODAY}}-${{hashFiles(env.CONDA_ENV_FILE)}}"
           create-args: >-
-            rust>=1.83
             python=${{ matrix.python-version }}
       - name: Create rust cache
         uses: Swatinem/rust-cache@v2
-
       - name: Help finding installed libraries
         run: |
           pushd $CONDA_PREFIX
@@ -74,6 +80,18 @@ jobs:
           export PYO3_PYTHON=$(readlink -f bin/python)
           popd
 
+          if [[ -z "$CONDA_PREFIX" ]]; then
+            echo "CONDA_PREFIX is unset!";
+            exit 1
+          fi
+
+          if [[ "${{ matrix.os }}" == "macos-latest" ]]; then
+            mkdir -p target/debug/deps
+            ln -s "$CONDA_PREFIX/lib/libpython${{ matrix.python-version }}.dylib" target/debug/deps
+            ls -l target/debug/deps
+            ls -l $CONDA_PREFIX/lib
+          fi
+
           echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH" >> $GITHUB_ENV
           echo "LD_LIBRARY_PATH=$LD_LIBRARY_PATH" >> $GITHUB_ENV
           echo "CPATH=$CPATH" >> $GITHUB_ENV
@@ -97,11 +115,6 @@ jobs:
           cargo build --tests --keep-going
           cargo test --no-fail-fast
 
-      - name: Cleanup
-        run: |
-          unset LD_LIBRARY_PATH
-          unset DYLD_LIBRARY_PATH
-
   lint:
     name: Lint
     runs-on: ubuntu-latest
@@ -120,6 +133,12 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          components: rustfmt, clippy
+
       - name: Setup micromamba
         uses: mamba-org/setup-micromamba@v2
         with:
@@ -128,10 +147,11 @@ jobs:
           cache-environment: true
           cache-environment-key: "${{runner.os}}-${{runner.arch}}-rust-${{env.TODAY}}-${{hashFiles(env.CONDA_ENV_FILE)}}"
           create-args: >-
-            rust>=1.83
             python=${{ matrix.python-version }}
+
       - name: Create rust cache
         uses: Swatinem/rust-cache@v2
+
       - name: Cargo clippy
         run: |
           cargo clippy --tests -- -D warnings

ci/requirements/environment.yaml

@@ -1,10 +1,8 @@
 channels:
   - conda-forge
 dependencies:
-  - rust
+  - maturin
   - pkg-config
-  - cxx-compiler
-  - c-compiler
   - proj
   - sqlite
   - shapely