change the raised error to TypeError

Author: keewis

pint_xarray/_expects.py

@@ -78,7 +78,7 @@ def wrapper(*args, **kwargs):
                             isinstance(value, (xr.DataArray, xr.Dataset))
                             and value.pint.units
                         ):
-                            raise ValueError(
+                            raise TypeError(
                                 "Passed in a quantity where none was expected"
                             )
                         continue
@@ -87,7 +87,7 @@ def wrapper(*args, **kwargs):
                     elif isinstance(value, (xr.DataArray, xr.Dataset)):
                         params.arguments[name] = value.pint.to(units).pint.dequantify()
                     else:
-                        raise ValueError(
+                        raise TypeError(
                             f"Attempting to convert non-quantity {value} to {units}."
                         )
                 except Exception as e:

pint_xarray/tests/test_expects.py

@@ -55,11 +55,11 @@ def func(a, b, c=1):
             (
                 ureg.Quantity(1, "m"),
                 (None, None),
-                ValueError,
+                TypeError,
                 "Passed in a quantity where none was expected",
                 True,
             ),
-            (1, ("m", None), ValueError, "Attempting to convert non-quantity", True),
+            (1, ("m", None), TypeError, "Attempting to convert non-quantity", True),
             (
                 1,
                 (None,),