Keep Package id / Resource id / Size on the resource page regardless of template precedence

The whitelist that limits the resource "Additional Information" table to
Package id, Resource id and Size lived in the theme's copy of
scheming/package/resource_read.html. That template only renders when
ckanext-iaea outranks ckanext-scheming in ckan.plugins (earlier in the list ==
higher template precedence). Where it loses, ckanext-scheming's copy renders
instead: the same fields come out as collapsible <tr class="toggle-more"> rows,
and custom.css was hiding both those rows and the "Show more" button that would
expand them, so the three fields disappeared with no way to reach them.

Move the whitelist and labels into a format_resource_items helper that
overrides the core helper of the same name. All three copies of
resource_read.html -- core's, scheming's and ours -- source their rows from
that helper, so the filtering holds whichever one renders.

Flip the CSS to force .toggle-more rows visible instead of hidden. Nothing
worth collapsing survives the helper now, and the toggle control stays hidden.

Verified both ways against a local resource page: with the theme template
present the output is unchanged, and with it removed (reproducing the losing
case) the same four rows render with the correct labels instead of 20 hidden
ones.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: blagojabozinovski

ckanext/iaea/assets/css/custom.css

@@ -479,14 +479,19 @@ div.dtr-bs-modal .modal-header .modal-title {
     padding-right: 36px;
 }
 /* Resource "Additional Information" table: remove the "Show more" / "Hide"
-   toggle so it renders as a plain static table and the collapsible rows (the
-   raw resource-dict fields: Ckan url, Datastore active, Has views, Hash,
-   Ignore hash, Mimetype, etc.) never become reachable in the UI.
+   toggle so it renders as a plain static table.
    table-toggle-more.js injects a <tr class="toggle-show toggle-show-more">
    holding the show-more/show-less links plus a <tr class="toggle-seperator">;
-   the .toggle-more data rows are hidden by core CSS in the collapsed
-   (.table-toggle-more) state. We hide the toggle row + separator in BOTH
-   states and force the collapsible rows to stay hidden even if the state flips.
+   we hide both in either state so no toggle control is ever shown.
+
+   The .toggle-more data rows are then forced VISIBLE, reversing core's
+   `.js .table-toggle-more .toggle-more { display: none }`. Those rows only
+   exist when ckanext-scheming's (or core's) resource_read.html renders instead
+   of ours -- and what lands in them is already restricted to Package id /
+   Resource id / Size by our format_resource_items helper override, so there is
+   nothing left worth collapsing. Hiding them instead, as this rule used to,
+   made those three fields unreachable on any deployment where our template
+   lost, with no button left to expand them.
    Global is safe here: the only other user of .table-toggle-more is the
    tabledesigner choice snippet, and the tabledesigner plugin is not enabled. */
 .table-toggle-more .toggle-show,
@@ -495,6 +500,7 @@ div.dtr-bs-modal .modal-header .modal-title {
 .table-toggle-less .toggle-seperator {
     display: none !important;
 }
+.table-toggle-more .toggle-more,
 .table-toggle-less .toggle-more {
-    display: none !important;
+    display: table-row !important;
 }

ckanext/iaea/helpers.py

@@ -76,8 +76,46 @@ def get_main_organization():
 def is_rtl_language():
     return lang() in config.get('ckan.i18n.rtl_languages', 'he ar fa_IR').split()
 
+
+# Raw resource-dict fields we allow into the resource "Additional Information"
+# table, mapped to their display labels. Keys are as returned by CKAN's core
+# format_resource_items(), i.e. underscores already replaced with spaces.
+RESOURCE_ITEM_LABELS = {
+    'package id': 'Package id',
+    'id': 'Resource id',
+    'resource id': 'Resource id',
+    'size': 'Size',
+}
+
+
+def format_resource_items(items):
+    '''Overrides the core helper of the same name to whitelist and relabel the
+    raw resource fields shown in the resource "Additional Information" table.
+
+    This deliberately lives in the plugin rather than in the theme's
+    scheming/package/resource_read.html, because that template only wins when
+    ckanext-iaea outranks ckanext-scheming in `ckan.plugins` (earlier in the
+    list == higher template precedence). When it loses, ckanext-scheming's copy
+    renders instead and any whitelist kept in our template is bypassed, which
+    silently drops Package id / Resource id / Size from the page. Every copy of
+    resource_read.html -- core's, scheming's and ours -- feeds its rows from
+    this helper, so filtering here holds regardless of which one renders.
+
+    Callers other than those three templates: none (checked across ckan and all
+    bundled extensions).
+    '''
+    output = []
+    for key, value in h.format_resource_items(items):
+        label = RESOURCE_ITEM_LABELS.get(key)
+        if label:
+            # Translate at call time so the active request locale is used.
+            output.append((tk._(label), value))
+    return output
+
+
 def get_helpers():
     return {
         "iaea_ga_header": googleanalytics_header,
         'iaea_get_available_organizations': get_available_organizations,
+        'format_resource_items': format_resource_items,
     }

ckanext/iaea/templates/scheming/package/resource_read.html

@@ -77,18 +77,15 @@
           {%- endfor -%}
         {%- endblock -%}
         {%- block resource_more_items -%}
-          {#- Whitelist only these raw resource-dict fields, relabel them, and
-              render as plain rows (no toggle-more) so no "Show more" button appears. -#}
-          {%- set item_labels = {
-            'package id': _('Package id'),
-            'id': _('Resource id'),
-            'resource id': _('Resource id'),
-            'size': _('Size'),
-          } -%}
+          {#- The whitelist and the labels now live in ckanext.iaea.helpers
+              .format_resource_items, which overrides the core helper. Keeping
+              them there rather than here means they still apply when this
+              template loses to ckanext-scheming's copy of it (which happens
+              whenever scheming_datasets is listed before iaea in ckan.plugins).
+              Rows are plain -- no toggle-more class -- so no "Show more"
+              button appears when our template is the one that renders. -#}
           {% for key, value in h.format_resource_items(res.items()) %}
-            {% if key in item_labels %}
-              <tr><th scope="row">{{ item_labels[key] }}</th><td>{{ value }}</td></tr>
-            {% endif %}
+            <tr><th scope="row">{{ key }}</th><td>{{ value }}</td></tr>
           {% endfor %}
         {%- endblock -%}
       </tbody>