Skip to content

Commit f446907

Browse files
ndrs-pstaescolar
authored andcommitted
drivers: serial: ra_sci: revise switch-case in callback_adapter
Unified switch-case usage in `uart_ra_sci_callback_adapter` to use `break` instead of `return`. Typically, a `break` is used in switch-case statements unless an early return is necessary, in which case `return` is appropriate. For this case, using a `break` statement is the more suitable choice. Signed-off-by: Pisit Sawangvonganan <[email protected]>
1 parent 189e875 commit f446907

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

drivers/serial/uart_renesas_ra_sci.c

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -860,17 +860,22 @@ static void uart_ra_sci_callback_adapter(struct st_uart_callback_arg *fsp_args)
860860

861861
switch (fsp_args->event) {
862862
case UART_EVENT_TX_COMPLETE:
863-
return async_evt_tx_done(dev);
863+
async_evt_tx_done(dev);
864+
break;
864865
case UART_EVENT_RX_COMPLETE:
865866
async_evt_rx_complete(dev);
866867
case UART_EVENT_ERR_PARITY:
867-
return async_evt_rx_err(dev, UART_ERROR_PARITY);
868+
async_evt_rx_err(dev, UART_ERROR_PARITY);
869+
break;
868870
case UART_EVENT_ERR_FRAMING:
869-
return async_evt_rx_err(dev, UART_ERROR_FRAMING);
871+
async_evt_rx_err(dev, UART_ERROR_FRAMING);
872+
break;
870873
case UART_EVENT_ERR_OVERFLOW:
871-
return async_evt_rx_err(dev, UART_ERROR_OVERRUN);
874+
async_evt_rx_err(dev, UART_ERROR_OVERRUN);
875+
break;
872876
case UART_EVENT_BREAK_DETECT:
873-
return async_evt_rx_err(dev, UART_BREAK);
877+
async_evt_rx_err(dev, UART_BREAK);
878+
break;
874879
case UART_EVENT_TX_DATA_EMPTY:
875880
case UART_EVENT_RX_CHAR:
876881
break;

0 commit comments

Comments
 (0)