Merge pull request brotherbard#68 from RomainMuller/small_fixes

Small fixes

Author: laullon

PBFileChangesTableView.m

@@ -18,7 +18,8 @@ - (NSMenu *)menuForEvent:(NSEvent *)theEvent
 		NSPoint eventLocation = [self convertPoint: [theEvent locationInWindow] fromView: nil];
 		NSInteger rowIndex = [self rowAtPoint:eventLocation];
 		[self selectRowIndexes:[NSIndexSet indexSetWithIndex:rowIndex] byExtendingSelection:TRUE];
-		return [[self delegate] menuForTable: self];
+        // TODO: Fix the coupling so we don't need the cast (at least).
+		return [(PBGitIndexController*)[self delegate] menuForTable: self];
 	}
 
 	return nil;

PBGitCommitController.m

@@ -170,7 +170,7 @@ - (void)commitFinished:(NSNotification *)notification
 {
 	[commitMessageView setEditable:YES];
 	[commitMessageView setString:@""];
-	[webController setStateMessage:[NSString stringWithFormat:[[notification userInfo] objectForKey:@"description"]]];
+	[webController setStateMessage:[NSString stringWithString:[[notification userInfo] objectForKey:@"description"]]];
 	[repository reloadRefs];
 }	
 

PBGitRepository.h

@@ -88,6 +88,7 @@ static NSString * PBStringFromBranchFilterType(PBGitXBranchFilterType type) {
 
 - (NSFileHandle*) handleForCommand:(NSString*) cmd;
 - (NSFileHandle*) handleForArguments:(NSArray*) args;
+- (NSFileHandle*) handleInWorkDirForArguments:(NSArray *)args;
 - (NSFileHandle *) handleInWorkDirForArguments:(NSArray *)args;
 - (NSString*) outputForCommand:(NSString*) cmd;
 - (NSString *)outputForCommand:(NSString *)str retValue:(int *)ret;

PBSourceViewCell.m

@@ -33,7 +33,7 @@ - (NSMenu *) menuForEvent:(NSEvent *)event inRect:(NSRect)rect ofView:(NSOutline
     NSPoint point = [self.controlView convertPoint:[event locationInWindow] fromView:nil];
 	NSInteger row = [view rowAtPoint:point];
 
-	PBGitSidebarController *controller = [view delegate];
+	PBGitSidebarController *controller = (PBGitSidebarController*)[view delegate];
 
 	return [controller menuForRow:row];
 }

PBWebController.h

@@ -9,6 +9,8 @@
 #import <Cocoa/Cocoa.h>
 #import <WebKit/WebKit.h>
 
+#import "PBGitRepository.h"
+
 @interface PBWebController : NSObject {
 	IBOutlet WebView* view;
 	NSString *startFile;
@@ -18,11 +20,11 @@
 	NSMapTable *callbacks;
 
 	// For the repository access
-	IBOutlet id repository;
+	IBOutlet PBGitRepository *repository;
 }
 
 @property (retain) NSString *startFile;
-@property (retain) id repository;
+@property (retain) PBGitRepository *repository;
 
 - (WebScriptObject *) script;
 - (void) closeView;

PBWebHistoryController.m

@@ -122,7 +122,7 @@ - (void)commitDetailsLoaded:(NSNotification *)notification
 	[[view windowScriptObject] callWebScriptMethod:@"showCommit" withArguments:[NSArray arrayWithObject:html]];
 
 #ifdef DEBUG_BUILD
-	NSString *dom=[[[[view mainFrame] DOMDocument] documentElement] outerHTML];
+	NSString *dom=[(DOMHTMLElement*)[[[view mainFrame] DOMDocument] documentElement] outerHTML];
 	NSString *tmpFile=@"~/tmp/test2.html";
 	[dom writeToFile:[tmpFile stringByExpandingTildeInPath] atomically:true encoding:NSUTF8StringEncoding error:nil];
 #endif