show existence of tag on remotes at tag info

Author: Robert Kyriakis

PBGitRepository.h

@@ -132,6 +132,7 @@ dispatch_queue_t PBGetWorkQueue();
 - (BOOL)refExists:(PBGitRef *)ref checkOnRemotesWithoutBranches:(BOOL)remoteCheck;
 - (BOOL)refExistsOnRemote:(PBGitRef*)ref remoteName:(NSString*)remote;
 - (BOOL)refExistsOnAnyRemote:(PBGitRef*)ref;
+- (BOOL)tagExistsOnRemote:(PBGitRef *)ref remoteName:(NSString *)remote;
 - (PBGitRef *)refForName:(NSString *)name;
 
 - (NSArray *) remotes;

PBGitRepository.m

@@ -701,6 +701,24 @@ - (BOOL)refExistsOnAnyRemote:(PBGitRef*)ref
     return NO;
 }
 
+- (BOOL)tagExistsOnRemote:(PBGitRef *)ref remoteName:(NSString *)remote
+{
+    if ((!ref) || (![self hasRemotes]) || (![ref isTag]))
+    {
+        return NO;
+    }
+    
+    int retValue = 1;
+    // Check remote refs/tags/ for tag
+    NSArray *arguments = [NSArray arrayWithObjects:@"ls-remote", @"-t", remote, [ref tagName], nil];
+    NSString *output = [self outputInWorkdirForArguments:arguments retValue:&retValue];
+    if (![output isEqualToString:@""])
+        return YES;
+    
+    return NO;
+}
+
+
 // useful for getting the full ref for a user entered name
 // EX:  name: master
 //       ref: refs/heads/master

PBRefController.m

@@ -241,15 +241,39 @@ - (void) showTagInfoSheet:(PBRefMenuItem *)sender
 	if ([[sender refish] refishType] != kGitXTagType)
 		return;
 
-	NSString *tagName = [(PBGitRef *)[sender refish] tagName];
-
+    PBGitRef *ref = (PBGitRef*)[sender refish]; 
+    NSMutableString *info = [NSMutableString new];
+    
+    NSArray *remotes = [historyController.repository remotes];
+    if (remotes)
+    {
+        for (int i=0; i<[remotes count]; i++)
+        {
+            if ([historyController.repository isRemoteConnected:[PBGitRef refFromString:[NSString stringWithFormat:@"%@%@",kGitXRemoteRefPrefix,[remotes objectAtIndex:i]]]])
+            {
+                [info appendFormat:@"On remote %@:\n%@\n\n",[remotes objectAtIndex:i],[historyController.repository tagExistsOnRemote:ref remoteName:[remotes objectAtIndex:i]]?@"Yes":@"No"];
+            }
+            else
+            {
+                [info appendFormat:@"Remote %@ is not connected!\nCan't check, if tag %@ exists.\n\n",[remotes objectAtIndex:i],[ref tagName]];
+            }
+        }
+    }
+    
 	int retValue = 1;
-	NSArray *args = [NSArray arrayWithObjects:@"tag", @"-n50", @"-l", tagName, nil];
-	NSString *info = [historyController.repository outputInWorkdirForArguments:args retValue:&retValue];
-	if (!retValue) {
-		NSString *message = [NSString stringWithFormat:@"Info for tag: %@", tagName];
-		[historyController.repository.windowController showMessageSheet:message infoText:info];
+	NSArray *args = [NSArray arrayWithObjects:@"tag", @"-n50", @"-l", [ref tagName], nil];
+	NSString *output = [historyController.repository outputInWorkdirForArguments:args retValue:&retValue];    
+	if (!retValue) 
+    {
+        [info appendFormat:@"Annotation or Commitmessage:\n%@",output];
 	}
+    else
+    {
+        [info appendFormat:@"Error:\ngit tag -n50 -l %@\n\n%@",[ref tagName],output];
+	}
+
+    NSString *message = [NSString stringWithFormat:@"Info for tag: %@", [ref tagName]];
+    [historyController.repository.windowController showMessageSheet:message infoText:info];
 }