Skip to content

Commit 1d24c1d

Browse files
David CatmullDavid Catmull
authored andcommitted
hook up helpText; works with tags
1 parent 43e3d46 commit 1d24c1d

File tree

5 files changed

+6
-4
lines changed

5 files changed

+6
-4
lines changed

PBGitRepository.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -326,6 +326,7 @@ - (void) reloadRefs
326326
PBGitRef *newRef = [PBGitRef refFromString:[components objectAtIndex:0]];
327327
PBGitRevSpecifier *revSpec = [[PBGitRevSpecifier alloc] initWithRef:newRef];
328328

329+
[revSpec setHelpText:[self helpTextForRef:newRef]];
329330
[self addBranch:revSpec];
330331
[self addRef:newRef fromParameters:components];
331332
[oldBranches removeObject:revSpec];

PBGitRevSpecifier.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111

1212
@interface PBGitRevSpecifier : NSObject <NSCopying> {
1313
NSString *description;
14+
NSString *helpText;
1415
NSArray *parameters;
1516
NSURL *workingDirectory;
1617
BOOL isSimpleRef;
@@ -36,6 +37,7 @@
3637
+ (PBGitRevSpecifier *)localBranchesRevSpec;
3738

3839
@property(retain) NSString *description;
40+
@property(retain) NSString *helpText;
3941
@property(readonly) NSArray *parameters;
4042
@property(retain) NSURL *workingDirectory;
4143
@property(readonly) BOOL isSimpleRef;

PBGitRevSpecifier.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
@implementation PBGitRevSpecifier
1313

14-
@synthesize parameters, description, workingDirectory;
14+
@synthesize parameters, description, helpText, workingDirectory;
1515
@synthesize isSimpleRef;
1616
@synthesize behind,ahead;
1717

PBGitSidebarController.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ - (void)outlineView:(NSOutlineView *)outlineView willDisplayCell:(PBSourceViewCe
344344

345345
- (NSString *)outlineView:(NSOutlineView *)outlineView toolTipForCell:(NSCell *)cell rect:(NSRectPointer)rect tableColumn:(NSTableColumn *)tc item:(id)item mouseLocation:(NSPoint)mouseLocation
346346
{
347-
return [item helpText];
347+
return [[item revSpecifier] helpText];
348348
}
349349

350350
- (BOOL)outlineView:(NSOutlineView *)outlineView shouldSelectItem:(id)item

PBSourceViewItem.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
@interface PBSourceViewItem : NSObject {
1515
NSMutableArray *children;
1616

17-
NSString *title, *helpText;
17+
NSString *title;
1818
PBGitRevSpecifier *revSpecifier;
1919
PBSourceViewItem *parent;
2020

@@ -43,7 +43,6 @@
4343
- (PBGitRef *) ref;
4444

4545
@property(retain) NSString *title;
46-
@property(retain) NSString *helpText;
4746
@property(readonly) NSMutableArray *children;
4847
@property(assign) BOOL isGroupItem, isUncollapsible;
4948
@property(retain) PBGitRevSpecifier *revSpecifier;

0 commit comments

Comments
 (0)