Skip to content

Commit 59d4a15

Browse files
committed
GitIndex: Fix a few comments
1 parent 029b42c commit 59d4a15

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

PBGitIndex.m

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ - (NSString *) parentTree
142142
return parent;
143143
}
144144

145+
// TODO: make Asynchronous
145146
- (void)commitWithMessage:(NSString *)commitMessage
146147
{
147148
NSMutableString *commitSubject = [@"commit: " mutableCopy];
@@ -419,8 +420,7 @@ - (void)readOtherFiles:(NSNotification *)notification
419420
NSArray *lines = [self linesFromNotification:notification];
420421
NSMutableDictionary *dictionary = [[NSMutableDictionary alloc] initWithCapacity:[lines count]];
421422
// Other files are untracked, so we don't have any real index information. Instead, we can just fake it.
422-
// The line below is used to add the file to the index
423-
// FIXME: request the real file mode
423+
// The line below is not used at all, as for these files the commitBlob isn't set
424424
NSArray *fileStatus = [NSArray arrayWithObjects:@":000000", @"100644", @"0000000000000000000000000000000000000000", @"0000000000000000000000000000000000000000", @"A", nil];
425425
for (NSString *path in lines) {
426426
if ([path length] == 0)
@@ -450,7 +450,6 @@ - (void) readUnstagedFiles:(NSNotification *)notification
450450

451451
- (void) addFilesFromDictionary:(NSMutableDictionary *)dictionary staged:(BOOL)staged tracked:(BOOL)tracked
452452
{
453-
// TODO: Stop tracking files
454453
// Iterate over all existing files
455454
for (PBChangedFile *file in files) {
456455
NSArray *fileStatus = [dictionary objectForKey:file.path];
@@ -494,7 +493,6 @@ - (void) addFilesFromDictionary:(NSMutableDictionary *)dictionary staged:(BOOL)s
494493
file.hasUnstagedChanges = NO;
495494
}
496495
}
497-
// TODO: Finish tracking files
498496

499497
// Do new files only if necessary
500498
if (![[dictionary allKeys] count])
@@ -535,7 +533,7 @@ - (NSArray *)linesFromNotification:(NSNotification *)notification
535533
return [NSArray array];
536534

537535
NSString *string = [[NSString alloc] initWithData:data encoding:NSUTF8StringEncoding];
538-
// FIXME: Return an error?
536+
// FIXME: throw an error?
539537
if (!string)
540538
return [NSArray array];
541539

0 commit comments

Comments
 (0)