Merge pull request #147 from Kyriakis/master

Bugfix Branch Moving

Author: laullon

PBRefController.h

@@ -21,6 +21,7 @@
 	IBOutlet PBCommitList *commitList;
 
 	IBOutlet NSPopUpButton *branchPopUp;
+    NSDictionary *dropInfo;
 }
 
 - (void) fetchRemote:(PBRefMenuItem *)sender;

PBRefController.m

@@ -25,6 +25,13 @@
 
 @implementation PBRefController
 
+-(void)dealloc
+{
+    [dropInfo release];
+    
+    [super dealloc];
+}
+
 - (void)awakeFromNib
 {
 	[commitList registerForDraggedTypes:[NSArray arrayWithObject:@"PBGitRef"]];
@@ -359,7 +366,7 @@ - (NSDragOperation)tableView:(NSTableView*)tv
 	return NSDragOperationNone;
 }
 
-- (void) dropRef:(NSDictionary *)dropInfo
+- (void) dropRef
 {
 	PBGitRef *ref = [dropInfo objectForKey:@"dragRef"];
 	PBGitCommit *oldCommit = [dropInfo objectForKey:@"oldCommit"];
@@ -401,14 +408,14 @@ - (BOOL)tableView:(NSTableView *)aTableView
 
 	PBGitCommit *dropCommit = [[commitController arrangedObjects] objectAtIndex:row];
 
-	NSDictionary *dropInfo = [NSDictionary dictionaryWithObjectsAndKeys:
-							  ref, @"dragRef",
-							  oldCommit, @"oldCommit",
-							  dropCommit, @"dropCommit",
-							  nil];
+	dropInfo = [NSDictionary dictionaryWithObjectsAndKeys:
+                ref, @"dragRef",
+                oldCommit, @"oldCommit",
+                dropCommit, @"dropCommit",
+                nil];
 
 	if ([PBGitDefaults isDialogWarningSuppressedForDialog:kDialogAcceptDroppedRef]) {
-		[self dropRef:dropInfo];
+		[self dropRef];
 		return YES;
 	}
 
@@ -427,7 +434,7 @@ - (BOOL)tableView:(NSTableView *)aTableView
 	[alert beginSheetModalForWindow:[historyController.repository.windowController window]
 					  modalDelegate:self
 					 didEndSelector:@selector(acceptDropInfoAlertDidEnd:returnCode:contextInfo:)
-						contextInfo:dropInfo];
+						contextInfo:Nil];
 
 	return YES;
 }
@@ -437,7 +444,7 @@ - (void)acceptDropInfoAlertDidEnd:(NSAlert *)alert returnCode:(NSInteger)returnC
     [[alert window] orderOut:nil];
 
 	if (returnCode == NSAlertDefaultReturn)
-		[self dropRef:contextInfo];
+		[self dropRef];
 
 	if ([[alert suppressionButton] state] == NSOnState)
         [PBGitDefaults suppressDialogWarningForDialog:kDialogAcceptDroppedRef];