Skip to content

Commit 6fd3397

Browse files
author
Pieter de Bie
committed
Merge branch 'stable'
* stable: PBGitConfig: Add missing sentinel Remove use of deprecated stringWithCString HistoryView: only add parents if parents array exists keyboardNavigation: Fix keys 'c' and 'v' from webView Site: add link to Twitter Conflicts: Site/text/contact.markdown
2 parents fa6ff44 + 69759e7 commit 6fd3397

File tree

6 files changed

+13
-8
lines changed

6 files changed

+13
-8
lines changed

PBGitBinary.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ + (void) initialize
6666

6767
// Try to find the path of the Git binary
6868
char* path = getenv("GIT_PATH");
69-
if (path && [self acceptBinary:[NSString stringWithCString:path]])
69+
if (path && [self acceptBinary:[NSString stringWithUTF8String:path]])
7070
return;
7171

7272
// No explicit path. Try it with "which"

PBGitConfig.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ - (void) setValue:(id)value forKeyPath:(NSString *)path
7979

8080
// Check if it exists globally. In that case, write it as a global
8181

82-
NSArray *arguments = [NSArray arrayWithObjects:@"config", @"--global", @"--get", path];
82+
NSArray *arguments = [NSArray arrayWithObjects:@"config", @"--global", @"--get", path, nil];
8383
int ret;
8484
[PBEasyPipe outputForCommand:[PBGitBinary path] withArgs:arguments inDir:nil retValue:&ret];
8585
if (!ret) // It exists globally

Site/templates/site.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<%= @body %>
4141
</div>
4242
<div id="footer">
43-
© Some rights reserved. <a href="http://github.com/pieter/gitx/tree/master/COPYING" title="GPL">GPL v2</a>. <a href="mailto:[email protected]">Pieter de Bie</a> is the GitX maintainer. Website design by <a href="http://www.ai.rug.nl/~kdoes/index.php?id=webdesign">Kim Does</a>.
43+
© Some rights reserved. <a href="http://github.com/pieter/gitx/tree/master/COPYING" title="GPL">GPL v2</a>. <a href="mailto:[email protected]">Pieter de Bie</a> (<a href="http://twitter.com/pdebie">@pdebie</a>) is the GitX maintainer. Website design by <a href="http://www.ai.rug.nl/~kdoes/index.php?id=webdesign">Kim Does</a>.
4444
</div>
4545
</div>
4646
<script type="text/javascript">

Site/text/contact.markdown

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,6 @@ Contact
44

55
The GitX repository can be found on Github at [http://github.com/pieter/gitx](http://www.github.com/pieter/gitx/wikis).
66

7-
GitX has a mailing list at [[email protected]](mailto:[email protected]) to which you can email any questions or patches. GitX is actively maintained by Pieter de Bie. You can email him at [[email protected]](mailto:[email protected]).
7+
GitX has a mailing list at [[email protected]](mailto:[email protected]) to which you can email any questions or patches.
8+
9+
GitX is actively maintained by Pieter de Bie. You can email him at [[email protected]](mailto:[email protected]) or on twitter <a href="http://twitter.com/pdebie">@pdebie</a>

gitx.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ int main(int argc, const char** argv)
133133
NSMutableArray* arguments = [NSMutableArray arrayWithCapacity:argc];
134134
int i = 0;
135135
for (i = 0; i < argc; i++)
136-
[arguments addObject: [NSString stringWithCString:argv[i]]];
136+
[arguments addObject: [NSString stringWithUTF8String:argv[i]]];
137137

138138
if (!isatty(STDIN_FILENO) && fdopen(STDIN_FILENO, "r"))
139139
handleSTDINDiff(proxy);

html/views/history/history.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,18 @@ var loadCommit = function(commitObject, currentRef) {
184184
}
185185
}
186186

187+
// Scroll to top
188+
scroll(0, 0);
189+
190+
if (!commit.parents)
191+
return;
192+
187193
for (var i = 0; i < commit.parents.length; i++) {
188194
var newRow = $("commit_header").insertRow(-1);
189195
newRow.innerHTML = "<td class='property_name'>Parent:</td><td>" +
190196
"<a href='' onclick='selectCommit(this.innerHTML); return false;'>" +
191197
commit.parents[i] + "</a></td>";
192198
}
193-
194-
// Scroll to top
195-
scroll(0, 0);
196199
}
197200

198201
var showDiff = function() {

0 commit comments

Comments
 (0)